Re: Review Request 53215: Ubuntu16 Add Support for Spark on HDP 2.5

2016-10-28 Thread Duc Le
/services/SPARK/metainfo.xml 5d60788 Diff: https://reviews.apache.org/r/53215/diff/ Testing --- E2E testing done through Ambari Rolling Upgrade. Thanks, Duc Le

Re: Review Request 53502: AMBARI-18681 Add host structured_out to manual task

2016-11-08 Thread Duc Le
what possible values of the enum are. - Duc --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53502/#review155291 ------- On Nov. 8, 2016, 3:42 a.m., Duc Le wrote: > > ---

Re: Review Request 53502: AMBARI-18681 Add host structured_out to manual task

2016-11-08 Thread Duc Le
; I did mark it as Ship It, but I'm curious if we want to have this as a > > separate enum? > > Duc Le wrote: > If we don't use HostOrderActionType.HOST_UPGRADE, I would use a constant > string for now until we know better about what possible values of the enum > are.

Re: Review Request 53618: Add prerequisite check for any host in Maintenance Mode when upgrade type is HOST_ORDERED

2016-11-09 Thread Duc Le
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53618/#review155480 --- Ship it! Ship It! - Duc Le On Nov. 9, 2016, 7:14 p.m., Nate

Re: Review Request 53618: Add prerequisite check for any host in Maintenance Mode when upgrade type is HOST_ORDERED

2016-11-09 Thread Duc Le
> On Nov. 9, 2016, 6:13 p.m., Jonathan Hurley wrote: > > Ship It! I'm still figuring out how to review, so posting this comment here. Don't we need to update the description on line 50? super(CheckDescription.HOSTS_MAINTENANCE_MODE); - Duc

Re: Review Request 53502: AMBARI-18681 Add host structured_out to manual task

2016-11-07 Thread Duc Le
: 209.464 sec - in org.apache.ambari.server.state.UpgradeHelperTest ... Tests run: 4727, Failures: 0, Errors: 0, Skipped: 42 Thanks, Duc Le

Review Request 53502: AMBARI-18681 Add host structured_out to manual task

2016-11-04 Thread Duc Le
Diff: https://reviews.apache.org/r/53502/diff/ Testing --- TBD Thanks, Duc Le

Re: Review Request 53502: AMBARI-18681 Add host structured_out to manual task

2016-11-04 Thread Duc Le
/stack/upgrade/HostOrderGrouping.java b999f2f Diff: https://reviews.apache.org/r/53502/diff/ Testing --- TBD Thanks, Duc Le

Re: Review Request 53502: AMBARI-18681 Add host structured_out to manual task

2016-11-07 Thread Duc Le
Thanks, Duc Le

Re: Review Request 54047: AMBARI-18980 Add manual confirm task before finalizing host-ordered upgrade

2016-11-23 Thread Duc Le
-upgrade.xml 72241eea Diff: https://reviews.apache.org/r/54047/diff/ Testing (updated) --- Manifest change only. Unit tests not affected. E2E test done on real cluster. Thanks, Duc Le

Review Request 54047: AMBARI-18980 Add manual confirm task before finalizing host-ordered upgrade

2016-11-23 Thread Duc Le
://reviews.apache.org/r/54047/diff/ Testing --- Manifest change only. Unit tests not affected. E2E test pending. Thanks, Duc Le

Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5

2016-11-29 Thread Duc Le
: https://reviews.apache.org/r/54175/diff/ Testing --- Manifest change only. Unit test not affected. Tested E2E. Thanks, Duc Le

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5

2016-11-30 Thread Duc Le
erred option? - Duc --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54175/#review157453 --- On Nov. 29, 2016, 8:

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5

2016-11-30 Thread Duc Le
) - ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.6/metainfo.xml 525078e Diff: https://reviews.apache.org/r/54175/diff/ Testing --- Manifest change only. Unit test not affected. Tested E2E. Thanks, Duc Le

Re: Review Request 54384: Host-Ordered: Empty groups are returned for Downgrade

2016-12-05 Thread Duc Le
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54384/#review158023 --- Ship it! Ship It! - Duc Le On Dec. 5, 2016, 6:08 p.m., Nate

Review Request 59928: AMBARI-21205 Make ToggleKerberos and AddDeleteService experimental features

2017-06-08 Thread Duc Le via Review Board
/main/menu.js 00b1c38 ambari-web/app/views/main/service/item.js 09457f2 Diff: https://reviews.apache.org/r/59928/diff/1/ Testing --- Manual build and E2E testing Thanks, Duc Le

Re: Review Request 59928: AMBARI-21205 Make ToggleKerberos and AddDeleteService experimental features

2017-06-08 Thread Duc Le via Review Board
/services_view.js f566814 ambari-web/app/views/main/menu.js 00b1c38 ambari-web/app/views/main/service/item.js 09457f2 Diff: https://reviews.apache.org/r/59928/diff/2/ Changes: https://reviews.apache.org/r/59928/diff/1-2/ Testing --- Manual build and E2E testing Thanks, Duc Le

Re: Review Request 59928: AMBARI-21205 Make ToggleKerberos and AddDeleteService experimental features

2017-06-08 Thread Duc Le via Review Board
://reviews.apache.org/r/59928/diff/3/ Changes: https://reviews.apache.org/r/59928/diff/2-3/ Testing --- Manual build and E2E testing Thanks, Duc Le

Re: Review Request 59928: AMBARI-21205 Make ToggleKerberos and AddDeleteService experimental features

2017-06-08 Thread Duc Le via Review Board
pdated the UTs accordingly. - Duc --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59928/#review177376 --- On June 8, 2017, 10:06 p.m., Duc Le wrote: