Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-08 Thread Shantanu Mundkur
b5224-b255-404a-bd24-1b3ce5f79649__AMBARI-15331.patch Thanks, Shantanu Mundkur

Re: Review Request 40527: AMBARI-11825: Failure to add or install component defined with cardinality ALL

2016-03-08 Thread Shantanu Mundkur
uot; cardinlaity for master components then > > lets not show any master host component with "ALL" cardinality on "Assign > > Masters page". It will be confusing if end-user deselects host components > > on "Assign Master" page and even after that amba

Re: Review Request 40527: AMBARI-11825: Failure to add or install component defined with cardinality ALL

2016-03-08 Thread Shantanu Mundkur
uot; cardinlaity for master components then > > lets not show any master host component with "ALL" cardinality on "Assign > > Masters page". It will be confusing if end-user deselects host components > > on "Assign Master" page and even after that amba

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Shantanu Mundkur
imental and so thought a default of False might have been preferable but Ambari chooses it as True out of the box. Thoughts? Thanks. - Shantanu --- This is an automatically generated e-mail. To reply, visit: https://reviews

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Shantanu Mundkur
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44525/#review122808 ------- On March 9, 2016, 8:59 p.m., Shantanu Mundkur wrote: > > --- > This is an automatically

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Shantanu Mundkur
; > > > In any case, after https://issues.apache.org/jira/browse/AMBARI-15170, > > these properties are not used in the ambari-metrics-collector startup > > script. > > Shantanu Mundkur wrote: > Aravindan, > > That is right. We don't really ne

Re: Review Request 44525: AMBARI-15331: AMS HBase FIFO compaction policy and Normalizer settings are not handled correctly

2016-03-09 Thread Shantanu Mundkur
mail. To reply, visit: https://reviews.apache.org/r/44525/#review122828 --- On March 9, 2016, 8:59 p.m., Shantanu Mundkur wrote: > > --- > This is an automatically generated

Review Request 45056: Blueprint install using config_recommendation_strategy is not functional

2016-03-18 Thread Shantanu Mundkur
onfigurationProcessor.java f5e7578 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 68d5755 Diff: https://reviews.apache.org/r/45056/diff/ Testing --- 1) ambari-server unit tests Results : Tests run: 3968, Failures: 0, Errors: 0, Skipped: 33 2) Added unit test to ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java 3) Deployed clusters 1-5 nodes specifying "config_recommendation_strategy" : "ONLY_STACK_DEFAULTS_APPLY" Thanks, Shantanu Mundkur

Re: Review Request 45056: Blueprint install using config_recommendation_strategy is not functional

2016-03-21 Thread Shantanu Mundkur
created? Thank you. - Shantanu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45056/#review124404 --- On March 18, 2016, 10:31 p.m., Shantanu Mundkur wrote: > > --

Re: Review Request 45056: Blueprint install using config_recommendation_strategy is not functional

2016-03-23 Thread Shantanu Mundkur
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45056/#review124404 ------- On March 18, 2016, 10:31 p.m., Shantanu Mundkur wrote: > > --- >

Review Request 46420: AMBARI-15496: /var/lib/ambari-agent/cache/cluster_configuration/configurations.json file contains various passwords in plain text in world readable file

2016-04-19 Thread Shantanu Mundkur
test_missing_shell_argument (TestUserResource.TestUserResource) ... FAIL Thanks, Shantanu Mundkur

Re: Review Request 46420: AMBARI-15496: /var/lib/ambari-agent/cache/cluster_configuration/configurations.json file contains various passwords in plain text in world readable file

2016-04-20 Thread Shantanu Mundkur
t Am I missing something? - Shantanu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46420/#review129764 --- On April 20,

Re: Review Request 46420: AMBARI-15496: /var/lib/ambari-agent/cache/cluster_configuration/configurations.json file contains various passwords in plain text in world readable file

2016-04-20 Thread Shantanu Mundkur
views.apache.org/r/46420/#review129792 --- On April 20, 2016, 2:57 a.m., Shantanu Mundkur wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 45507: Enhance blueprint support for using references

2016-04-28 Thread Shantanu Mundkur
> On April 28, 2016, 9:17 p.m., Shantanu Mundkur wrote: > > Bob, Jayush, > > > > Thanks for reviewing this. > > > > Your review comments for the code changes are valid and Amruta will make > > changes or respond to those. > > > > I ha

Re: Review Request 45507: Enhance blueprint support for using references

2016-04-28 Thread Shantanu Mundkur
you! - Shantanu Mundkur On March 30, 2016, 10:19 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 49721: AMBARI-17580: Unable to add MASTER component on all nodes

2016-07-06 Thread Shantanu Mundkur
/diff/ Testing --- 1) Tried to add a custom service with cardinality as ALL for a MASTER component (that was previously the failing case). 2) Unit tests: Under ambari-web: mvn clean test Results: 28946 tests complete (37 seconds) 154 tests pending Thanks, Shantanu Mundkur

Re: Review Request 49721: AMBARI-17580: Unable to add MASTER component on all nodes

2016-07-08 Thread Shantanu Mundkur
iew141328 --- On July 6, 2016, 7:20 p.m., Shantanu Mundkur wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie