Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-06-16 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/ --- (Updated June 16, 2016, 6:16 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-06-16 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/#review137968 --- What's the status of this review - it's a month old. Has it been c

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-05-05 Thread Jonathan Hurley
> On April 28, 2016, 10:50 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, > > lines 36-39 > > > > > > As these are user-faci

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/#review131142 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-28 Thread Swapan Shridhar
> On April 28, 2016, 8:15 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json, > > line 154 > > > > > > What's the average time to run? > > Perhaps 4

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-28 Thread Swapan Shridhar
> On April 28, 2016, 2:50 p.m., Jonathan Hurley wrote: > > I've never installed LLAP before - Is this data you're getting exposed via > > JMX as a metric? It it was, it would save you a lot of effort in getting > > things like liveInstances. I dont think it's getting exposed via JMX. i'll stil

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/#review130985 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/#review130918 --- I've never installed LLAP before - Is this data you're getting exp

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-28 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/ --- (Updated April 28, 2016, 9:52 a.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-28 Thread Swapan Shridhar
> On April 28, 2016, 2:50 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py, > > line 22 > > > > > > Lets remove all the commented

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-27 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/#review130876 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

2016-04-27 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46760/#review130878 --- Ship it! Fix the issues and ship. - Sumit Mohanty On April 2