Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-11 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47027/#review132622 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 10, 2016, 3:25 p

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-10 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47027/ --- (Updated May 10, 2016, 3:25 p.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-10 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47027/ --- (Updated May 10, 2016, 10:34 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47027/#review132310 --- Ship it! ambari-views/src/main/java/org/apache/ambari/view/Clu

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-09 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47027/ --- (Updated May 9, 2016, 5:13 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, J

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-09 Thread Jonathan Hurley
> On May 6, 2016, 10:38 a.m., Jonathan Hurley wrote: > > ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterStreamProvider.java, > > line 28 > > > > > > How is this different from AmbariStreamProvider whi

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-09 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47027/ --- (Updated May 9, 2016, 1:48 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, J

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-06 Thread Jonathan Hurley
> On May 6, 2016, 10:38 a.m., Jonathan Hurley wrote: > > contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java, > > line 121 > > > > > > Why is this commen

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-06 Thread Gaurav Nagar
> On May 6, 2016, 2:38 p.m., Jonathan Hurley wrote: > > ambari-views/src/main/java/org/apache/ambari/view/ClusterType.java, line 27 > > > > > > Doesn't have to be one or the other - NONE doesn't seem to make sense >

Re: Review Request 47027: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Views changes

2016-05-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47027/#review132034 --- ambari-views/src/main/java/org/apache/ambari/view/AmbariClusterSt