Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-11-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review155209 --- Pushed to trunk, commit 3ec7df13485b629bcf08310f3916b6401f827dbe b

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-11-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review154706 --- What's the state of this review? Can it be closed? - Jonathan Hur

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-21 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review153551 --- Ship it! Ship It! - Nate Cole On Oct. 19, 2016, 6:51 p.m., A

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-19 Thread Amarnath reddy pappu
> On Oct. 18, 2016, 9:15 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2428 > > > > > > nit: "Indicates the delay, in milliseconds, for

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-19 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/ --- (Updated Oct. 19, 2016, 10:51 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-19 Thread Attila Doroszlai
> On Oct. 18, 2016, 7:37 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 953-954 > > > > > > Variable names `monitor_delay` and `monitor

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-18 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review153176 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-18 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/ --- (Updated Oct. 18, 2016, 6:29 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-18 Thread Amarnath reddy pappu
> On Oct. 18, 2016, 5:37 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > lines 950-951 > > > > > > Whitespace: missing between `){`, and extra

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-18 Thread Amarnath reddy pappu
> On Oct. 14, 2016, 8:59 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2430 > > > > > > How about using `TimeUnit.MINUTES.toMillis

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-17 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review153034 --- ambari-server/src/main/java/org/apache/ambari/server/controller/A

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-17 Thread Attila Doroszlai
> On Oct. 14, 2016, 10:59 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2430 > > > > > > How about using `TimeUnit.MINUTES.toMilli

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-17 Thread Amarnath reddy pappu
> On Oct. 13, 2016, 7:35 p.m., Jonathan Hurley wrote: > > Ship It! thank you - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152562 -

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-17 Thread Amarnath reddy pappu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/ --- (Updated Oct. 17, 2016, 11:07 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-17 Thread Amarnath reddy pappu
> On Oct. 13, 2016, 11:10 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 512 > > > > > > I'm curious - why use the configuration property getDe

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-17 Thread Amarnath reddy pappu
> On Oct. 14, 2016, 8:59 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2430 > > > > > > How about using `TimeUnit.MINUTES.toMillis

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-17 Thread Jonathan Hurley
> On Oct. 13, 2016, 7:10 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 512 > > > > > > I'm curious - why use the configuration property getDef

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-14 Thread Attila Doroszlai
> On Oct. 14, 2016, 1:10 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 512 > > > > > > I'm curious - why use the configuration property getDef

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-14 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152643 --- ambari-server/src/main/java/org/apache/ambari/server/configuratio

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-13 Thread Nate Cole
> On Oct. 13, 2016, 7:10 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 512 > > > > > > I'm curious - why use the configuration property getDef

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-13 Thread Amarnath reddy pappu
> On Oct. 13, 2016, 6:20 p.m., Alejandro Fernandez wrote: > > Ship It! thank you - Amarnath reddy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152549 -

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-13 Thread Amarnath reddy pappu
> On Oct. 13, 2016, 11:10 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 512 > > > > > > I'm curious - why use the configuration property getDe

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152595 --- ambari-server/src/main/java/org/apache/ambari/server/controller/A

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152562 --- Ship it! Ship It! - Jonathan Hurley On Oct. 13, 2016, 2:01 p

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

2016-10-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152549 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 13, 2016, 6: