Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review80210 --- Ship it! lgtm modulo the style nit below src/test/python/apache/a

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 15, 2015, 8:38 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-15 Thread Stephan Erb
> On April 15, 2015, 6:48 p.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/executor/test_thermos_task_runner.py, lines > > 226-227 > > > > > > nit: our python style for continuations is: > > > >

Review Request 33233: Updated mesos library to 0.22.0.

2015-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33233/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1276

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/ --- (Updated April 15, 2015, 7:05 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review80253 --- Ship it! Master (10e75fc) is green with this patch. ./build-suppo

Re: Review Request 33233: Updated mesos library to 0.22.0.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33233/#review80255 --- Ship it! Master (10e75fc) is green with this patch. ./build-suppo

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review80256 --- src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTa

Review Request 33235: Fixing e2e kerberos tests.

2015-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33235/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 33235: Fixing e2e kerberos tests.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33235/#review80264 --- Ship it! Master (10e75fc) is green with this patch. ./build-suppo

Re: Review Request 33235: Fixing e2e kerberos tests.

2015-04-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33235/#review80269 --- Ship it! Ship It! - Kevin Sweeney On April 15, 2015, 1:01 p.m.,

Re: Review Request 33233: Updated mesos library to 0.22.0.

2015-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33233/ --- (Updated April 15, 2015, 10:42 p.m.) Review request for Aurora, Maxim Khutornen

Review Request 33244: Fixed the end-to-end tests.

2015-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33244/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Review Request 33243: Use explicit status update acknowledgements.

2015-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1228 https://issues

Re: Review Request 33244: Fixed the end-to-end tests.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33244/#review80277 --- This patch does not apply cleanly on master (b18dc44), do you need t

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review80276 --- Master (b18dc44) is red with this patch. ./build-support/jenkins/b

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-15 Thread Ben Mahler
> On April 15, 2015, 10:49 p.m., Aurora ReviewBot wrote: > > Master (b18dc44) is red with this patch. > > ./build-support/jenkins/build.sh > > > > :compileJavaNote: Writing > > file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review80278 --- Looks like you forgot to git add build.gradle? src/main/java/org/a

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
> On April 15, 2015, 7:58 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, > > line 140 > > > > > > How about > > ``` > > ImmutableSet.copyOf(Se

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/ --- (Updated April 16, 2015, 1:39 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 33244: Fixed the end-to-end tests.

2015-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33244/#review80291 --- I have already landed the fix in: https://reviews.apache.org/r/33235

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review80292 --- Ship it! Master (b18dc44) is green with this patch. ./build-suppo