Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-16 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aur

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-16 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88042 --- src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java (line

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-16 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/ --- (Updated June 16, 2015, 11:07 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-16 Thread Brian Brazil
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32973/ --- (Updated June 16, 2015, 9:12 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 35498: Compute SLA stats for non-prod jobs

2015-06-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35498/#review88044 --- Ship it! Master (b09adc6) is green with this patch. ./build-suppo

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

2015-06-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32973/#review88053 --- Ship it! Master (b09adc6) is green with this patch. ./build-suppo

Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35527/ --- Review request for Aurora, Joshua Cohen and Brian Wickman. Bugs: AURORA-1351

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35527/#review88127 --- Ship it! Master (b09adc6) is green with this patch. ./build-suppo

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35527/#review88130 --- src/test/python/apache/aurora/tools/test_thermos_observer_entry_poi

Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35535/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs: AURORA-135

Re: Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35535/ --- (Updated June 16, 2015, 2:54 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35535/#review88136 --- Ship it! src/main/java/org/apache/aurora/auth/UnsecureAuthModule.j

Re: Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Maxim Khutornenko
> On June 16, 2015, 9:54 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java, line 34 > > > > > > Should this move to UnsecureSessionContext? +1 - Maxim --

Re: Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35535/#review88139 --- Ship it! Ship It! - Maxim Khutornenko On June 16, 2015, 9:54 p.m

Re: Review Request 35535: Use Shiro identity if available in audit logs.

2015-06-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35535/ --- (Updated June 16, 2015, 3:06 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35527/ --- (Updated June 16, 2015, 10:18 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Maxim Khutornenko
> On June 16, 2015, 9:33 p.m., Joshua Cohen wrote: > > src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py, > > lines 27-30 > > > > > > There's a way to set this up so that only these expected prop

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35527/#review88144 --- Ship it! src/test/python/apache/thermos/observer/test_task_observe

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Maxim Khutornenko
> On June 16, 2015, 10:25 p.m., Brian Wickman wrote: > > src/test/python/apache/thermos/observer/test_task_observer.py, lines 37-38 > > > > > > while ugly, should probably change pass to time.sleep(0.01) so that > > Ma

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35527/#review88153 --- Ship it! Master (ea2c9ad) is green with this patch. ./build-suppo

Re: Review Request 35527: Making observer polling interval configurable.

2015-06-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35527/#review88154 --- Ship it! Ship It! - Joshua Cohen On June 16, 2015, 10:18 p.m., M

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

2015-06-16 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34300/#review88188 --- Ship it! Ship It! - Joe Smith On June 1, 2015, 11:05 a.m., Brian