Re: Review Request 35587: Suppress task reconciliation status update logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/#review88388 --- src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.

Re: Review Request 35587: Suppress task reconciliation status update logging.

> On June 18, 2015, 4:42 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java, > > line 314 > > > > > > What's being tested here? If i'm reading correctly, this tes

Re: Review Request 35587: Suppress task reconciliation status update logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/ --- (Updated June 18, 2015, 5:04 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35587: Suppress task reconciliation status update logging.

> On June 18, 2015, 4:42 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java, > > line 314 > > > > > > What's being tested here? If i'm reading correctly, this tes

Re: Review Request 35587: Suppress task reconciliation status update logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/#review88415 --- Ship it! Master (af7e1a7) is green with this patch. ./build-suppo

Review Request 35621: Fixing option type in observer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35621/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-1356 https://issu

Re: Review Request 35621: Fixing option type in observer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35621/#review88435 --- Ship it! :facepalm: - Brian Wickman On June 18, 2015, 8:52 p.m.,

Review Request 35627: Explicitly bind SessionContext.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1352 https://issues

Re: Review Request 35627: Explicitly bind SessionContext.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/ --- (Updated June 18, 2015, 2:35 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35627: Explicitly bind SessionContext.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/ --- (Updated June 18, 2015, 2:40 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35627: Explicitly bind SessionContext.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/#review88440 --- Ship it! src/main/java/org/apache/aurora/auth/UnsecureAuthModule.j

Re: Review Request 35627: Explicitly bind SessionContext.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/ --- (Updated June 18, 2015, 2:55 p.m.) Review request for Aurora and Bill Farner.

Review Request 35613: Fixing broken gradle dependency scanner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 35621: Fixing option type in observer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35621/#review88448 --- This patch does not apply cleanly on master (e271634), do you need t

Re: Review Request 35613: Fixing broken gradle dependency scanner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88447 --- Master (e271634) is red with this patch. ./build-support/jenkins/b

Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35630/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1298 https://

Re: Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35630/#review88452 --- Ship it! src/main/resources/org/apache/aurora/scheduler/storage/db

Re: Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

> On June 18, 2015, 11:08 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml, > > line 167 > > > > > > Is DISTINCT necessary given the Set result type? Functio

Review Request 35633: Fixing stylecheck errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35633/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 35633: Fixing stylecheck errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35633/#review88456 --- Ship it! Ship It! - Bill Farner On June 18, 2015, 11:15 p.m., Ma

Re: Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

> On June 18, 2015, 11:08 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml, > > line 167 > > > > > > Is DISTINCT necessary given the Set result type? > > Bil

Re: Review Request 35613: Fixing broken gradle dependency scanner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88458 --- @ReviewBot retry - Maxim Khutornenko On June 18, 2015, 10:12 p.m.

Re: Review Request 35613: Fixing broken gradle dependency scanner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88460 --- Ship it! LGTM once the bot is happy. - Bill Farner On June 18, 2

Re: Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

> On June 18, 2015, 11:08 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml, > > line 167 > > > > > > Is DISTINCT necessary given the Set result type? > > Bil

Re: Review Request 35613: Fixing broken gradle dependency scanner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88464 --- Ship it! Ship It! - Kevin Sweeney On June 18, 2015, 3:12 p.m., M

Re: Review Request 35633: Fixing stylecheck errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35633/#review88465 --- Ship it! Ship It! - Kevin Sweeney On June 18, 2015, 4:15 p.m., M

Review Request 35639: Filtering explicit reconciliation tasks by SLAVE_ASSIGNED_STATES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35639/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1361 https://issues

Re: Review Request 35639: Filtering explicit reconciliation tasks by SLAVE_ASSIGNED_STATES.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35639/#review88477 --- Ship it! Ship It! - Bill Farner On June 19, 2015, 1:21 a.m., Max