Re: Review Request 38390: Adding oversubscription summary.

2015-09-21 Thread Maxim Khutornenko
> On Sept. 21, 2015, 9:48 p.m., Zameer Manji wrote: > > docs/configuration-reference.md, line 355 > > > > > > What happens if a job with a tier of revocable is sent to a scheduler > > where it isn't configured? I

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-21 Thread Renan DelValle
> On Sept. 2, 2015, 4:45 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java, > > line 87 > > > > > > This code will be easier to maintain long-term with

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/#review99873 --- This patch does not apply cleanly on master (5627611), do you need

Re: Review Request 38390: Adding oversubscription summary.

2015-09-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38390/ --- (Updated Sept. 21, 2015, 10:36 p.m.) Review request for Aurora, Bill Farner

Re: Review Request 37818: Moved executor settings configuration to loadable JSON

2015-09-21 Thread Renan DelValle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37818/ --- (Updated Sept. 21, 2015, 11:42 p.m.) Review request for Aurora and Bill

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99837 --- Ship it! LGTM modulo my nit below. docs/resource-isolation.md

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-21 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/#review99842 --- Ship it! Master (1ff336e) is green with this patch.

Re: Review Request 38390: Adding oversubscription summary.

2015-09-21 Thread Maxim Khutornenko
> On Sept. 15, 2015, 1:20 a.m., Bill Farner wrote: > > docs/configuration-reference.md, lines 344-355 > > > > > > Tiers seems like a significant enough topic to warrant its own page > > with some more context and

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-21 Thread Maxim Khutornenko
> On Sept. 16, 2015, 12:51 a.m., Bill Farner wrote: > > docs/resource-isolation.md, line 150 > > > > > > This doc is otherewise about machine-level resource isolation, so it > > seems like an odd match here. It

Re: Review Request 38385: Documenting dedicated job & quota relationship.

2015-09-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38385/ --- (Updated Sept. 21, 2015, 9:20 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 38390: Adding oversubscription summary.

2015-09-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38390/#review99835 --- Ship it! LGTM modulo my one nit. docs/configuration-reference.md