---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44530/#review122605
---
Ship it!
Can you also add a `RELEASE.md` in the root with the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/
---
(Updated March 9, 2016, 5:34 a.m.)
Review request for Aurora, John Sirois,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/#review122688
---
Ship it!
Master (bab21ed) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/#review122671
---
Master (bab21ed) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/
---
(Updated March 9, 2016, 4:24 a.m.)
Review request for Aurora, John Sirois,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/
---
(Updated March 9, 2016, 5:11 a.m.)
Review request for Aurora, John Sirois,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/#review122683
---
@ReviewBot retry
- Dmitriy Shirchenko
On March 9, 2016, 5:34
> On March 8, 2016, 3:13 p.m., John Sirois wrote:
> > David - I'm an rpm creating noob so please bear with some basic questions
> > that follow:
> >
> > Currently we use
> > [build-artifact.sh](https://github.com/apache/aurora-packaging/blob/master/build-artifact.sh)
> > which uses this
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44519/#review122603
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 8, 2016,
> On March 8, 2016, 10:13 p.m., John Sirois wrote:
> > David - I'm an rpm creating noob so please bear with some basic questions
> > that follow:
> >
> > Currently we use
> > [build-artifact.sh](https://github.com/apache/aurora-packaging/blob/master/build-artifact.sh)
> > which uses this
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43936/#review122607
---
Ship it!
LGTM - The Source0 and setup do check out with out
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44530/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-1568
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44532/
---
Review request for Aurora.
Repository: aurora
Description
---
Allow
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/#review122537
---
Fix it, then Ship it!
LGTM - thanks for the doc additions.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44471/#review122541
---
Ship it!
I have one objection to the future of this patch
> On March 8, 2016, 4:49 p.m., Zameer Manji wrote:
> > I have one objection to the future of this patch which is dropping the
> > other fields in the snapshot after we move all in memory storage to H2.
> >
> > I think keeping those fields for a while will be useful because they allow
> >
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44519/
---
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
> On March 8, 2016, 1:39 a.m., Joshua Cohen wrote:
> > Is this worthy of a NEWS entry? It seems like a pretty major change that
> > operators should be aware of?
>
> Bill Farner wrote:
> +1
Sure, added.
- Maxim
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44471/
---
(Updated March 8, 2016, 5:43 p.m.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44517/#review122553
---
Master (a91a759) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44519/#review122551
---
Master (a91a759) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44517/
---
Review request for Aurora and Joshua Cohen.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44517/#review122556
---
Killed the lock here:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44519/#review122557
---
Killed the lock here:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/
---
(Updated March 8, 2016, 6:32 p.m.)
Review request for Aurora, John Sirois,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44519/#review122568
---
Ship it!
Master (26efe55) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44517/#review122575
---
Ship it!
Master (26efe55) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44519/#review122597
---
Ship it!
Ship It!
- Stephan Erb
On March 8, 2016, 6:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/#review122581
---
Master (26efe55) is red with this patch.
> On March 8, 2016, 11:25 a.m., Zameer Manji wrote:
> > The code for this approach looks fine to me, but I'm not sure if this
> > approach is the way to go.
> >
> > Why can't the command for the health checker include
> > '{{thermos.ports[http]}}' and we can resolve that value before
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44527/#review122599
---
Ship it!
Ship It!
- Bill Farner
On March 8, 2016, 1:25
https://docs.python.org/2/library/subprocess.html#frequently-used-arguments
Ok, sorry, so what exactly are you proposing I do instead of simply passing
in environment variables?
What themos code? What do we replace subprocess with?
I'm new to this code base so I'm still figuring things out so
> On March 8, 2016, 11:25 a.m., Zameer Manji wrote:
> > The code for this approach looks fine to me, but I'm not sure if this
> > approach is the way to go.
> >
> > Why can't the command for the health checker include
> > '{{thermos.ports[http]}}' and we can resolve that value before
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44486/#review122583
---
The code for this approach looks fine to me, but I'm not sure if
> On March 8, 2016, 7:25 p.m., Zameer Manji wrote:
> > The code for this approach looks fine to me, but I'm not sure if this
> > approach is the way to go.
> >
> > Why can't the command for the health checker include
> > '{{thermos.ports[http]}}' and we can resolve that value before launching
> On March 8, 2016, 7:25 p.m., Zameer Manji wrote:
> > The code for this approach looks fine to me, but I'm not sure if this
> > approach is the way to go.
> >
> > Why can't the command for the health checker include
> > '{{thermos.ports[http]}}' and we can resolve that value before launching
> On March 8, 2016, 11:25 a.m., Zameer Manji wrote:
> > The code for this approach looks fine to me, but I'm not sure if this
> > approach is the way to go.
> >
> > Why can't the command for the health checker include
> > '{{thermos.ports[http]}}' and we can resolve that value before
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44526/#review122595
---
Ship it!
Master (26efe55) is green with this patch.
> On March 8, 2016, 7:25 p.m., Zameer Manji wrote:
> > The code for this approach looks fine to me, but I'm not sure if this
> > approach is the way to go.
> >
> > Why can't the command for the health checker include
> > '{{thermos.ports[http]}}' and we can resolve that value before launching
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44526/
---
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Currently the health checker is just launched by the executor blindly. This
proposal now plumbs information about the task to the subprocess. We
already have a mechanism to do this, it's the DSL provided to users when
they compose their processes. In that case we compose a command line with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44527/
---
Review request for Aurora, Jake Farrell and Bill Farner.
Bugs: AURORA-1568
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43936/#review122606
---
David - I'm an rpm creating noob so please bear with some basic
43 matches
Mail list logo
