Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126573 --- Fix it, then Ship it! Looks good. Minor nitpicks below. RELEA

Re: Review Request 45177: Setting DiscoveryInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45177/#review126574 --- Please add an explanation of the feature to https://github.com/ap

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

> On April 1, 2016, 11:31 a.m., Stephan Erb wrote: > > Looks good. Minor nitpicks below. Addressed all your comments. Thanks Stephan! Biil, Stephan, Joshua: Any more comments to address or will one of you commit? - Ashwin --- This is

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/ --- (Updated April 1, 2016, 2:21 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126585 --- Ship it! Master (17ade11) is green with this patch. ./build-s

Re: Review Request 45177: Setting DiscoveryInfo.

> On March 31, 2016, 8:25 p.m., Joshua Cohen wrote: > > RELEASE-NOTES.md, line 14 > > > > > > Is there any reason we need a command line arg to control this? Is > > there any detriment to just always populating `Disc

Re: Review Request 45177: Setting DiscoveryInfo.

> On April 1, 2016, 12:05 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 242 > > > > > > Should we consider using the inverse notation here? This would b

Re: Review Request 45372: Skip flaky test test_health_checker_metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45372/#review126620 --- Ship it! Once you add `import pytest` at the top this should wo

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126623 --- Biggest issue - the servlet isn't actually wired in and therefore

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

> On April 1, 2016, 7:48 p.m., Bill Farner wrote: > > Biggest issue - the servlet isn't actually wired in and therefore the > > scheduler does not respond to `/leaderhealth`. I suggest we add a check in > > the end-to-end tests to verify this behavior and make sure wiring is > > correct. > >

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

> On April 1, 2016, 7:48 p.m., Bill Farner wrote: > > Biggest issue - the servlet isn't actually wired in and therefore the > > scheduler does not respond to `/leaderhealth`. I suggest we add a check in > > the end-to-end tests to verify this behavior and make sure wiring is > > correct. > >

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/ --- (Updated April 2, 2016, 5:24 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

> On April 1, 2016, 7:48 p.m., Bill Farner wrote: > > Biggest issue - the servlet isn't actually wired in and therefore the > > scheduler does not respond to `/leaderhealth`. I suggest we add a check in > > the end-to-end tests to verify this behavior and make sure wiring is > > correct. > >

Re: Review Request 45511: AURORA-1493: create ELB-friendly endpoint to detect leading scheduler

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45511/#review126680 --- Ship it! Master (17ade11) is green with this patch. ./build-s