Re: Review Request 50685: Support TBinaryProtocol over HTTP

2016-08-04 Thread Kunal Thakar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50685/#review144797 --- RELEASE-NOTES.md (line 20)

Review Request 50819: Use update_job instead of creating new config object when modifying.

2016-08-04 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/ --- Review request for Aurora and Mehrdad Nurolahzade. Repository: aurora Descrip

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

2016-08-04 Thread Mehrdad Nurolahzade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144823 --- Ship it! Ship It! - Mehrdad Nurolahzade On Aug. 4, 2016, 2:1

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

2016-08-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144824 --- Master (d0533d2) is red with this patch. ./build-support/jenkins

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

2016-08-04 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144825 --- @ReviewBot retry - David McLaughlin On Aug. 4, 2016, 9:10 p.m.,

Re: Review Request 50819: Use update_job instead of creating new config object when modifying.

2016-08-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50819/#review144830 --- Master (ec3591c) is red with this patch. ./build-support/jenkins

Review Request 50826: Populate the source field of ExecutorInfo.

2016-08-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50826/ --- Review request for Aurora, Joshua Cohen and Dmitriy Shirchenko. Bugs: AURORA-17

Re: Review Request 50826: Populate the source field of ExecutorInfo.

2016-08-04 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50826/#review144853 --- Ship it! plz add a test and then LGTM - Dmitriy Shirchenko O

Re: Review Request 50826: Populate the source field of ExecutorInfo.

2016-08-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50826/#review144854 --- Master (ec3591c) is red with this patch. ./build-support/jenkins

Re: Review Request 50826: Populate the source field of ExecutorInfo.

2016-08-04 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50826/#review144855 --- This does not compile. We have -Werror set on our builds which mea

Re: Review Request 50826: Populate the source field of ExecutorInfo.

2016-08-04 Thread Joshua Cohen
> On Aug. 5, 2016, 12:50 a.m., Joshua Cohen wrote: > > This does not compile. We have -Werror set on our builds which means the > > warning about the field being deprecated causes a build failure. If we do want to maintain this across a release boundary for compatibility sake we'll need to add

Re: Review Request 50826: Populate the source field of ExecutorInfo.

2016-08-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50826/ --- (Updated Aug. 4, 2016, 6:05 p.m.) Review request for Aurora, Joshua Cohen and D

Re: Review Request 50826: Populate the source field of ExecutorInfo.

2016-08-04 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50826/#review144859 --- Ship it! Master (ec3591c) is green with this patch. ./build-s