Re: Review Request 63078: Hide pagination links on Role and Job lists when only one page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63078/#review188335 --- Ship it! Master (5b72398) is green with this patch.

Review Request 63078: Hide pagination links on Role and Job lists when only one page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63078/ --- Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar

Review Request 63079: Center pagination links when not a table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63079/ --- Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar

Review Request 63082: Hide InstanceHistory when there are no old tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63082/ --- Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar

Re: Review Request 63079: Center pagination links when not a table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63079/#review188338 --- Ship it! Ship It! - Reza Motamedi On Oct. 17, 2017, 5:14

Re: Review Request 63065: Fix link on Navigation logo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63065/#review188339 --- Ship it! Ship It! - Kai Huang On Oct. 17, 2017, 4:10 a.m.,

Re: Review Request 63081: Format constraints on Task Config Summary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63081/#review188337 --- Ship it! Ship It! - Reza Motamedi On Oct. 17, 2017, 5:21

Re: Review Request 63078: Hide pagination links on Role and Job lists when only one page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63078/#review188336 --- Ship it! Ship It! - Reza Motamedi On Oct. 17, 2017, 5:06

Re: Review Request 63082: Hide InstanceHistory when there are no old tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63082/ --- (Updated Oct. 17, 2017, 5:30 p.m.) Review request for Aurora, Kai Huang, Reza

Review Request 63081: Format constraints on Task Config Summary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63081/ --- Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar

Re: Review Request 63062: Expose list of neighbors in the instance page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188341 --- Fix it, then Ship it! LGTM

Re: Review Request 63081: Format constraints on Task Config Summary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63081/#review188346 --- Ship it! Ship It! - Kai Huang On Oct. 17, 2017, 5:21 p.m.,

Re: Review Request 62869: Exclusively use Map-based in-memory stores for primary storage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62869/#review188327 --- Mostly looks good to me. Some questions about concurrency when

Re: Review Request 63081: Format constraints on Task Config Summary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63081/#review188344 --- Ship it! Master (5b72398) is green with this patch.

Re: Review Request 63079: Center pagination links when not a table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63079/#review188349 --- Ship it! Master (5b72398) is green with this patch.

Re: Review Request 62956: Immediately reject offers lacking necessary resources

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62956/#review188356 ---

Re: Review Request 63082: Hide InstanceHistory when there are no old tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63082/#review188348 --- Ship it! Ship It! - Kai Huang On Oct. 17, 2017, 5:30 p.m.,

Re: Review Request 63082: Hide InstanceHistory when there are no old tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63082/#review188353 --- Ship it! Master (b1648aa) is green with this patch.

Re: Review Request 63079: Center pagination links when not a table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63079/#review188347 --- Ship it! Ship It! - Kai Huang On Oct. 17, 2017, 5:14 p.m.,

Re: Review Request 63062: Expose list of neighbors in the instance page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188376 --- Ship it! LGTM with comments addressed. File Attachment:

Review Request 63087: Fix instance range display

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63087/ --- Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar

Re: Review Request 63083: Add diff viewer to Update Page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63083/#review188380 --- Ship it! Master (94999eb) is green with this patch.

Re: Review Request 63081: Format constraints on Task Config Summary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63081/#review188373 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 17,

Re: Review Request 63062: Expose list of neighbors in the instance page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63062/#review188371 --- Ship it! LGTM. Improvement suggested. File Attachment:

Re: Review Request 62956: Immediately reject offers lacking necessary resources

> On Oct. 17, 2017, 6:26 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 67-68 (patched) > > > > > > Since the Scheduler fails over every 24

Re: Review Request 63064: Clean up State Machine CSS to handle long messages

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63064/#review188369 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 16,

Re: Review Request 63079: Center pagination links when not a table.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63079/#review188374 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 17,

Review Request 63083: Add diff viewer to Update Page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63083/ --- Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar

Re: Review Request 62958: Add URL handling for tab switching on Job page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/#review188377 --- Due to the lack of strong opinions - I'm going to ship this

Re: Review Request 63087: Fix instance range display

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63087/ --- (Updated Oct. 17, 2017, 9:43 p.m.) Review request for Aurora, Kai Huang, Reza

Re: Review Request 63083: Add diff viewer to Update Page

> On Oct. 17, 2017, 9:03 p.m., Stephan Erb wrote: > > Should we consider pretty printing the executor configuration (when > > assembling the thrift struct in the client)? Hopefully this would yield > > diffs that are a bit easier to read. > > David McLaughlin wrote: > Currently that would

Re: Review Request 63083: Add diff viewer to Update Page

> On Oct. 17, 2017, 11:03 p.m., Stephan Erb wrote: > > Should we consider pretty printing the executor configuration (when > > assembling the thrift struct in the client)? Hopefully this would yield > > diffs that are a bit easier to read. > > David McLaughlin wrote: > Currently that

Review Request 63091: Dummy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63091/ --- Review request for Aurora. Repository: aurora Description --- Dummy

Re: Review Request 62956: Immediately reject offers lacking necessary resources

> On Oct. 17, 2017, 6:26 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 67-68 (patched) > > > > > > Since the Scheduler fails over every 24

Re: Review Request 63082: Hide InstanceHistory when there are no old tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63082/#review188375 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 17,

Re: Review Request 63088: Add pointer for pagination links

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63088/#review188397 --- Ship it! Master (e161c97) is green with this patch.

Re: Review Request 63083: Add diff viewer to Update Page

> On Oct. 17, 2017, 11:03 p.m., Stephan Erb wrote: > > Should we consider pretty printing the executor configuration (when > > assembling the thrift struct in the client)? Hopefully this would yield > > diffs that are a bit easier to read. > > David McLaughlin wrote: > Currently that

Re: Review Request 63087: Fix instance range display

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63087/#review188400 --- Master (e161c97) is red with this patch.

Re: Review Request 63092: Detect and parse Thermos config in Diff output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/ --- (Updated Oct. 17, 2017, 11:19 p.m.) Review request for Aurora, Kai Huang,

Re: Review Request 63083: Add diff viewer to Update Page

> On Oct. 17, 2017, 11:03 p.m., Stephan Erb wrote: > > Should we consider pretty printing the executor configuration (when > > assembling the thrift struct in the client)? Hopefully this would yield > > diffs that are a bit easier to read. > > David McLaughlin wrote: > Currently that

Re: Review Request 63083: Add diff viewer to Update Page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63083/ --- (Updated Oct. 17, 2017, 9:57 p.m.) Review request for Aurora, Kai Huang, Reza

Review Request 63092: Detect and parse Thermos config in Diff output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/ --- Review request for Aurora and Stephan Erb. Repository: aurora Description

Re: Review Request 63092: Detect and parse Thermos config in Diff output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/#review188411 --- Ship it! Master (0efe415) is green with this patch.

Review Request 63088: Add pointer for pagination links

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63088/ --- Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar

Re: Review Request 63088: Add pointer for pagination links

> On Oct. 17, 2017, 1:42 p.m., Santhosh Kumar Shanmugham wrote: > > Ship It! Link an image? - Santhosh Kumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63088/#review188381

Re: Review Request 63088: Add pointer for pagination links

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63088/#review188381 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 17,

Re: Review Request 63088: Add pointer for pagination links

> On Oct. 17, 2017, 8:42 p.m., Santhosh Kumar Shanmugham wrote: > > Ship It! > > Santhosh Kumar Shanmugham wrote: > Link an image? I would but you can't easily take a picture of your cursor on a Mac. - David --- This is an

Re: Review Request 62956: Immediately reject offers lacking necessary resources

> On Oct. 17, 2017, 8:26 p.m., Santhosh Kumar Shanmugham wrote: > > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > > Lines 67-68 (patched) > > > > > > Since the Scheduler fails over every 24

Re: Review Request 63083: Add diff viewer to Update Page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63083/#review188387 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 17,

Re: Review Request 63087: Fix instance range display

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63087/#review188384 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On Oct. 17,

Re: Review Request 63083: Add diff viewer to Update Page

> On Oct. 17, 2017, 9:03 p.m., Stephan Erb wrote: > > Should we consider pretty printing the executor configuration (when > > assembling the thrift struct in the client)? Hopefully this would yield > > diffs that are a bit easier to read. > > David McLaughlin wrote: > Currently that would

Re: Review Request 63083: Add diff viewer to Update Page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63083/#review188390 --- Should we consider pretty printing the executor configuration

Re: Review Request 63083: Add diff viewer to Update Page

> On Oct. 17, 2017, 9:03 p.m., Stephan Erb wrote: > > Should we consider pretty printing the executor configuration (when > > assembling the thrift struct in the client)? Hopefully this would yield > > diffs that are a bit easier to read. Currently that would have to assume the executor

Re: Review Request 63092: Detect and parse Thermos config in Diff output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/ --- (Updated Oct. 18, 2017, 12:08 a.m.) Review request for Aurora, Kai Huang,

Re: Review Request 63092: Detect and parse Thermos config in Diff output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/ --- (Updated Oct. 18, 2017, 12:16 a.m.) Review request for Aurora, Kai Huang,

Re: Review Request 63092: Detect and parse Thermos config in Diff output

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63092/#review188427 --- Ship it! Master (0efe415) is green with this patch.

Review Request 63098: Clean up Job Page CSS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63098/ --- Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.

Re: Review Request 63098: Clean up Job Page CSS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63098/#review188446 --- Ship it! Master (0efe415) is green with this patch.

Re: Review Request 63099: Add Source Sans Pro font to project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63099/#review188453 --- This patch does not apply cleanly against master (0efe415), do

Review Request 63099: Add Source Sans Pro font to project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63099/ --- Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.

Re: Review Request 63098: Clean up Job Page CSS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63098/ --- (Updated Oct. 18, 2017, 3:29 a.m.) Review request for Aurora, Kai Huang and