Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/ --- Review request for Aurora, Jordan Ly and Renan DelValle. Repository: aurora

Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- Review request for Aurora, David McLaughlin, Daniel Knightly, Jordan Ly,

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199521 --- This patch does not apply cleanly against master (b3fa9fe), do

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/ --- (Updated March 20, 2018, 5:37 a.m.) Review request for Aurora, David

Re: Review Request 66103: Introduce mesos disk collector

> On March 19, 2018, 9 p.m., Santhosh Kumar Shanmugham wrote: > > 3rdparty/python/requirements.txt > > Lines 23 (patched) > > > > > > Any reason not using the more widely used `jq`? There are two python libraries

Re: Review Request 66103: Introduce mesos disk collector

> On March 19, 2018, 11:30 p.m., Kai Huang wrote: > > src/main/python/apache/thermos/monitoring/disk.py > > Lines 96 (patched) > > > > > > Just curious: is there any reason we set this value to -1GB? It is just a

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199418 --- Master (aaadad7) is red with this patch.

Re: Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199446 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 19,

Re: Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199438 --- Master (aaadad7) is red with this patch.

Review Request 66139: Speedup regular Thermos observer checkpoint refresh

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/ --- Review request for Aurora, Jordan Ly and Renan DelValle. Repository: aurora

Re: Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199420 --- Master (aaadad7) is red with this patch.

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199442 --- Master (aaadad7) is red with this patch.

Re: Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199447 --- Ship it! Ship It! - Jordan Ly On March 19, 2018, 2:55 p.m.,

Re: Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199421 --- @ReviewBot retry - Stephan Erb On March 19, 2018, 3:55 p.m.,

Re: Review Request 65896: Persist scheduler/observer logs to /var/log/aurora/[FILE].log

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65896/#review199434 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On March 14,

Re: Review Request 66136: Switch Thermos to lazy log formatting

> On March 19, 2018, 5:21 p.m., Aurora ReviewBot wrote: > > Master (aaadad7) is red with this patch. > > ./build-support/jenkins/build.sh > > > > Pass 2: Analyzing classes (319 / 332) - 96% complete > > Pass 2: Analyzing classes (320 / 332) - 96% complete > > Pass 2: Analyzing classes (321 /

Re: Review Request 66103: Introduce mesos disk collector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66103/#review199448 --- Approach looks good. Few comments on improving the interface and

Review Request 66152: Custom executor support for Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66152/ --- Review request for Aurora. Repository: aurora Description --- Adding

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199490 --- @ReviewBot retry - Stephan Erb On March 19, 2018, 5:24 p.m.,

Re: Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199491 --- Ship it! Ship It! - Reza Motamedi On March 19, 2018, 2:55

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199504 --- Not sure how possible it is given the requirement for a

Re: Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/#review199503 --- Ship it! Ship It! - David McLaughlin On March 19, 2018,

Re: Review Request 66136: Switch Thermos to lazy log formatting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66136/#review199488 --- Master (e0e90e1) is green with this patch.

Review Request 66154: Adding support for using custom executors via the Aurora DSL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66154/ --- Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Stephan

Re: Review Request 66139: Speedup regular Thermos observer checkpoint refresh

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66139/#review199501 --- Ship it! Master (b3fa9fe) is green with this patch.