Re: Review Request 67584: Update to Mesos 1.5

2018-06-15 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67584/#review204855 --- Ship it! Vagrantfile Line 20 (original), 20 (patched)

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Jordan Ly
> On June 15, 2018, 6:03 p.m., Jordan Ly wrote: > > Oops missed one thing: > > > > You need to add a scheduler active binding in the module: > > ``` > > SchedulerServicesModule.addSchedulerActiveServiceBinding(binder()) > > .to([SOMETHING].class); > > ``` And for a quick test, can

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/#review204857 --- Ship it! Ship It! - David McLaughlin On June 15, 2018, 5:58

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/ --- (Updated June 15, 2018, 11:02 a.m.) Review request for Aurora, David

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/#review204856 --- Ship it! Ship It! - Jordan Ly On June 15, 2018, 5:58 p.m.,

Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/ --- Review request for Aurora, David McLaughlin and Jordan Ly. Repository: aurora

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
> On June 15, 2018, 11:03 a.m., Jordan Ly wrote: > > Oops missed one thing: > > > > You need to add a scheduler active binding in the module: > > ``` > > SchedulerServicesModule.addSchedulerActiveServiceBinding(binder()) > > .to([SOMETHING].class); > > ``` > > Jordan Ly wrote: >

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/#review204858 --- Ship it! Oops missed one thing: You need to add a scheduler

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/#review204879 --- Master (8383ed5) is green with this patch.

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/ --- (Updated June 15, 2018, 1:55 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/#review204872 --- Master (8383ed5) is red with this patch.

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/ --- (Updated June 15, 2018, 1:59 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/ --- (Updated June 15, 2018, 12:58 p.m.) Review request for Aurora, David

Re: Review Request 67584: Update to Mesos 1.5

2018-06-15 Thread Stephan Erb
> On Juni 15, 2018, 8 nachm., David McLaughlin wrote: > > Vagrantfile > > Line 20 (original), 20 (patched) > > > > > > Why this downgrade? That is just the minimal version and it works fine with 2.0.2 as well. For

Re: Review Request 67613: Close AsyncHttpClient on scheduler shutdown.

2018-06-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67613/#review204864 --- Master (8383ed5) is green with this patch.