Re: Review Request 31101: Native Debian packaging for Aurora

2015-03-30 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/#review72785 --- On Feb. 16, 2015, 4:20 p.m., Benjamin Staffin wrote

Re: Review Request 31101: Native Debian packaging for Aurora

2015-03-30 Thread Benjamin Staffin
. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/#review73174 --- On Feb. 16, 2015, 4:20 p.m., Benjamin Staffin wrote

Re: Review Request 31101: Native Debian packaging for Aurora

2015-05-22 Thread Benjamin Staffin
--- On May 21, 2015, 10:27 a.m., Benjamin Staffin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/ --- (Updated

Re: Review Request 31101: Native Debian packaging for Aurora

2015-05-22 Thread Benjamin Staffin
this branch on a testing cluster for a few months now. Thanks, Benjamin Staffin

Re: Review Request 36511: Removes version on virtual pacakge in debian control

2015-07-15 Thread Benjamin Staffin
having versions on virtual package dependencies. - Benjamin Staffin On July 15, 2015, 10:50 a.m., Andrew Jorgensen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36511

Re: Review Request 34568: run tasks as user that match aurora-role

2016-01-09 Thread Benjamin Staffin
users, since right now there's no requirement for matching role accounts to exist inside the docker images, but with the right documentation about how to retain the "always root in the container" behavior it ought to be ok. - Benjamin Staffin On Nov. 2, 2015, 10:26 a.m., Bhuvan Arum

Re: Review Request 48606: Improve consistency of the RPM and DEB default configuration

2016-06-12 Thread Benjamin Staffin
tps://reviews.apache.org/r/48606/#comment202381> should this really default to listening only on localhost? - Benjamin Staffin On June 12, 2016, 3:08 p.m., Stephan Erb wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48606: Improve consistency of the RPM and DEB default configuration

2016-06-12 Thread Benjamin Staffin
ically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48606/ > --- > > (Updated June 12, 2016, 3:08 p.m.) > > > Review request for Aurora, Benjamin Staffin, Jake Farrell, and Kasisnu Singh. > > > Bugs: AURORA-1394 > https://issues.apache.org/

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-04 Thread Benjamin Staffin
ank you. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review117814 --- On Feb. 1, 2016, 6:49 p.m., B

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-05 Thread Benjamin Staffin
, Benjamin Staffin

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
0315a1eebe src/main/python/apache/aurora/config/loader.py a967b9dca353f5a70c89abee5d45220a9593c01a src/test/python/apache/aurora/config/test_loader.py 9789255cb0280ef0d1a83cd8c1cf8fa3581553b5 Diff: https://reviews.apache.org/r/42953/diff/ Testing --- Thanks, Benjamin Staffin

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-01 Thread Benjamin Staffin
up the stack and > > allow cluster administrators to provide an executor config per > > containerizer? > > Benjamin Staffin wrote: > The last two are doing the same thing, except that the existing behaviour > has the docker runner ignoring all setuid options and alw

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-01 Thread Benjamin Staffin
4780232318ffdf8c6bbbe78bee518886cffd580a src/main/python/apache/aurora/executor/thermos_task_runner.py 3896e3841562600379705dbf78a6f62728246348 Diff: https://reviews.apache.org/r/43027/diff/ Testing --- TBD Thanks, Benjamin Staffin

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
t; > 23:51:01 09:23 [complete] > >FAILURE > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" I can't reproduce this failure. I suspect it's not related to my change. -

Review Request 43005: Add Fitbit to the Aurora adopters list

2016-01-29 Thread Benjamin Staffin
Fitbit to the Aurora adopters list Diffs - README.md da0084199125d6d4a88586502727783ac13bda36 Diff: https://reviews.apache.org/r/43005/diff/ Testing --- Thanks, Benjamin Staffin

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
_loader.py 9789255cb0280ef0d1a83cd8c1cf8fa3581553b5 Diff: https://reviews.apache.org/r/42953/diff/ Testing --- Thanks, Benjamin Staffin

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
0315a1eebe src/main/python/apache/aurora/config/loader.py a967b9dca353f5a70c89abee5d45220a9593c01a src/test/python/apache/aurora/config/test_loader.py 9789255cb0280ef0d1a83cd8c1cf8fa3581553b5 Diff: https://reviews.apache.org/r/42953/diff/ Testing --- Thanks, Benjamin Staffin

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-01-31 Thread Benjamin Staffin
that interface look like? - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review117162 --- On Jan. 30, 2

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-29 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42953/#review117066 --- @ReviewBot retry - Benjamin Staffin On Jan. 29, 2016, 3:31 p.m

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-30 Thread Benjamin Staffin
est/python/apache/aurora/config/test_loader.py 9789255cb0280ef0d1a83cd8c1cf8fa3581553b5 Diff: https://reviews.apache.org/r/42953/diff/ Testing --- Thanks, Benjamin Staffin

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-30 Thread Benjamin Staffin
-mail. To reply, visit: https://reviews.apache.org/r/42953/#review117087 --- On Jan. 30, 2016, 3:08 p.m., Benjamin Staffin wrote: > > --- > This is an automatically generated

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-01-30 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43027/#review117137 --- Tests for this are not written yet. - Benjamin Staffin On Jan

Re: Review Request 34568: run tasks as user that match aurora-role

2016-01-30 Thread Benjamin Staffin
> On Jan. 9, 2016, 4:43 p.m., Benjamin Staffin wrote: > > Any chance of getting this merged? It might be a surprise to some users, > > since right now there's no requirement for matching role accounts to exist > > inside the docker images, but with the right do

Review Request 43027: Optionally enable setuid inside Docker containers

2016-01-30 Thread Benjamin Staffin
, Benjamin Staffin

Review Request 42953: Improve --read-json to handle multi-job files

2016-01-28 Thread Benjamin Staffin
iff: https://reviews.apache.org/r/42953/diff/ Testing --- Thanks, Benjamin Staffin

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-28 Thread Benjamin Staffin
src/main/python/apache/aurora/config/loader.py a967b9dca353f5a70c89abee5d45220a9593c01a Diff: https://reviews.apache.org/r/42953/diff/ Testing --- Thanks, Benjamin Staffin

Re: Review Request 42953: Improve --read-json to handle multi-job files

2016-01-28 Thread Benjamin Staffin
documentation updates. - Benjamin Staffin On Jan. 28, 2016, 9:28 p.m., Benjamin Staffin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 42387: working version of jessie builds

2016-01-21 Thread Benjamin Staffin
mitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42387/ > --- > > (Updated Jan. 21, 2016, 2

Re: Review Request 43554: Update pants wrapper to match upstream

2016-02-12 Thread Benjamin Staffin
://reviews.apache.org/r/43554/diff/ Testing (updated) --- Tested before/after on my Linux and Mac dev systems. Thanks, Benjamin Staffin

Review Request 43554: Update pants wrapper to match upstream

2016-02-12 Thread Benjamin Staffin
--- Thanks, Benjamin Staffin

Re: Review Request 43027: Optionally enable setuid inside Docker containers

2016-02-12 Thread Benjamin Staffin
3896e3841562600379705dbf78a6f62728246348 src/test/python/apache/aurora/executor/bin/test_thermos_executor_entry_point.py e9f7851292aef3a36da5da9b0fc333a7e7750cf3 Diff: https://reviews.apache.org/r/43027/diff/ Testing --- TBD Thanks, Benjamin Staffin

Review Request 45521: Remove client-side validation of environment names

2016-03-30 Thread Benjamin Staffin
, Benjamin Staffin

Re: Review Request 45521: Remove client-side validation of environment names

2016-03-30 Thread Benjamin Staffin
/common/aurora_job_key.py 21cdca6074c6fa58d68a0818805144662044841f Diff: https://reviews.apache.org/r/45521/diff/ Testing --- Thanks, Benjamin Staffin

Re: Review Request 45521: Remove client-side validation of environment names

2016-03-30 Thread Benjamin Staffin
://reviews.apache.org/r/45521/diff/ Testing --- Thanks, Benjamin Staffin

Re: Review Request 45521: Remove client-side validation of environment names

2016-03-31 Thread Benjamin Staffin
209.54 seconds  > > > > FAILURE > > > > > > 06:07:16 04:23 [complete] > > FAILURE > > > > > > I will refresh this build result if you post a review containing > > "@ReviewBot re

Re: Review Request 45521: Remove client-side validation of environment names

2016-05-20 Thread Benjamin Staffin
1/#review134124 --- On March 30, 2016, 10:55 p.m., Benjamin Staffin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

2016-05-18 Thread Benjamin Staffin
> On May 18, 2016, 7:15 a.m., Joshua Cohen wrote: > > docs/getting-started/overview.md, line 56 > > <https://reviews.apache.org/r/47495/diff/2/?file=1386103#file1386103line56> > > > > s/has/had > > Benjamin Staffin wrote: > s/had been k

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

2016-05-18 Thread Benjamin Staffin
> On May 18, 2016, 7:15 a.m., Joshua Cohen wrote: > > docs/getting-started/overview.md, line 56 > > > > > > s/has/had s/had been known/was/ - Benjamin ---

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

2016-05-18 Thread Benjamin Staffin
tps://reviews.apache.org/r/47495/#comment198354> Maybe use `(i.e. the agent machine)` here for clarity? That phrasing is used in at least one other place in the docs. - Benjamin Staffin On May 17, 2016, 3:19 p.m., Stephan Erb

Re: Review Request 47495: Use 'Mesos agent' instead of 'Mesos slave' in docs

2016-05-18 Thread Benjamin Staffin
tps://reviews.apache.org/r/47495/#comment198348> Might it be clearer to phrase this as "any random offer"? Or maybe that would confuse newcomers, I'm not sure. - Benjamin Staffin On May 17, 2016, 3:19 p.m., S

Re: Review Request 46897: Use `gdebi` for auto dep resolution.

2016-05-02 Thread Benjamin Staffin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46897/#review131343 --- Ship it! Ship It! - Benjamin Staffin On May 2, 2016, 11:14

Review Request 49330: Add announce and enable_hooks to Job Schema table

2016-06-28 Thread Benjamin Staffin
announce and enable_hooks to Job Schema table Diffs - docs/reference/configuration.md c56ace0477f3f22c0d56d3dfc4c24b510895aa7e Diff: https://reviews.apache.org/r/49330/diff/ Testing --- Thanks, Benjamin Staffin