Re: Review Request 49512: [FEEDBACK] Add thermos option to monitor whole docker storage disk usage

2016-07-15 Thread George Sirois
> On July 4, 2016, 7:55 a.m., Stephan Erb wrote: > > Have you considered querying Mesos for the disk usage of the task? That > > would be in line with our desire to also leave the isolation up to Mesos > > https://issues.apache.org/jira/browse/AURORA-1033 > > Martin Hrabovcin wrote: > I wa

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-12 Thread George Sirois
ore reliable. src/main/python/apache/aurora/client/docker/docker_client.py (line 137) <https://reviews.apache.org/r/52479/#comment221299> Should we remove the default None value from cluster and name here? Both arguments are always required. - George Sirois On Oct. 11, 2016, 4:06 a.

Re: Review Request 52479: Resolve docker tags to concrete identifiers for DockerContainerizer

2016-10-12 Thread George Sirois
6, 4:06 a.m., Santhosh Kumar Shanmugham wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52479/ > --- > > (Updated Oct. 11, 2016, 4:06 a.m.) > >

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-08-03 Thread George Sirois
gger = Default(Logger, DefaultLogger) > > ``` > > > > This also means reduced end-to-end plumbing through all the binaries, class > > constructors, etc. And if you ever need to add new features (e.g. a > > compress option), they're fairly well encapsul

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-11-24 Thread George Sirois
gger = Default(Logger, DefaultLogger) > > ``` > > > > This also means reduced end-to-end plumbing through all the binaries, class > > constructors, etc. And if you ever need to add new features (e.g. a > > compress option), they're fairly well encapsul

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-11-25 Thread George Sirois
2 Diff: https://reviews.apache.org/r/30695/diff/ Testing --- ./pants test src/test/python/apache/thermos/core:all Thanks, George Sirois

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-10 Thread George Sirois
rated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review109834 --- On Nov. 25, 2015, 5 p.m., George Sirois wrote: > > --- > This is an automatically generated e-

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-11 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review109957 ------- On Nov. 25, 2015, 5 p.m., George Sirois wrote: > > ---

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-17 Thread George Sirois
5e6ad2fca616b840299bd9ca1614c82c5c39e992 Diff: https://reviews.apache.org/r/30695/diff/ Testing --- ./pants test src/test/python/apache/thermos/core:all Thanks, George Sirois

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-17 Thread George Sirois
/thermos_runner.py bd8cf7f4cda54b6be72dad64f9446eedeb132211 src/test/python/apache/thermos/core/test_process.py 5e6ad2fca616b840299bd9ca1614c82c5c39e992 Diff: https://reviews.apache.org/r/30695/diff/ Testing --- ./pants test src/test/python/apache/thermos/core:all Thanks, George Sirois

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-17 Thread George Sirois
/apache/thermos/core:all Thanks, George Sirois

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-17 Thread George Sirois
/apache/thermos/core:all Thanks, George Sirois

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-12-17 Thread George Sirois
/apache/thermos/core:all Thanks, George Sirois

Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-08 Thread George Sirois
/scheduler/configuration/ConfigurationManagerTest.java f3b62cc957186bc9673060830572bc1cc073ac49 Diff: https://reviews.apache.org/r/42077/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, George Sirois

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-08 Thread George Sirois
eviews.apache.org/r/42077/#review113507 ------- On Jan. 8, 2016, 6:28 p.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-11 Thread George Sirois
ar,foo=baz" Job Config: "foo=zap" Final "foo=bar,foo=baz", NOT "foo=bar,foo=baz,foo=zap" ``` - George --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/#revie

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-11 Thread George Sirois
/ Testing --- ./build-support/jenkins/build.sh Thanks, George Sirois

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-12 Thread George Sirois
--- ./build-support/jenkins/build.sh Thanks, George Sirois

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-20 Thread George Sirois
, George Sirois

Re: Review Request 42077: Introduces -default_docker_parameters scheduler flag.

2016-01-20 Thread George Sirois
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42077/#review115223 --- On Jan. 20, 2016, 6:12 p.m., George Sirois wrote: > > ---

Review Request 42567: Fix broken Thrift benchmark.

2016-01-20 Thread George Sirois
/build.sh Thanks, George Sirois

Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread George Sirois
03bfdbab927c924486b04c42df2ad236c0f414a0 src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 949c299bdbc54f976db994266fb97f3099256f13 Diff: https://reviews.apache.org/r/45396/diff/ Testing --- Thanks, George Sirois

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125707 --- @ReviewBot retry - George Sirois On March 28, 2016, 6:21 p.m

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread George Sirois
t; referencing them directly). Sure, will do. - George --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125779 ----------- On March 28, 2016, 6:21 p.m., George Sirois wrote: > > -

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread George Sirois
generated e-mail. To reply, visit: https://reviews.apache.org/r/45396/#review125779 ------- On March 28, 2016, 6:21 p.m., George Sirois wrote: > > --- > This is an automa

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-28 Thread George Sirois
/org/apache/aurora/scheduler/configuration/executor/ExecutorModuleTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45396/diff/ Testing --- Thanks, George Sirois

Re: Review Request 45396: Adds the ability to set HOME to the sandbox before running the executor.

2016-03-29 Thread George Sirois
949c299bdbc54f976db994266fb97f3099256f13 src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModuleTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45396/diff/ Testing --- Thanks, George Sirois

Review Request 45436: Fixes to RELEASE-NOTES for new documentation structure.

2016-03-29 Thread George Sirois
Description --- Fixes to RELEASE-NOTES for new documentation structure. Diffs - RELEASE-NOTES.md 450d363b566c150c6e597b3d188a44c7a77ea891 Diff: https://reviews.apache.org/r/45436/diff/ Testing --- Thanks, George Sirois

Re: Review Request 47440: RFC for WIP: adding webhook code that can POST events to an endpoint

2016-05-16 Thread George Sirois
ied to Kafka as-is. - George Sirois On May 17, 2016, 2:10 a.m., Dmitriy Shirchenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re