Review Request 50168: Add rollback functionality to the scheduler

2016-07-18 Thread Igor Morozov
/JobUpdaterIT.java e157c0dfde5efc418448e138aa008ade742fe816 Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-18 Thread Igor Morozov
/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 8d78bae2cbf365a5359d88c0e996b3972a21e50e src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e157c0dfde5efc418448e138aa008ade742fe816 Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-18 Thread Igor Morozov
afbd385b7eda64cb1f7d118b695e65e4045eac6c Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-19 Thread Igor Morozov
org/apache/aurora/scheduler/updater/JobUpdaterIT.java e157c0dfde5efc418448e138aa008ade742fe816 src/test/python/apache/aurora/client/api/test_scheduler_client.py afbd385b7eda64cb1f7d118b695e65e4045eac6c Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-19 Thread Igor Morozov
bUpdaterIT.java e157c0dfde5efc418448e138aa008ade742fe816 src/test/python/apache/aurora/client/api/test_scheduler_client.py afbd385b7eda64cb1f7d118b695e65e4045eac6c Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-20 Thread Igor Morozov
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e157c0dfde5efc418448e138aa008ade742fe816 src/test/python/apache/aurora/client/api/test_scheduler_client.py afbd385b7eda64cb1f7d118b695e65e4045eac6c Diff: https://reviews.apache.org/r/50168/diff/ Testing ------- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-20 Thread Igor Morozov
e157c0dfde5efc418448e138aa008ade742fe816 src/test/python/apache/aurora/client/api/test_scheduler_client.py afbd385b7eda64cb1f7d118b695e65e4045eac6c Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-27 Thread Igor Morozov
r --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review143084 --- On July 21, 2016, 3:37 a.m., Igor Morozo

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
is the purpose of this call if it's not using the return value? As > > far as I can tell there are no side effects from the call. > > Igor Morozov wrote: > This is additional verification step similar to start() function. I think > this step is not nessesar

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e157c0dfde5efc418448e138aa008ade742fe816 src/test/python/apache/aurora/client/api/test_scheduler_client.py afbd385b7eda64cb1f7d118b695e65e4045eac6c Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
e with removing it as soon as we don't need it as additional verification step. - Igor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review143139 ---

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review143421 ------- On July 28, 2016, 7:06 p.m., Igor Morozov wrote: > > --- >

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
eing cleand up and it sounds like it should be refactored away (see Maxim's comment). So what I'm trying to say it would not be too much of a stratch to extend the semantic of rollbacks and terminal states for update jobs. - Igor --------

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-28 Thread Igor Morozov
://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-29 Thread Igor Morozov
rue terminal state > > in this model. > > > > I'm not against reusing the rollback functionality built into the scheduler > > in the way you're doing, but maybe we should introduce a new STATE to > > reflect that it was user-initiated and add it to ALLO

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-29 Thread Igor Morozov
g back to? In this example that simply means having just 5 instances running after rollback. - Igor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review144137

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-07-29 Thread Igor Morozov
elf we rollback _to_ that update's target > > state. For example (desired state === desiredState + settings + > > instanceCount): > > U1: desired state A > > U2: desired state B > > U3: desired state C > > > > To rollback to state B: U4: use desired stat

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-01 Thread Igor Morozov
/updater/JobUpdaterIT.java e157c0dfde5efc418448e138aa008ade742fe816 src/test/python/apache/aurora/client/api/test_scheduler_client.py afbd385b7eda64cb1f7d118b695e65e4045eac6c Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-02 Thread Igor Morozov
e157c0dfde5efc418448e138aa008ade742fe816 src/test/python/apache/aurora/client/api/test_scheduler_client.py afbd385b7eda64cb1f7d118b695e65e4045eac6c Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Igor Morozov
afbd385b7eda64cb1f7d118b695e65e4045eac6c src/test/python/apache/aurora/client/cli/test_supdate.py 317b17547e8b33106787fbe43b26cec2da830ba1 Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Igor Morozov
317b17547e8b33106787fbe43b26cec2da830ba1 Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-03 Thread Igor Morozov
: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-08 Thread Igor Morozov
ji, wfarner any additional feedback on this review please? - Igor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review144689 ---

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-09 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review145144 --- On Aug. 3, 2016, 10:16 p.m., Igor Morozov wrote: > > --

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-09 Thread Igor Morozov
317b17547e8b33106787fbe43b26cec2da830ba1 Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-09 Thread Igor Morozov
50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-10 Thread Igor Morozov
Diff: https://reviews.apache.org/r/50168/diff/ Testing --- Thanks, Igor Morozov

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-10 Thread Igor Morozov
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review145356 --- On Aug. 11, 2016, 1:32 a.m., Igor Morozov wrote: > >

Re: Review Request 50168: Add rollback functionality to the scheduler

2016-08-11 Thread Igor Morozov
--- Thanks, Igor Morozov