Re: Review Request 34733: Fixing default TaskReconciler initial delay.

/TaskReconciler.java <https://reviews.apache.org/r/34733/#comment136996> Move this validation to the constructor so that it will halt injector creation. - Kevin Sweeney On May 27, 2015, 1:52 p.m., Maxim Khutornenko wrote: > > ---

Re: Review Request 34501: Enabling TemporaryStorage to use flagged task store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34501/#review85449 --- Ship it! Ship It! - Kevin Sweeney On May 22, 2015, 5:31 p.m

Re: Review Request 34661: Adds new documentation page listing Apache Aurora presentations (both videos and slides).

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34661/ > --- > > (Updated May 27, 2015, 3:42 p.m.) > > > Review reque

Re: Review Request 34739: Adding ChainedPathDetector into the GC executor.

ration/#module-hamcrest.library.integration.match_equality - Kevin Sweeney On May 27, 2015, 5:03 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 34566: Adding H2 management console.

<https://reviews.apache.org/r/34566/#comment138774> Use a MediaType constant here. - Kevin Sweeney On June 4, 2015, 12:31 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

tps://reviews.apache.org/r/34300/#comment138805> Why set this at all? Does the scheduler read this field? - Kevin Sweeney On June 1, 2015, 11:05 a.m., Brian Wickman wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 34570: Use set-literals and set-comprehensions where possible

the language) later we should do a full refactor for that. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34570/#review84837 --------

Review Request 35219: Relax requirement for .ini file sections.

/http/api/security/shiro-malformed-no-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/35219/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 34661: Adds new documentation page listing Apache Aurora presentations (both videos and slides).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34661/#review87280 --- Ship it! Ship It! - Kevin Sweeney On June 8, 2015, 11:40 a.m

Re: Review Request 33778: Adds RPM specfile and support scripting

; RHS is redundant - you can just do ``` export GLOG_v LIBPROCESS_PORT LIBPROCES_IP ``` packaging/rpm/aurora.sysconfig <https://reviews.apache.org/r/33778/#comment139596> Is this needed? This is the default right? - Kevin Sweeney

Review Request 35274: Upgrade to requests-kerberos 0.7.0.

pending Thanks, Kevin Sweeney

Re: Review Request 35274: Upgrade to requests-kerberos 0.7.0.

--- e2e test run pending Thanks, Kevin Sweeney

Re: Review Request 35483: Removing deprecated JobUpdateSummary fields.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35483/#review88011 --- Ship it! Ship It! - Kevin Sweeney On June 15, 2015, 5:27 p.m

Re: Review Request 32973: Allow config of the /quitquitquit and /abortabortabort endpoints.

tps://reviews.apache.org/r/32973/#comment140417> s/it's/its/ - Kevin Sweeney On June 12, 2015, 4:11 a.m., Brian Brazil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Review Request 35535: Use Shiro identity if available in audit logs.

build Thanks, Kevin Sweeney

Re: Review Request 35535: Use Shiro identity if available in audit logs.

/UnsecureSessionContextTest.java PRE-CREATION Diff: https://reviews.apache.org/r/35535/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 35535: Use Shiro identity if available in audit logs.

Diff: https://reviews.apache.org/r/35535/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Review Request 35627: Explicitly bind SessionContext.

/35627/diff/ Testing --- Ran kerberos e2e test and verified audit messages in UI. Thanks, Kevin Sweeney

Re: Review Request 35627: Explicitly bind SessionContext.

Diff: https://reviews.apache.org/r/35627/diff/ Testing (updated) --- Ran kerberos e2e test. Thanks, Kevin Sweeney

Re: Review Request 35627: Explicitly bind SessionContext.

/UnsecureSessionContextTest.java 0a842cb9cdd266690b2d3103126e831fe07b1735 src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 4d6043a402a761fe44239e33b83c1c8872fe7068 Diff: https://reviews.apache.org/r/35627/diff/ Testing --- Ran kerberos e2e test. Thanks, Kevin Sweeney

Re: Review Request 35627: Explicitly bind SessionContext.

/ Testing --- Ran kerberos e2e test. Thanks, Kevin Sweeney

Re: Review Request 35613: Fixing broken gradle dependency scanner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88464 --- Ship it! Ship It! - Kevin Sweeney On June 18, 2015, 3:12 p.m

Re: Review Request 35633: Fixing stylecheck errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35633/#review88465 --- Ship it! Ship It! - Kevin Sweeney On June 18, 2015, 4:15 p.m

Re: Review Request 34300: Do better sanitation on the client side when encountering unbound pystachio refs

> On June 4, 2015, 4:55 p.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/config/thrift.py, line 218 > > <https://reviews.apache.org/r/34300/diff/3/?file=975774#file975774line218> > > > > Why set this at all? Does the scheduler read this field? &

Re: Review Request 35813: Removing GC executor code.

> On June 23, 2015, 5:31 p.m., Brian Wickman wrote: > > slightly overzealous deleting. the thermos gc stuff should still be part > > of the thermos toolchain. > > Maxim Khutornenko wrote: > Should not we rather rely on task reconciliation to do any cleanup > instead? Force GCing a task do

Review Request 35842: Use java.util.Optional and streams in LockManager

/GuavaCollectorsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/35842/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

/util/GuavaCollectorsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/35842/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 35847: Split http lifecycle into a composition layer.

) <https://reviews.apache.org/r/35847/#comment141844> Convention is to not capitalize acronyms like HTTP, but to render them as Http (here and below). - Kevin Sweeney On June 24, 2015, 2:55 p.m., Brian Wickman wrote: > > ---

Re: Review Request 35498: Compute SLA stats for non-prod jobs

/MetricCalculator.java (lines 129 - 130) <https://reviews.apache.org/r/35498/#comment141980> Add getters for these fields and access them below via the getters rather than direct field access. - Kevin Sweeney On June 24, 2015, 12:09 p.m., Stephan Erb

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

ower blast-radius change - this file is almost 1400 lines, and many of the APIs it calls are still written in terms of guava Optional. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3584

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

/GuavaCollectorsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/35842/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 35842: Use java.util.Optional and streams in LockManager

/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965 Diff: https://reviews.apache.org/r/35842/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Review Request 35886: Remove static modifier from test case.

public or default constructor. Diffs - src/test/java/org/apache/aurora/GuavaUtilsTest.java 065a4bac48b7264c1c6aaf228c684f813f2a39ea Diff: https://reviews.apache.org/r/35886/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 35498: Compute SLA stats for non-prod jobs

> On June 25, 2015, 10:59 a.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, lines > > 138-139 > > <https://reviews.apache.org/r/35498/diff/7/?file=991483#file991483line138> > > > > Add getters for the

Re: Review Request 35932: Remove unnecessary uses of type witness.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35932/#review89531 --- Ship it! Ship It! - Kevin Sweeney On June 26, 2015, 10:50 a.m

Review Request 36015: Fix terminology in cron docs.

--- Fix terminology in cron docs. Diffs - docs/cron-jobs.md 2f36dc97daf65e39adb554cc74981f40a7d64220 Diff: https://reviews.apache.org/r/36015/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 36060: Disabling h2 console by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36060/#review89948 --- Ship it! Ship It! - Kevin Sweeney On June 30, 2015, 11:46 a.m

Re: Review Request 36063: Make e2e test fail when a command fails.

cho '!!! FAILED' !!! FAILED + echo ``` Thanks, Kevin Sweeney

Review Request 36063: Make e2e test fail when a command fails.

son + sudo stop aurora-scheduler-kerberos aurora-scheduler-kerberos stop/waiting + sudo rm -f /etc/init/aurora-scheduler-kerberos.conf + sudo start aurora-scheduler aurora-scheduler start/running, process 13559 + [[ 1 -ne 0 ]] + echo + echo '!!! FAILED' !!! FAILED + echo Thanks, Kevin Sweeney

Re: Review Request 35928: Avoid unintentional use of TaskStatus.Reason default value.

/MesosSchedulerImpl.java (lines 228 - 230) <https://reviews.apache.org/r/35928/#comment143027> Do this above as well? - Kevin Sweeney On July 1, 2015, 10:30 a.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 36100: Upgrade to rbt 0.7.4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36100/#review90093 --- Ship it! Ship It! - Kevin Sweeney On July 1, 2015, 11:29 a.m

Re: Review Request 36064: Perform leader redirect using HTTP status code 307

/LeaderRedirectFilter.java (line 46) <https://reviews.apache.org/r/36064/#comment143178> Use the `HttpHeaders.LOCATION` constant here instead. - Kevin Sweeney On June 30, 2015, 1:44 p.m., Stephan Erb wrote: > > --- > This is a

Re: Review Request 36220: Change docs to use a working git repo URL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36220/#review90580 --- Ship it! Ship It! - Kevin Sweeney On July 6, 2015, 2:37 p.m

Re: Review Request 33778: Adds RPM specfile and support scripting

d, the process is terminated by sending the signal specified in KillSignal= when service stop is requested. ``` [1] http://www.freedesktop.org/software/systemd/man/systemd.service.html#ExecStop= - Kevin Sweeney On July 6, 2015, 2:09 p.m., Steve Salevan

Re: Review Request 36096: Fix DB constraint violation when updating host attributes.

use slaveID instead of hostName as the canonical identifier for mesos slaves within aurora? - Kevin Sweeney On July 1, 2015, 1:01 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Review Request 36490: wip

b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

uth/UnsecureSessionContextTest.java 63917363f392e6d970fb7e0cb91b840ca5db173e src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Review Request 36492: Use aurora.local as hostname.

1c2390f0248e91e65a548e67f6af1be8d2526b0a Diff: https://reviews.apache.org/r/36492/diff/ Testing --- end-to-end test gets past service discovery errors. Thanks, Kevin Sweeney

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

taining > > "@ReviewBot retry" This looks like: https://bugs.openjdk.java.net/browse/JDK-8051402 - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36490/#revie

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

gt; 2 errors > > FAILED > > > > FAILURE: Build failed with an exception. > > > > * What went wrong: > > Execution failed for task ':compileJava'. > > > Compilation failed; see the compiler error output for details. > > > > *

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

https://reviews.apache.org/r/36490/diff/1/?file=1011891#file1011891line147> > > > > s/Bindings/Provider/ Fixed. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36490/#review91745

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

b173e src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 36490: Use Provider> instead of optional injection for Shiro audit logging.

63917363f392e6d970fb7e0cb91b840ca5db173e src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh 6e4a294d6ca7ffd3a733498211e66ad674ef0b39 Diff: https://reviews.apache.org/r/36490/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 36289: Custom executor support for Scheduler

> On July 15, 2015, 12:08 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java, lines > > 87-115 > > > > > > In this change, we cannot remove these arguments as it breaks > >

Review Request 36526: Use HTTPS for Twitter Maven repository.

--- Use HTTPS for Twitter Maven repository. Diffs - build.gradle 87a809f0fd0ee63cae84cc0269dfa5431b7e893f Diff: https://reviews.apache.org/r/36526/diff/ Testing --- rm -fr ~/.gradle/caches ./gradlew assemble Thanks, Kevin Sweeney

Re: Review Request 36561: Use the application-level storage lock to prevent DB-level deadlock when GCing rows.

age/db/RowGarbageCollector.java (line 92) <https://reviews.apache.org/r/36561/#comment145788> `deletedCount.get()` Or just move `deletedCount` and this log statement into the work block - Kevin Sweeney On July 16, 2015, 4:44 p.m., Bill

Re: Review Request 36561: Use the application-level storage lock to prevent DB-level deadlock when GCing rows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36561/#review91995 --- Ship it! Ship It! - Kevin Sweeney On July 16, 2015, 4:59 p.m

Review Request 36703: Remove unnecessary uses of Guava Joiner.

ler/thrift/ReadOnlySchedulerImpl.java 92c970c34ca9dc4f052760e5a3d3770a089d9a67 src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java 7c8f8b9b8d7deb082edc0f85a6d3da1536735545 Diff: https://reviews.apache.org/r/36703/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 36666: Break apart async package and AsyncModule into purpose-specific equivalents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3/#review92636 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2015, 4:51 p.m

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

tps://reviews.apache.org/r/36700/#comment146861> Can you delete the code these targets reference as well, as presumably there are now source files without BUILD file owners in our tree - Kevin Sweeney On July 22, 2015, 11:50 a.m., Bill Farner

Re: Review Request 36703: Replace Guava Joiner with String::join where simpler

https://reviews.apache.org/r/36703/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Review Request 36709: Remove generated FROM_BUILDER and TO_BUILDER methods.

/thrift_wrapper_codegen.py f3d92884dc1d35d576bbe84f70be6e46278444ed src/test/java/org/apache/aurora/scheduler/storage/entities/IHostAttributesTest.java 05b31c2f75da9df53ab66007a1e907900ed90cd0 Diff: https://reviews.apache.org/r/36709/diff/ Testing --- ./gradlew -Pq clean build Thanks, Kevin

Re: Review Request 36709: Remove generated FROM_BUILDER and TO_BUILDER methods.

/36709/diff/ Testing --- ./gradlew -Pq clean build Thanks, Kevin Sweeney

Review Request 36711: Remove all public static com.google.common.base.Functions

exception of the direct calls (IntelliJ inlines `Tasks.ASSIGNED_TO_ID.apply(assignedTask)` as `((Functionhttps://reviews.apache.org/r/36711/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Review Request 36713: Make Storage.Work an interface instead of an abstract class.

f5e1dd0ad205bd6e87b660cc7849a0bd92c787a7 Diff: https://reviews.apache.org/r/36713/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 36710: Add an executor service decorator that gates async operations.

https://code.google.com/p/guava-libraries/wiki/ListenableFutureExplained - Kevin Sweeney On July 22, 2015, 5:07 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 36710: Add an executor service decorator that gates async operations.

> On July 22, 2015, 5:11 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/async/GatedScheduledExecutorService.java, > > line 36 > > <https://reviews.apache.org/r/36710/diff/1/?file=1019150#file1019150line36> > > > > Co

Re: Review Request 36713: Make Storage.Work an interface instead of an abstract class.

should trigger a code smell warning. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36713/#review92694 ----------- On July 22, 2015, 5:07 p.m., Kevin Sweeney wrote: > > --

Re: Review Request 36711: Remove all public static com.google.common.base.Functions

`.apply`). This change was almost entirely IDE-driven, with the exception of the direct calls (IntelliJ inlines `Tasks.ASSIGNED_TO_ID.apply(assignedTask)` as `((Functionhttps://reviews.apache.org/r/36711/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 36735: Model DockerParameter in the database.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36735/#review92781 --- Ship it! Ship It! - Kevin Sweeney On July 23, 2015, 10:57 a.m

Re: Review Request 36745: Turn off strict host key checking for all hosts in vagrant.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36745/#review92857 --- Ship it! Ship It! - Kevin Sweeney On July 23, 2015, 2:36 p.m

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36700/ > ------- > > (Updated July 23, 2015, 5 p.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > >

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

rian Wickman wrote: > > Afaik nobody uses these in practice. They're only useful for when > you install the sdists via pip or pex directly. Instead we always build > pex binaries using pants which delegates to the python_binary target. > > > > Kevin Sweeney wrote: > >

Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

d71cc31b2bb86d1a7321e78cd7716a32ff47e47d Diff: https://reviews.apache.org/r/36797/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney

Re: Review Request 36797: Remove twitter.common.rpc dependency and upgrade requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36797/#review92997 --- @ReviewBot retry - Kevin Sweeney On July 24, 2015, 2:38 p.m

Re: Review Request 36710: Add an executor service decorator that gates async operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36710/#review93000 --- Ship it! Ship It! - Kevin Sweeney On July 23, 2015, 10:20 a.m

Re: Review Request 36700: Remove binary build targets that are not currently for general consumption.

t; break? Or do we just not use the sdists [this way]? > > Brian Wickman wrote: > Afaik nobody uses these in practice. They're only useful for when you > install the sdists via pip or pex directly. Instead we always build pex > binaries using pants which delegates to the

Re: Review Request 36700: Remove references to binary build targets that are not currently for general consumption.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36700/#review93209 --- Ship it! Ship It! - Kevin Sweeney On July 27, 2015, 5:58 p.m

Re: Review Request 36700: Remove references to binary build targets that are not currently for general consumption.

530> Is there any reason to remove the `./gradlew distTar` guidance? - Kevin Sweeney On July 27, 2015, 5:58 p.m., Bill Farner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 36874: Fix typo in the scheduler deployment documentation

Description --- Fix typo in scheduler deployment documentation The command should be run on schedulers, not masters. Diffs - docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d Diff: https://reviews.apache.org/r/36874/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 36945: Use the correct (aurora-specific) python build targets in RPM and deb scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36945/#review93615 --- Ship it! Ship It! - Kevin Sweeney On July 30, 2015, 9:13 a.m

Review Request 36972: One python_library per exported setup.py project

RPMs TODO: test DEBs TODO: test E2E Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

rg/r/36972/diff/ Testing (updated) --- ./pants test.pytest --no-fast src/test/python:: ./build-support/python/make-python-sdists E2E test gets as far as it usually does. Manually checked that `thermos status` works. I don't have a test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

as far as it usually does. Manually checked that `thermos status` works. I don't have a test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

erated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93744 ------- On July 31, 2015, 10:56 a.m., Kevin Sweeney wrote: > > --- > This is

Re: Review Request 36972: One python_library per exported setup.py project

ver from my example email). Fixed. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93722 --- On July 31, 2015

Re: Review Request 36972: One python_library per exported setup.py project

rmos status` works. I don't have a test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

nto its own package for now but happy to revisit in another diff. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93731 --------

Review Request 36998: Use hostname instead of IP in Kerberos end to end test.

/test_kerberos_end_to_end.sh 760997c8420e9e430912de406cef494a9118897a Diff: https://reviews.apache.org/r/36998/diff/ Testing --- ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

nd_to_end.sh Manually checked that `thermos status` works. I don't have a test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

8468776fb8b0758f5990b83ec362c5 > src/test/python/apache/thermos/monitoring/BUILD > f4ad7fc1245980ef727c7c4a30af89b2d8d1293a > src/test/python/apache/thermos/observer/BUILD > ff92a52fe7a88379e8aa1c1b2385c065bd375a68 > src/test/python/apache/thermos/observer/http/BUILD > 0cdaafc3e71d21d48c35e0dac68910c53d003fae > > Diff: https://reviews.apache.org/r/36972/diff/ > > > Testing > --- > > ./pants test.pytest --no-fast src/test/python:: > ./build-support/python/make-python-sdists > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > Manually checked that `thermos status` works. > > I don't have a test environment for the debian package or the spec file. > > > Thanks, > > Kevin Sweeney > >

Re: Review Request 36972: One python_library per exported setup.py project

g --- ./pants test.pytest --no-fast src/test/python:: ./build-support/python/make-python-sdists ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Manually checked that `thermos status` works. I don't have a test environment for the debian package or the spec file. Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

Manually checked that `thermos status` works. I don't have a test environment for the debian package or the spec file. Documentation pushed to https://github.com/kevints/aurora/blob/36972/docs/build-system.md Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

ile docs/build-system.md - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36972/#review93805 --- On July 31, 20

Re: Review Request 36972: One python_library per exported setup.py project

the debian package or the spec file. Documentation pushed to https://github.com/kevints/aurora/blob/36972/docs/build-system.md Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

e2e/test_end_to_end.sh ./build-support/python/make-pycharm-virtualenv Manually checked that `thermos status` works. I don't have a test environment for the debian package or the spec file. Documentation pushed to https://github.com/kevints/aurora/blob/36972/docs/build-system.md Thanks, Kevin Sweeney

Re: Review Request 36972: One python_library per exported setup.py project

he server-side (reuse > > aurora.executor?) should contain aurora executor, thermos cli, thermos > > observer and thermos runner. > > Kevin Sweeney wrote: > I like this suggestion and would like to refactor the code to fit it into > this framework. Would you accept that in a foll

Re: Review Request 36874: Fix typo in the scheduler deployment documentation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36874/#review93943 --- ping - Kevin Sweeney On July 27, 2015, 8:01 p.m., Kevin Sweeney

Review Request 37047: Build Kerberos clients in RPM.

- I don't have a test environment for RPMs. Thanks, Kevin Sweeney

  1   2   3   >