Re: Review Request 42387: working version of jessie builds

2016-01-21 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/ --- (Updated Jan. 21, 2016, 10:20 p.m.) Review request for Aurora, Benjamin

Re: Review Request 42387: working version of jessie builds

2016-01-21 Thread Dmitriy Shirchenko
> On Jan. 21, 2016, 1:26 a.m., Bill Farner wrote: > > build-artifact.sh, line 35 > > > > > > How about a selective `set -x`, `set +x` around the commands you wish > > to see echoed instead? Removed. Adding set -x,

Re: Review Request 42387: working version of jessie builds

2016-01-21 Thread Bill Farner
> On Jan. 20, 2016, 5:26 p.m., Bill Farner wrote: > > specs/debian/aurora-executor.thermos.init, lines 43-44 > > > > > > Is this necessary due to `app_daemonize` or is there more to it? > > Dmitriy Shirchenko wrote:

Re: Review Request 42387: working version of jessie builds

2016-01-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review115719 --- Ship it! Ship It! - Bill Farner On Jan. 21, 2016, 2:20 p.m.,

Re: Review Request 42387: working version of jessie builds

2016-01-21 Thread Benjamin Staffin
> On Jan. 19, 2016, 4:12 p.m., John Sirois wrote: > > builder/deb/debian-jessie/Dockerfile, line 38 > > > > > > Its not exactly clear to me how this is any better than downloading > > gradle from gradle. Since this

Re: Review Request 42387: working version of jessie builds

2016-01-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review115532 --- Mostly questions for posterity. build-artifact.sh (line 35)

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/ --- (Updated Jan. 20, 2016, 12:04 a.m.) Review request for Aurora, Benjamin

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
> On Jan. 20, 2016, 12:12 a.m., John Sirois wrote: > > specs/debian/aurora-scheduler.postinst, line 38 > > > > > > `specs/debian/aurora-scheduler.init` uses > > `PIDFILE=/var/run/aurora-scheduler.pid` - who uses

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
> On Jan. 17, 2016, 10:54 a.m., Stephan Erb wrote: > > specs/debian/aurora-scheduler.init, line 73 > > > > > > IIRC the `start-stop-daemon` does not restart failed processes. How > > does this interact with Aurora

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/ --- (Updated Jan. 20, 2016, 12:59 a.m.) Review request for Aurora, Benjamin

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review115281 --- I'm running through a test presently - will report back.

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
> On Jan. 17, 2016, 10:59 p.m., John Sirois wrote: > > This built fine for me, and installed fine as well, but the resulting > > scheduler has stdout and stderr attached to /dev/null which needs to be > > fixed (no logs). I had a harder time than I might resoning through things > > since

Re: Review Request 42387: working version of jessie builds

2016-01-19 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/ --- (Updated Jan. 19, 2016, 11:23 p.m.) Review request for Aurora, Benjamin

Re: Review Request 42387: working version of jessie builds

2016-01-17 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review114872 --- This built fine for me, and installed fine as well, but the

Re: Review Request 42387: working version of jessie builds

2016-01-17 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/#review114903 --- builder/deb/debian-jessie/build.sh (line 32)