Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47741/#review134781 --- Master (9f6a660) is green with this patch. ./build-support/jenki

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47741/ --- (Updated May 25, 2016, 4:12 p.m.) Review request for Aurora, Joshua Cohen and S

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-25 Thread Maxim Khutornenko
> On May 25, 2016, 6:19 a.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/js/filters.js, lines 97-99 > > > > > > In https://reviews.apache.org/r/47809/ you call this `"CPUs"` with a > > unit of `"core(

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-24 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47741/#review134710 --- Fix it, then Ship it! src/main/resources/scheduler/assets/js/f

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-24 Thread Stephan Erb
> On May 23, 2016, 11:42 p.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 168 > > > > > > Any reason why this resource is lowercase but all others are uppercase? > > Maxim Khu

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47741/#review134487 --- Ship it! Ship It! - Joshua Cohen On May 23, 2016, 9:26 p.m.,

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47741/#review134457 --- Master (9f6a660) is green with this patch. ./build-support/jenki

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-23 Thread Maxim Khutornenko
> On May 23, 2016, 9:42 p.m., Stephan Erb wrote: > > src/main/resources/scheduler/assets/js/controllers.js, line 168 > > > > > > Any reason why this resource is lowercase but all others are uppercase? These are actu

Re: Review Request 47741: Updating scheduler UI to use new resource objects

2016-05-23 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47741/#review134443 --- src/main/resources/scheduler/assets/js/controllers.js (line 168)