Re: Review Request 64508: Convert carriage returns to newlines in reviews

2017-12-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/#review193528 --- Unfortunately the patch I submitted broke review requests. Sorry

Re: Review Request 64508: Convert carriage returns to newlines in reviews

2017-12-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/#review193522 --- @ReviewBot retry - Stephan Erb On Dec. 12, 2017, 10:05 a.m.,

Re: Review Request 64508: Convert carriage returns to newlines in reviews

2017-12-12 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/ --- (Updated Dec. 12, 2017, 10:05 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 64508: Convert carriage returns to newlines in reviews

2017-12-12 Thread Stephan Erb
> On Dec. 12, 2017, 2:17 a.m., Bill Farner wrote: > > build-support/jenkins/review_feedback.py > > Line 178 (original), 178 (patched) > > > > > > Can you include a comment for posterity? Referencing AURORA-1961

Re: Review Request 64508: Convert carriage returns to newlines in reviews

2017-12-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/#review193477 --- Ship it! build-support/jenkins/review_feedback.py Line 178

Re: Review Request 64508: Convert carriage returns to newlines in reviews

2017-12-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64508/#review193447 --- The script is run from master so it will only work once comitted.