Re: Review Request 64508: Convert carriage returns to newlines in reviews

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64508/#review193528
---



Unfortunately the patch I submitted broke review requests. Sorry for being 
sloppy here.

I have pushed 
https://github.com/apache/aurora/commit/301f066369a9ef7262c1702c77004d12bc8eac00
 unbreak the build.

- Stephan Erb


On Dec. 12, 2017, 10:05 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64508/
> ---
> 
> (Updated Dec. 12, 2017, 10:05 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1961
> https://issues.apache.org/jira/browse/AURORA-1961
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Spotbugs prints multiple lines with \r [1][2]. This looks like a single
> line for shell commands but will be converted to multiple lines once
> read by Python.
> 
> By performing the conversion before the tail command, we will get a
> consistent line count in Bash and Python.
> 
> [1] 
> https://github.com/spotbugs/spotbugs/blob/fe8a8d66e97d3ae0b830731461aab0f8b39791f6/spotbugs/src/main/java/edu/umd/cs/findbugs/TextUIProgressCallback.java#L103
> [2] https://github.com/spotbugs/spotbugs/issues/506
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> a6eeceeb3815b0f49a66c9d6b459d9ce64f515a3 
> 
> 
> Diff: https://reviews.apache.org/r/64508/diff/2/
> 
> 
> Testing
> ---
> 
> ./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 64508: Convert carriage returns to newlines in reviews

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64508/#review193522
---



@ReviewBot retry

- Stephan Erb


On Dec. 12, 2017, 10:05 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64508/
> ---
> 
> (Updated Dec. 12, 2017, 10:05 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1961
> https://issues.apache.org/jira/browse/AURORA-1961
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Spotbugs prints multiple lines with \r [1][2]. This looks like a single
> line for shell commands but will be converted to multiple lines once
> read by Python.
> 
> By performing the conversion before the tail command, we will get a
> consistent line count in Bash and Python.
> 
> [1] 
> https://github.com/spotbugs/spotbugs/blob/fe8a8d66e97d3ae0b830731461aab0f8b39791f6/spotbugs/src/main/java/edu/umd/cs/findbugs/TextUIProgressCallback.java#L103
> [2] https://github.com/spotbugs/spotbugs/issues/506
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> a6eeceeb3815b0f49a66c9d6b459d9ce64f515a3 
> 
> 
> Diff: https://reviews.apache.org/r/64508/diff/2/
> 
> 
> Testing
> ---
> 
> ./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 64508: Convert carriage returns to newlines in reviews

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64508/
---

(Updated Dec. 12, 2017, 10:05 a.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-1961
https://issues.apache.org/jira/browse/AURORA-1961


Repository: aurora


Description
---

Spotbugs prints multiple lines with \r [1][2]. This looks like a single
line for shell commands but will be converted to multiple lines once
read by Python.

By performing the conversion before the tail command, we will get a
consistent line count in Bash and Python.

[1] 
https://github.com/spotbugs/spotbugs/blob/fe8a8d66e97d3ae0b830731461aab0f8b39791f6/spotbugs/src/main/java/edu/umd/cs/findbugs/TextUIProgressCallback.java#L103
[2] https://github.com/spotbugs/spotbugs/issues/506


Diffs (updated)
-

  build-support/jenkins/review_feedback.py 
a6eeceeb3815b0f49a66c9d6b459d9ce64f515a3 


Diff: https://reviews.apache.org/r/64508/diff/2/

Changes: https://reviews.apache.org/r/64508/diff/1-2/


Testing
---

./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu


Thanks,

Stephan Erb

Re: Review Request 64508: Convert carriage returns to newlines in reviews

[Stephan Erb]

> On Dec. 12, 2017, 2:17 a.m., Bill Farner wrote:
> > build-support/jenkins/review_feedback.py
> > Line 178 (original), 178 (patched)
> > 
> >
> > Can you include a comment for posterity?  Referencing AURORA-1961 would 
> > be ideal since it holds context (should also be on the Bugs line of this 
> > review).

Good idea. Added.


- Stephan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64508/#review193477
---


On Dec. 12, 2017, 10:05 a.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64508/
> ---
> 
> (Updated Dec. 12, 2017, 10:05 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-1961
> https://issues.apache.org/jira/browse/AURORA-1961
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Spotbugs prints multiple lines with \r [1][2]. This looks like a single
> line for shell commands but will be converted to multiple lines once
> read by Python.
> 
> By performing the conversion before the tail command, we will get a
> consistent line count in Bash and Python.
> 
> [1] 
> https://github.com/spotbugs/spotbugs/blob/fe8a8d66e97d3ae0b830731461aab0f8b39791f6/spotbugs/src/main/java/edu/umd/cs/findbugs/TextUIProgressCallback.java#L103
> [2] https://github.com/spotbugs/spotbugs/issues/506
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> a6eeceeb3815b0f49a66c9d6b459d9ce64f515a3 
> 
> 
> Diff: https://reviews.apache.org/r/64508/diff/2/
> 
> 
> Testing
> ---
> 
> ./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 64508: Convert carriage returns to newlines in reviews

[Bill Farner]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64508/#review193477
---


Ship it!





build-support/jenkins/review_feedback.py
Line 178 (original), 178 (patched)


Can you include a comment for posterity?  Referencing AURORA-1961 would be 
ideal since it holds context (should also be on the Bugs line of this review).


- Bill Farner


On Dec. 11, 2017, 1:11 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64508/
> ---
> 
> (Updated Dec. 11, 2017, 1:11 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Spotbugs prints multiple lines with \r [1][2]. This looks like a single
> line for shell commands but will be converted to multiple lines once
> read by Python.
> 
> By performing the conversion before the tail command, we will get a
> consistent line count in Bash and Python.
> 
> [1] 
> https://github.com/spotbugs/spotbugs/blob/fe8a8d66e97d3ae0b830731461aab0f8b39791f6/spotbugs/src/main/java/edu/umd/cs/findbugs/TextUIProgressCallback.java#L103
> [2] https://github.com/spotbugs/spotbugs/issues/506
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> a6eeceeb3815b0f49a66c9d6b459d9ce64f515a3 
> 
> 
> Diff: https://reviews.apache.org/r/64508/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 64508: Convert carriage returns to newlines in reviews

[Stephan Erb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64508/#review193447
---



The script is run from master so it will only work once comitted.

- Stephan Erb


On Dec. 11, 2017, 9:47 p.m., Stephan Erb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64508/
> ---
> 
> (Updated Dec. 11, 2017, 9:47 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Spotbugs prints multiple lines with \r [1][2]. This looks like a single
> line for shell commands but will be converted to multiple lines once
> read by Python.
> 
> By performing the conversion before the tail command, we will get a
> consistent line count in Bash and Python.
> 
> [1] 
> https://github.com/spotbugs/spotbugs/blob/fe8a8d66e97d3ae0b830731461aab0f8b39791f6/spotbugs/src/main/java/edu/umd/cs/findbugs/TextUIProgressCallback.java#L103
> [2] https://github.com/spotbugs/spotbugs/issues/506
> 
> 
> Diffs
> -
> 
>   build-support/jenkins/review_feedback.py 
> a6eeceeb3815b0f49a66c9d6b459d9ce64f515a3 
> 
> 
> Diff: https://reviews.apache.org/r/64508/diff/1/
> 
> 
> Testing
> ---
> 
> ./gradlew --console=plain -Pq build 2>&1 | tr -u "\r" "\n" | tee build_outpu
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>