Re: Review Request 42984: Add failed result email protocol.

2016-02-04 Thread John Sirois
> On Jan. 29, 2016, 5:52 p.m., John Sirois wrote: > > jfarrell: I'm definitely going to wait on your opinion on this one. I'm > > viewing you as the expert in this bunch on what the [RFC > > 2119](https://www.ietf.org/rfc/rfc2119.txt) keywords are for these emails. I'll take silence as implic

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117068 --- jfarrell: I'm definitely going to wait on your opinion on this one

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117064 --- Ship it! Master (0eb753d) is green with this patch. ./build-s

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/ --- (Updated Jan. 29, 2016, 4:56 p.m.) Review request for Aurora, Jake Farrell, Max

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117054 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 29, 2016, 11:2

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117053 --- Ship it! Master (0eb753d) is green with this patch. ./build-s

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Bill Farner
> On Jan. 29, 2016, 3:29 p.m., Bill Farner wrote: > > docs/committers.md, line 67 > > > > > > The `[RESULT][VOTE]` part should become step 5 - successful and failed > > votes are closed out in the same way. > > John

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
> On Jan. 29, 2016, 4:29 p.m., Bill Farner wrote: > > docs/committers.md, line 67 > > > > > > The `[RESULT][VOTE]` part should become step 5 - successful and failed > > votes are closed out in the same way. > > John

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
> On Jan. 29, 2016, 4:29 p.m., Bill Farner wrote: > > docs/committers.md, line 67 > > > > > > The `[RESULT][VOTE]` part should become step 5 - successful and failed > > votes are closed out in the same way. Well, wh

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117046 --- Fix it, then Ship it! docs/committers.md (line 67)

Re: Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/#review117044 --- docs/committers.md (line 73)

Review Request 42984: Add failed result email protocol.

2016-01-29 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42984/ --- Review request for Aurora, Jake Farrell, Maxim Khutornenko, and Bill Farner. Re