Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127706 --- Ship it! Josh asked me offline to take a look at this and every

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127628 --- Ship it! Master (915459d) is green with this patch. ./build-s

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 7, 2016, 4:49 p.m., Maxim Khutornenko wrote: > > docs/development/db-migration.md, line 14 > > > > > > Link V001_TestMigration.java here as a reference? Done. > On April 7, 2016, 4:49 p.m., Maxim Khutorn

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- (Updated April 7, 2016, 5:29 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127612 --- Ship it! Master (915459d) is green with this patch. ./build-s

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127611 --- Ship it! docs/development/db-migration.md (line 14)

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 9:24 p.m., Maxim Khutornenko wrote: > > RELEASE-NOTES.md, line 14 > > > > > > This is actually doc-worthy. Mind amending > > https://github.com/apache/aurora/blob/master/docs/development/thrift.md

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- (Updated April 7, 2016, 4:35 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127468 --- Ship it! Master (103dae6) is green with this patch. ./build-s

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 9:24 p.m., Maxim Khutornenko wrote: > > RELEASE-NOTES.md, line 14 > > > > > > This is actually doc-worthy. Mind amending > > https://github.com/apache/aurora/blob/master/docs/development/thrift.md

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 9:24 p.m., Maxim Khutornenko wrote: > > RELEASE-NOTES.md, line 14 > > > > > > This is actually doc-worthy. Mind amending > > https://github.com/apache/aurora/blob/master/docs/development/thrift.md

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- (Updated April 6, 2016, 9:26 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127459 --- RELEASE-NOTES.md (line 14)

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127457 --- This patch does not apply cleanly against master (103dae6), do you

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- (Updated April 6, 2016, 9:17 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 8:30 p.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/MigrationMapper.xml, > > line 20 > > > > > > This can be `sql`, right? > > Joshua Cohen wrote: >

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 8:37 p.m., Zameer Manji wrote: > > build.gradle, line 369 > > > > > > If the goal here is to prevent a version conflict, there is an existing > > mechanism higher up in the file that looks like t

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- (Updated April 6, 2016, 9:11 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127437 --- build.gradle (line 369)

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

> On April 6, 2016, 8:30 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java, > > line 84 > > > > > > How about making MigrationMapper an interface and se

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127429 --- src/main/java/org/apache/aurora/scheduler/storage/backup/Temporar

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127430 --- Ship it! Master (103dae6) is green with this patch. ./build-s

Re: Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/#review127427 --- config/checkstyle/suppressions.xml (lines 24 - 25)

Review Request 45816: Add support for automated DB migrations and rollbacks when restoring from dbScript stored in a snapshot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45816/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1648