Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread John Sirois
> On Sept. 2, 2016, 12:35 p.m., John Sirois wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 251 > > > > > > You might extract this as a helper function > > (`_entity_exists(returncode:

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread Zhitao Li
> On Sept. 2, 2016, 6:35 p.m., John Sirois wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 251 > > > > > > You might extract this as a helper function > > (`_entity_exists(returncode:

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread John Sirois
> On Sept. 2, 2016, 12:35 p.m., John Sirois wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 251 > > > > > > You might extract this as a helper function > > (`_entity_exists(returncode:

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147681 --- Ship it!

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-02 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147667 --- Ship it! Ship it! I am not a fan of extensive mocking.

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147617 --- Master (bd11b1c) is red with this patch.

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread Zhitao Li
> On Aug. 31, 2016, 10:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread John Sirois
> On Aug. 31, 2016, 4:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread Stephan Erb
> On Sept. 1, 2016, 12:17 a.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread John Sirois
> On Aug. 31, 2016, 4:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-09-01 Thread John Sirois
> On Aug. 31, 2016, 4:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-08-31 Thread Joshua Cohen
> On Aug. 31, 2016, 10:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, line 239 > > > > > > This changes seems to come with a severe security risk. As an normal > > user, I

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-08-31 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147497 --- src/main/python/apache/aurora/executor/common/sandbox.py (line

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-08-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147492 --- Ship it! Master (bd11b1c) is green with this patch.

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-08-31 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147490 --- Ship it! Ship It! - Zameer Manji On Aug. 31, 2016, 1:56

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-08-31 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/ --- (Updated Aug. 31, 2016, 8:56 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-08-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147487 --- Master (bd11b1c) is red with this patch.

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-08-31 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/ --- (Updated Aug. 31, 2016, 8:38 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-08-31 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147480 --- Master (bd11b1c) is red with this patch.

Re: Review Request 51564: Allow E_NAME_IN_USE in useradd/groupadd.

2016-08-31 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51564/#review147475 --- Please add a test case to cover this (can use the existing tests