Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162721 --- Ship it! Ship It! - Zameer Manji On Jan. 23, 2017, 12:21

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162710 --- Spoke with Zameer offline and he'll actually land this once he

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162709 --- Ship it! Master (75129b6) is green with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162703 --- @ReviewBot retry - John Sirois On Jan. 23, 2017, 1:21 p.m.,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

> On Jan. 23, 2017, 2:16 p.m., Aurora ReviewBot wrote: > > Master (75129b6) is red with this patch. > > ./build-support/jenkins/build.sh > > > > Test coverage missing for org/apache/aurora/scheduler/events/Webhook > > Test coverage missing for

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162700 --- Master (75129b6) is red with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162698 --- Ship it! Ship It! - David McLaughlin On Jan. 23, 2017, 8:21

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162697 --- @ReviewBot retry - John Sirois On Jan. 23, 2017, 1:21 p.m.,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162696 --- Ship it! Master (dc6f27e) is green with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162693 --- Ship it! Ship It! - Joshua Cohen On Jan. 23, 2017, 8:21

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162691 --- @ReviewBot retry - John Sirois On Jan. 23, 2017, 1:21 p.m.,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162690 --- Ship it! Master (dc6f27e) is green with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162688 --- Ship it! Ship It! - John Sirois On Jan. 23, 2017, 1:21

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162687 --- NB: The [5-6

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/ --- (Updated Jan. 23, 2017, 1:21 p.m.) Review request for Aurora, David

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158815 --- Master (c8e8953) is red with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158812 --- @ReviewBot retry - Zameer Manji On Dec. 11, 2016, 4:43 p.m.,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158601 --- Does anyone know how to get the test reports from jenkins or have

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158597 --- Master (f5749ce) is red with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/ --- (Updated Dec. 8, 2016, 3:06 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158593 --- Master (f5749ce) is red with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/ --- (Updated Dec. 8, 2016, 2:24 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review158567 --- Ship it! LGTM. Please also add an entry to the changelog. -

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

> On Dec. 2, 2016, 3:58 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java, > > lines 215-218 > > > > > > Should we have an escape hatch for the case

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

> On Dec. 2, 2016, 10:37 p.m., Zameer Manji wrote: > > Can someone else validate that the tests pass for them locally? I can't > > reproduce the jenkins failure. I wonder if this is a timing issue in the tests ? `expectGroupEvent(PathChildrenCacheEvent.Type.CHILD_ADDED)` returns as soon as

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review157847 --- Can someone else validate that the tests pass for them locally? I

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review157844 --- Master (4bc5246) is red with this patch.

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review157840 --- @ReviewBot retry - Zameer Manji On Dec. 1, 2016, 7:19 p.m.,

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review157759 --- Thanks for picking this up! This is a basic question, but I just

Re: Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review157696 --- Master (3ea0331) is red with this patch.

Review Request 54288: Make leader elections resilient to ZK disconnections.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and