Re: Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/#review54138 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 20, 2014, 3:06 a.

Re: Review Request 24752: combine finalization_wait when combining tasks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24752/#review54144 --- Ship it! Sorry for taking so long to get to this review. The code

Re: Review Request 25857: Disable updater by default in prod.

> On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 286 > > > > > > I see why you went this route, but it's a precedent i

Re: Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/#review54145 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/TaskSched

Review Request 25897: Adding timing stats to DB stores.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25897/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 24173: AURORA-607:release script is broken

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24173/ --- (Updated Sept. 22, 2014, 5:46 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 24173: AURORA-607:release script is broken

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24173/#review54149 --- Ship it! Ship It! - Kevin Sweeney On Sept. 22, 2014, 10:46 a.m.,

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/#review54150 --- src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager

Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/ --- Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner. Bugs: A

Re: Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/#review54152 --- docs/committers.md

Re: Review Request 25859: Fix some bugs in the Update UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/ --- (Updated Sept. 22, 2014, 6:24 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 25859: Fix some bugs in the Update UI

> On Sept. 20, 2014, 1:02 a.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml, > > line 275 > > > > > > This will fail unit tests as is. Thanks. Fix

Re: Review Request 25897: Adding timing stats to DB stores.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25897/#review54156 --- Ship it! Ship It! - Bill Farner On Sept. 22, 2014, 5:42 p.m., Ma

Re: Review Request 25857: Disable updater by default in prod.

> On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 286 > > > > > > I see why you went this route, but it's a precedent i

Re: Review Request 25859: Fix some bugs in the Update UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54159 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 22, 2014, 6:24 p.

Re: Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25872/ --- (Updated Sept. 22, 2014, 6:42 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 25872: Instrument task scheduling code to give visibility into failed searches and backoffs.

> On Sept. 22, 2014, 5:34 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java, line 180 > > > > > > typo in "attemptsFired" Thanks, fixed. - Bill -

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 11:52 a.m.) Review request for Aurora, Maxim Khutornen

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

> On Sept. 22, 2014, 11 a.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java, > > line 127 > > > > > > What's the context around replacing MessageDigest with

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/#review54171 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 22, 2014, 6:52 p.

Re: Review Request 25857: Disable updater by default in prod.

> On Sept. 20, 2014, 2:14 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 1375 > > > > > > How about: > > > > return addMessage( > >

Re: Review Request 25857: Disable updater by default in prod.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 22, 2014, 8:41 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/ --- (Updated Sept. 22, 2014, 9:01 p.m.) Review request for Aurora, Dave Lester, Kev

Re: Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key

> On Sept. 22, 2014, 6:23 p.m., Kevin Sweeney wrote: > > docs/committers.md, line 29 > > > > > > add a mention of git config user.signingkey here too? Good call, the release scripts do check and print out an error msg

Re: Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25898/#review54195 --- Ship it! Ship It! docs/committers.md

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 4:07 p.m.) Review request for Aurora, Maxim Khutornenk

Review Request 25913: HTML Grid Fixes in Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. Reposi

Re: Review Request 25913: HTML Grid Fixes in Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/ --- (Updated Sept. 22, 2014, 11:23 p.m.) Review request for Aurora, Joshua Cohen, K

Review Request 25914: use javax.inject.Qualifier

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- Review request for Aurora. Repository: aurora Description --- use javax.

Re: Review Request 25914: use javax.inject.Qualifier

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- (Updated Sept. 22, 2014, 4:35 p.m.) Review request for Aurora. Changes --

Re: Review Request 25914: use javax.inject.Qualifier

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/#review54206 --- Ship it! Ship It! - Zameer Manji On Sept. 22, 2014, 4:35 p.m., K

Re: Review Request 25914: use javax.inject.Qualifier

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/#review54207 --- Ship it! Ship It! - Bill Farner On Sept. 22, 2014, 11:35 p.m., K

Re: Review Request 25913: HTML Grid Fixes in Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/#review54208 --- Ship it! Ship It! - Bill Farner On Sept. 22, 2014, 11:23 p.m., D

Re: Review Request 25913: HTML Grid Fixes in Scheduler UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25913/#review54209 --- Ship it! I'm sure it's fine, but in the future it might be helpful

Re: Review Request 25914: use javax.inject.Qualifier

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- (Updated Sept. 22, 2014, 5:27 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/#review54214 --- Ping wfarner - Kevin Sweeney On Sept. 22, 2014, 4:07 p.m., Kevin

Re: Review Request 25857: Disable updater by default in prod.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/#review54216 --- Ship it! Thanks! - Bill Farner On Sept. 22, 2014, 8:41 p.m., Max

Re: Review Request 25913: HTML Grid Fixes in Scheduler UI

> On Sept. 23, 2014, 12:08 a.m., Joshua Cohen wrote: > > I'm sure it's fine, but in the future it might be helpful to include > > screenshots comparable to those in the ticket showing the proper alignment? Ack. Will add before/after screenshots for this type of work in the future. - David -

Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25835/#review54220 --- Tried this out locally and realized /graphview isn't working (404).

Re: Review Request 25812: Implementing quota checking for async job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ --- (Updated Sept. 23, 2014, 12:59 a.m.) Review request for Aurora, David McLaughli

Re: Review Request 25812: Implementing quota checking for async job updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/#review54168 --- src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java <

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/#review54224 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/log/Ent

Re: Review Request 25857: Disable updater by default in prod.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25857/ --- (Updated Sept. 23, 2014, 1:12 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 6:35 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

> On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, > > line 63 > > > > > > While you're here, might as well drop @Timed to start collectin

Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ --- (Updated Sept. 22, 2014, 6:39 p.m.) Review request for Aurora, Maxim Khutornenk

Review Request 25918: Improve aurora command-line help using metavars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25918/ --- Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-737

Re: Review Request 25918: Improve aurora command-line help using metavars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25918/#review54233 --- Ship it! Ship It! - David McLaughlin On Sept. 23, 2014, 1:53 a.m

Re: Review Request 25918: Improve aurora command-line help using metavars.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25918/#review54239 --- Ship it! Ship It! - Zameer Manji On Sept. 22, 2014, 6:53 p.m., M