Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-913

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/#review61031 --- Master (148f427) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27892: Fixes for the make pycharm script:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27892/#review61032 --- build-support/python/make-pycharm-virtualenv

Re: Review Request 27892: Fixes for the make pycharm script:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27892/ --- (Updated Nov. 12, 2014, 7:29 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 27892: Fixes for the make pycharm script:

> On Nov. 12, 2014, 7:20 p.m., Kevin Sweeney wrote: > > build-support/python/make-pycharm-virtualenv, line 48 > > > > > > you can avoid the use of backslashes to escape the individual $s here > > if you use <<"EOF" I

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/#review61035 --- src/main/java/org/apache/aurora/scheduler/state/MaintenanceControll

Re: Review Request 27892: Fixes for the make pycharm script:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27892/#review61044 --- Ship it! Ship It! - Kevin Sweeney On Nov. 12, 2014, 11:29 a.m.,

Re: Review Request 27852: Ensure run verb returns an exit code.

> On Nov. 11, 2014, 2:55 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/cli/task.py, line 72 > > > > > > Should we just make this the default behavior? There's at least 31 > > locations that do this

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/#review61065 --- Ship it! src/main/java/org/apache/aurora/scheduler/mesos/MesosSche

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

> On Nov. 12, 2014, 7:32 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java, > > line 55 > > > > > > What does this mean exactly? Typo, first one should read `IHos

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/#review61087 --- Ship it! Ship It! - Zameer Manji On Nov. 12, 2014, 10:58 a.m., B

Review Request 27934: Remove non-fixed tickets from CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27934/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs: AURORA-711

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

> On Nov. 12, 2014, 9 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java, > > line 97 > > > > > > s/org.apache.aurora.scheduler.// Fixed. - Bill

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/ --- (Updated Nov. 12, 2014, 10:38 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/ --- (Updated Nov. 12, 2014, 10:38 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 27934: Remove non-fixed tickets from CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27934/#review61101 --- Ship it! Ship It! - Joshua Cohen On Nov. 12, 2014, 10:35 p.m., B

Re: Review Request 27934: Remove non-fixed tickets from CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27934/#review61104 --- Master (ea43999) is red with this patch. ./build-support/jenkins/b

Re: Review Request 27934: Remove non-fixed tickets from CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27934/#review61105 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 12, 2014, 10:35 p.

Review Request 27935: Fix coverage epsilon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27935/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository: auror

Re: Review Request 27935: Fix coverage epsilon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27935/#review61107 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 12, 2014, 10:50 p.

Re: Review Request 27935: Fix coverage epsilon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27935/#review61108 --- Ship it! Ship It! - Bill Farner On Nov. 12, 2014, 10:50 p.m., Jo

Re: Review Request 27935: Fix coverage epsilon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27935/#review61112 --- Ship it! Master (ea43999) is green with this patch. ./build-suppo

Re: Review Request 27935: Fix coverage epsilon.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27935/#review61113 --- Ship it! This is now on master ``` $ git log -1 origin/master --abb

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/#review61124 --- @ReviewBot retry - Bill Farner On Nov. 12, 2014, 10:38 p.m., Bill

Re: Review Request 27941: Fix review bot to use correct latest diff time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27941/ --- (Updated Nov. 12, 2014, 11:54 p.m.) Review request for Aurora and Joshua Cohen.

Review Request 27941: Fix review bot to use correct latest diff time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27941/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --

Review Request 27942: Don't fail builds on exceeded coverage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27942/ --- Review request for Aurora. Repository: aurora Description --- Don't fail

Re: Review Request 27942: Don't fail builds on exceeded coverage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27942/#review61136 --- Ship it! Ship It! - Joshua Cohen On Nov. 13, 2014, 12:01 a.m., Z

Re: Review Request 27942: Don't fail builds on exceeded coverage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27942/ --- (Updated Nov. 12, 2014, 4:01 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 27941: Fix review bot to use correct latest diff time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27941/#review61137 --- Ship it! Ship It! - Joshua Cohen On Nov. 12, 2014, 11:54 p.m., B

Re: Review Request 27942: Don't fail builds on exceeded coverage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27942/#review61138 --- Not sure what's up with this diff, but i don't think we want this to

Re: Review Request 27902: Store host attributes alongside offers to reduce number of lookups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27902/#review61139 --- Ship it! Master (0077a0c) is green with this patch. ./build-suppo

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27698/#review61142 --- Ship it! Ship It! - Bill Farner On Nov. 7, 2014, 9:17 p.m., Davi

Re: Review Request 27942: Don't fail builds on exceeded coverage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27942/#review61144 --- Ship it! Master (b80e69c) is green with this patch. ./build-suppo

Re: Review Request 27848: Add friendly error message to the client when lock is held.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review61120 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27698/#review61155 --- src/main/python/apache/aurora/client/api/scheduler_client.py

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

> On Nov. 13, 2014, 12:46 a.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, line 74 > > > > > > Suggestion (other reviewers feel free to chime in here): instead of > > calling

Re: Review Request 27848: Add friendly error message to the client when lock is held.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/ --- (Updated Nov. 13, 2014, 1:48 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 27947: Setting the max thread limit on AsyncEventBus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27947/#review61178 --- src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.

Review Request 27949: Don't fail the build when exceeding coverage thresholds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27949/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 27852: Ensure run verb returns an exit code.

> On Nov. 11, 2014, 10:55 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/cli/task.py, line 72 > > > > > > Should we just make this the default behavior? There's at least 31 > > locations that do thi

Re: Review Request 27947: Setting the max thread limit on AsyncEventBus.

> On Nov. 13, 2014, 1:35 a.m., Aurora ReviewBot wrote: > > %s > > > > However, it appears that it might lack test coverage. > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" Oy, i really should not work on review bot when i'm tired. - Bill ---

Re: Review Request 27947: Setting the max thread limit on AsyncEventBus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27947/#review61168 --- %s However, it appears that it might lack test coverage. I will re

Review Request 27947: Setting the max thread limit on AsyncEventBus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27947/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-926 https://issues.

Re: Review Request 27954: Fix bad review text in review bot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27954/#review61182 --- Ship it! Master (6950d50) is green with this patch. ./build-suppo

Review Request 27954: Fix bad review text in review bot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27954/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti

Re: Review Request 27949: Don't fail the build when exceeding coverage thresholds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27949/#review61166 --- Ship it! This is now on master: ``` $ git log -1 origin/master --ab

Re: Review Request 27848: Add friendly error message to the client when lock is held.

> On Nov. 13, 2014, 12:36 a.m., Kevin Sweeney wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 331 > > > > > > weird wrapping - consider wrapping the whole statement in parens so > > there is one cond

Re: Review Request 27848: Add friendly error message to the client when lock is held.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review61175 --- This patch does not apply cleanly on master (6950d50), do you need t

Re: Review Request 27848: Add friendly error message to the client when lock is held.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/ --- (Updated Nov. 13, 2014, 1:45 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 27947: Setting the max thread limit on AsyncEventBus.

> On Nov. 13, 2014, 2:07 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java, > > line 93 > > > > > > Given that we're moving from an effective "same thread executor" to

Re: Review Request 27947: Setting the max thread limit on AsyncEventBus.

> On Nov. 13, 2014, 2:07 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java, > > line 93 > > > > > > Given that we're moving from an effective "same thread executor" to

Re: Review Request 27848: Add friendly error message to the client when lock is held.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review61201 --- Ship it! lgtm once bot agrees, please follow-up with a ticket for f

Re: Review Request 27954: Fix bad review text in review bot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27954/#review61204 --- Ship it! build-support/jenkins/review_feedback.py

Re: Review Request 27947: Setting the max thread limit on AsyncEventBus.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27947/#review61203 --- src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.