Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated March 3, 2015, 3:21 p.m.) Review request for Aurora, Jay Buffington

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated March 3, 2015, 3:23 p.m.) Review request for Aurora, Jay Buffington

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74965 --- Master (4cca6a6) is red with this patch.

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-03-03 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74958 --- Is there anything else here? Is this ready to be merged? - Steve

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/#review74983 --- Ship it! src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Bill Farner
On March 3, 2015, 3:43 p.m., Aurora ReviewBot wrote: Master (4cca6a6) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.executor.bin.gc_executor_entry_point . SUCCESS

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-03-03 Thread Brian Wickman
On March 3, 2015, 3:26 p.m., Steve Niemitz wrote: Is there anything else here? Is this ready to be merged? Yup, on it. - Brian --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review75000 --- @ReviewBot retry - Bill Farner On March 3, 2015, 3:23 p.m.,

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/#review74994 --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review75003 --- Master (782e3e7) is red with this patch.

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Bill Farner
On March 3, 2015, 6:28 p.m., Aurora ReviewBot wrote: Master (782e3e7) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.update . SUCCESS

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review75005 --- @ReviewBot retry - Bill Farner On March 3, 2015, 3:23 p.m.,

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Bill Farner
On March 3, 2015, 6:10 p.m., Maxim Khutornenko wrote: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 130 https://reviews.apache.org/r/31659/diff/1/?file=882656#file882656line130 Not directly related but adding --batch-size=2 would make it even faster. This crossed my

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Bill Farner
On March 3, 2015, 6:10 p.m., Maxim Khutornenko wrote: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 130 https://reviews.apache.org/r/31659/diff/1/?file=882656#file882656line130 Not directly related but adding --batch-size=2 would make it even faster. Bill Farner

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/#review75049 --- Ship it! Master (782e3e7) is green with this patch.

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review75050 --- Ship it! Master (782e3e7) is green with this patch.

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Bill Farner
On March 3, 2015, 5:23 p.m., Maxim Khutornenko wrote: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 64 https://reviews.apache.org/r/31659/diff/1/?file=882656#file882656line64 Is this statement still accurate now that ssh is dropped from the command? It is not!

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-03-03 Thread Brian Wickman
On March 1, 2015, 9:03 p.m., Joe Smith wrote: src/main/python/apache/aurora/tools/thermos.py, line 1 https://reviews.apache.org/r/31559/diff/5/?file=881006#file881006line1 Add apache copyright stanzas to these files? done On March 1, 2015, 9:03 p.m., Joe Smith wrote:

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/#review75045 --- Ship it! Ship It! - Maxim Khutornenko On March 3, 2015, 8:53

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/#review75048 --- Ship it! Just tried this out locally. So much faster, thanks for

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/ --- (Updated March 3, 2015, 8:53 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/ --- (Updated March 3, 2015, 8:55 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-03-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/ --- (Updated March 3, 2015, 10:14 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Zameer Manji
On March 3, 2015, 3:21 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, line 211 https://reviews.apache.org/r/31710/diff/1/?file=883801#file883801line211 For the calls like this you can do

Re: Review Request 31716: Add an end-to-end test for scheduler-driven job updates.

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31716/#review75121 --- Ship it! Master (270faf7) is green with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-03-03 Thread Brian Wickman
On March 1, 2015, 8:47 p.m., Joe Smith wrote: src/main/python/apache/aurora/executor/common/resource_manager.py, line 96 https://reviews.apache.org/r/31451/diff/6/?file=880982#file880982line96 Why is this moving to kwargs? (My normal assumption is to stick with actual arguments)

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-03-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review75074 --- Ship it! Ship It! - Joe Smith On March 3, 2015, 2:58 p.m.,

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review75078 --- Ship it! Master (2bf03dc) is green with this patch.

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31710/#review75100 --- Ship it! Master (c0b3701) is green with this patch.

Review Request 31714: Suppress empty RPC response logging from the client.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31714/ --- Review request for Aurora and Zameer Manji. Repository: aurora Description

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-03-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/#review75063 --- Ship it! src/main/python/apache/thermos/cli/common.py

Re: Review Request 31653: docs: Add info on granting production quota.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31653/#review75098 --- Ship it! Ship It! - Bill Farner On March 3, 2015, 12:58 a.m.,

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-03-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- (Updated March 3, 2015, 10:58 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31710/#review75087 --- Master (c0b3701) is red with this patch.

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/#review75090 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2015, 12:55 p.m.,

Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31652/#review75096 --- Ship it! Nice!

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Bill Farner
On March 3, 2015, 11:48 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/update.py, line 302 https://reviews.apache.org/r/31710/diff/1/?file=883800#file883800line302 You may want to extract an internal method to do this, e.g.: ``` def

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31710/ --- (Updated March 4, 2015, 12:19 a.m.) Review request for Aurora and Maxim

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-03-03 Thread Joe Smith
On March 1, 2015, 12:47 p.m., Joe Smith wrote: src/test/python/apache/thermos/observer/test_detector.py, line 76 https://reviews.apache.org/r/31451/diff/6/?file=881004#file881004line76 I think it's worthy to make this (and others) explicitly: assert on_active.mock_calls

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/#review75065 --- Master (2bf03dc) is red with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-03-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review75082 --- Ship it! Ship It! - Zameer Manji On March 3, 2015, 2:58 p.m.,

Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31710/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1165 and

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31710/ --- (Updated March 3, 2015, 11:44 p.m.) Review request for Aurora and Maxim

Re: Review Request 31646: Moving GroupKey to scheduler.base.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31646/#review75093 --- src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java

Re: Review Request 31646: Moving GroupKey to scheduler.base.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31646/#review75095 --- Ship it! Ship It! - Bill Farner On March 3, 2015, 12:07 a.m.,

Re: Review Request 31714: Suppress empty RPC response logging from the client.

2015-03-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31714/#review75123 --- Ship it! Ship It! - Zameer Manji On March 3, 2015, 4:59 p.m.,

Re: Review Request 31714: Suppress empty RPC response logging from the client.

2015-03-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31714/#review75126 --- Master (270faf7) is green with this patch.

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-03-03 Thread Brian Wickman
On March 3, 2015, 10:31 p.m., Zameer Manji wrote: src/main/python/apache/thermos/cli/common.py, line 101 https://reviews.apache.org/r/31559/diff/6/?file=883670#file883670line101 shouldn't closing the checkpoint and killing the task runner be in a finally clause? No, it's ^C that

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31710/#review75083 --- src/test/python/apache/aurora/client/cli/test_supdate.py

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Bill Farner
On March 3, 2015, 11:21 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, line 211 https://reviews.apache.org/r/31710/diff/1/?file=883801#file883801line211 For the calls like this you can do

Re: Review Request 31710: Fix query and timestamp display when running beta-update status.

2015-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31710/#review75089 --- Ship it! src/main/python/apache/aurora/client/cli/update.py

Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-03 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31652/#review75099 --- Ship it! Ship It! - Zameer Manji On March 2, 2015, 4:58 p.m.,

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review75103 --- Ship it! Ship It! - Bill Farner On March 2, 2015, 11:40 p.m.,

Review Request 31716: Add an end-to-end test for scheduler-driven job updates.

2015-03-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31716/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1157

Re: Review Request 31716: Add an end-to-end test for scheduler-driven job updates.

2015-03-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31716/#review75141 --- src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh