Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-25 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/
---

(Updated Feb. 25, 2014, 9:33 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-135
https://issues.apache.org/jira/browse/AURORA-135


Repository: aurora


Description
---

I've also done some tidying of the storage interfaces here, which make code 
simpler in several places:

- Introduced LockType in ReadWriteLockManager to make parameterized lock/unlock 
possible
- Introduced StorageOperation as a base interface for Work and MutateWork.
- Moved Storage#snapshot() to NonVolatileStorage


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 
  src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
a02991453def78bbf6a00c8946d2079fdc4539e9 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
9cc1d1e871bc34fd244565a692215b9657e164a8 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
fd1be9f4e31aaebb724ad69d7ddb925fd30aee21 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
30d77cc86fba569cfaa35ae69d97726072660aed 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
e6a32b8ed8f42a8ce7c4ffe43a796fd0cac5eacc 
  
src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java 
5dc7df18325f9a637ef9009197555e8d53c3b498 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
1f02e84f8f2e78b47ccbb41a56f95ea87b5882e5 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 f0f0e39c40758cd40c981bcbde1e59f2e7a99e3f 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d 

Diff: https://reviews.apache.org/r/18240/diff/


Testing
---

./gradlew build


Thanks,

Bill Farner

Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-25 Thread Bill Farner 


> On Feb. 25, 2014, 8:35 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java,
> >  line 113
> > 
> >
> > reads better statically imported (here and elsewhere).
> 
> Bill Farner wrote:
> Done.

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/#review35454
---


On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18240/
> ---
> 
> (Updated Feb. 18, 2014, 9:55 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-135
> https://issues.apache.org/jira/browse/AURORA-135
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some tidying of the storage interfaces here, which make code 
> simpler in several places:
> 
> - Introduced LockType in ReadWriteLockManager to make parameterized 
> lock/unlock possible
> - Introduced StorageOperation as a base interface for Work and MutateWork.
> - Moved Storage#snapshot() to NonVolatileStorage
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> a02991453def78bbf6a00c8946d2079fdc4539e9 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 9cc1d1e871bc34fd244565a692215b9657e164a8 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 36e4082acceb3045ef92a5957b500e407bfc1247 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 30d77cc86fba569cfaa35ae69d97726072660aed 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f7e34d1cf379168be6fffab0faaf450151a10bc 
>   
> src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java
>  5dc7df18325f9a637ef9009197555e8d53c3b498 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> f708ab3c2fa5d50b084e037f9cc0cb998935120a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  656e44eb51508c7ab05af8b91e9dcec216d48984 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d 
> 
> Diff: https://reviews.apache.org/r/18240/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-25 Thread Bill Farner 


> On Feb. 25, 2014, 8:35 p.m., Kevin Sweeney wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java,
> >  line 113
> > 
> >
> > reads better statically imported (here and elsewhere).

Done.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/#review35454
---


On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18240/
> ---
> 
> (Updated Feb. 18, 2014, 9:55 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-135
> https://issues.apache.org/jira/browse/AURORA-135
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some tidying of the storage interfaces here, which make code 
> simpler in several places:
> 
> - Introduced LockType in ReadWriteLockManager to make parameterized 
> lock/unlock possible
> - Introduced StorageOperation as a base interface for Work and MutateWork.
> - Moved Storage#snapshot() to NonVolatileStorage
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> a02991453def78bbf6a00c8946d2079fdc4539e9 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 9cc1d1e871bc34fd244565a692215b9657e164a8 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 36e4082acceb3045ef92a5957b500e407bfc1247 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 30d77cc86fba569cfaa35ae69d97726072660aed 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f7e34d1cf379168be6fffab0faaf450151a10bc 
>   
> src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java
>  5dc7df18325f9a637ef9009197555e8d53c3b498 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> f708ab3c2fa5d50b084e037f9cc0cb998935120a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  656e44eb51508c7ab05af8b91e9dcec216d48984 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d 
> 
> Diff: https://reviews.apache.org/r/18240/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-25 Thread Bill Farner 


> On Feb. 19, 2014, 4:33 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/Storage.java, line 69
> > 
> >
> > typo

Fixed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/#review34866
---


On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18240/
> ---
> 
> (Updated Feb. 18, 2014, 9:55 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-135
> https://issues.apache.org/jira/browse/AURORA-135
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some tidying of the storage interfaces here, which make code 
> simpler in several places:
> 
> - Introduced LockType in ReadWriteLockManager to make parameterized 
> lock/unlock possible
> - Introduced StorageOperation as a base interface for Work and MutateWork.
> - Moved Storage#snapshot() to NonVolatileStorage
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> a02991453def78bbf6a00c8946d2079fdc4539e9 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 9cc1d1e871bc34fd244565a692215b9657e164a8 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 36e4082acceb3045ef92a5957b500e407bfc1247 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 30d77cc86fba569cfaa35ae69d97726072660aed 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f7e34d1cf379168be6fffab0faaf450151a10bc 
>   
> src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java
>  5dc7df18325f9a637ef9009197555e8d53c3b498 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> f708ab3c2fa5d50b084e037f9cc0cb998935120a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  656e44eb51508c7ab05af8b91e9dcec216d48984 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d 
> 
> Diff: https://reviews.apache.org/r/18240/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-25 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/#review35454
---

Ship it!


Ship It!


src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java


reads better statically imported (here and elsewhere).


- Kevin Sweeney


On Feb. 18, 2014, 1:55 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18240/
> ---
> 
> (Updated Feb. 18, 2014, 1:55 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-135
> https://issues.apache.org/jira/browse/AURORA-135
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some tidying of the storage interfaces here, which make code 
> simpler in several places:
> 
> - Introduced LockType in ReadWriteLockManager to make parameterized 
> lock/unlock possible
> - Introduced StorageOperation as a base interface for Work and MutateWork.
> - Moved Storage#snapshot() to NonVolatileStorage
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> a02991453def78bbf6a00c8946d2079fdc4539e9 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 9cc1d1e871bc34fd244565a692215b9657e164a8 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 36e4082acceb3045ef92a5957b500e407bfc1247 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 30d77cc86fba569cfaa35ae69d97726072660aed 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f7e34d1cf379168be6fffab0faaf450151a10bc 
>   
> src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java
>  5dc7df18325f9a637ef9009197555e8d53c3b498 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> f708ab3c2fa5d50b084e037f9cc0cb998935120a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  656e44eb51508c7ab05af8b91e9dcec216d48984 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d 
> 
> Diff: https://reviews.apache.org/r/18240/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-20 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/#review35078
---


Ping?  Kevin — waiting on a review from you.

- Bill Farner


On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18240/
> ---
> 
> (Updated Feb. 18, 2014, 9:55 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-135
> https://issues.apache.org/jira/browse/AURORA-135
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some tidying of the storage interfaces here, which make code 
> simpler in several places:
> 
> - Introduced LockType in ReadWriteLockManager to make parameterized 
> lock/unlock possible
> - Introduced StorageOperation as a base interface for Work and MutateWork.
> - Moved Storage#snapshot() to NonVolatileStorage
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> a02991453def78bbf6a00c8946d2079fdc4539e9 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 9cc1d1e871bc34fd244565a692215b9657e164a8 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 36e4082acceb3045ef92a5957b500e407bfc1247 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 30d77cc86fba569cfaa35ae69d97726072660aed 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f7e34d1cf379168be6fffab0faaf450151a10bc 
>   
> src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java
>  5dc7df18325f9a637ef9009197555e8d53c3b498 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> f708ab3c2fa5d50b084e037f9cc0cb998935120a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  656e44eb51508c7ab05af8b91e9dcec216d48984 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d 
> 
> Diff: https://reviews.apache.org/r/18240/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-19 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18240/#review34866
---

Ship it!



src/main/java/org/apache/aurora/scheduler/storage/Storage.java


typo


- Maxim Khutornenko


On Feb. 18, 2014, 9:55 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18240/
> ---
> 
> (Updated Feb. 18, 2014, 9:55 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-135
> https://issues.apache.org/jira/browse/AURORA-135
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> I've also done some tidying of the storage interfaces here, which make code 
> simpler in several places:
> 
> - Introduced LockType in ReadWriteLockManager to make parameterized 
> lock/unlock possible
> - Introduced StorageOperation as a base interface for Work and MutateWork.
> - Moved Storage#snapshot() to NonVolatileStorage
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> ef7d2ce30a24bad544546a048ee6f6c6ce8681f5 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> a02991453def78bbf6a00c8946d2079fdc4539e9 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 9cc1d1e871bc34fd244565a692215b9657e164a8 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 36e4082acceb3045ef92a5957b500e407bfc1247 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 30d77cc86fba569cfaa35ae69d97726072660aed 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  7f7e34d1cf379168be6fffab0faaf450151a10bc 
>   
> src/test/java/org/apache/aurora/scheduler/storage/ReadWriteLockManagerTest.java
>  5dc7df18325f9a637ef9009197555e8d53c3b498 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> f708ab3c2fa5d50b084e037f9cc0cb998935120a 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  656e44eb51508c7ab05af8b91e9dcec216d48984 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 2254574a91c5a7bf2ddc7d8a7d31c3e4e360486d 
> 
> Diff: https://reviews.apache.org/r/18240/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>