Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 28, 2014, 11:01 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35865 --- Ship it! Ship It! - Bill Farner On Feb. 28, 2014, 10:53 p.m., Ma

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Bill Farner
> On Feb. 28, 2014, 10:53 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, > > line 80 > > > > > > That would create an empty Set in case jobkey is missing >

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 28, 2014, 10:53 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35861 --- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35836 --- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 28, 2014, 1:18 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35738 --- src/main/java/org/apache/aurora/scheduler/base/Query.java

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35729 --- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35723 --- src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Bill Farner
> On Feb. 27, 2014, 11:19 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java, > > line 76 > > > > > > I know why you're doing this here, but mind keeping it out for now

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35722 --- src/main/java/org/apache/aurora/scheduler/base/Query.java

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- (Updated Feb. 27, 2014, 4:42 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-27 Thread Maxim Khutornenko
> On Feb. 27, 2014, 1:38 a.m., Kevin Sweeney wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 364 > > > > > > Mind adding a ticket number (filing one if it doesn't exist)? Added ticket tracking remova

Re: Review Request 18526: Add support for slaveHosts set in TaskQuery.

2014-02-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/#review35589 --- Ship it! LGTM mod TODO->ticket mapping src/main/thrift/org/apache