Re: Review Request 22457: Improve aurora "job diff" command.

> On Oct. 24, 2014, 3:58 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 311 > > > > > > This is no longer true. The `populated` field reprsents a single > > TaskConfig now.

Re: Review Request 22457: Improve aurora "job diff" command.

> On Oct. 24, 2014, 11:58 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 311 > > > > > > This is no longer true. The `populated` field reprsents a single > > TaskConfig now.

Re: Review Request 22457: Improve aurora "job diff" command.

> On Oct. 24, 2014, 3:58 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 311 > > > > > > This is no longer true. The `populated` field reprsents a single > > TaskConfig now.

Re: Review Request 22457: Improve aurora "job diff" command.

> On Oct. 24, 2014, 11:58 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, line 311 > > > > > > This is no longer true. The `populated` field reprsents a single > > TaskConfig now.

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review58294 --- Master (53f4e73) is red with this patch. ./build-support/jenkins/b

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review58280 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated Oct. 24, 2014, 10:50 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review58220 --- This patch does not apply cleanly on master (53f4e73), do you need t

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated Sept. 9, 2014, 10:07 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 22457: Improve aurora "job diff" command.

> On July 29, 2014, 7:36 p.m., Bill Farner wrote: > > Mark - looks like this was committed, reverted, then re-committed. If it's > > now in, can you please close the review? Sadly no. It was committed, reverted, recommitted, reverted, rerecommitted, rerereverted. Why it fails in the hudson

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review49046 --- Mark - looks like this was committed, reverted, then re-committed.

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated July 17, 2014, 10:09 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated July 16, 2014, 3:26 p.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review47783 --- Ship it! Ship It! - Brian Wickman On June 27, 2014, 2:41 p.m., M

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review47423 --- It's been a week since the last time I pinged this review, and still

Re: Review Request 22457: Improve aurora "job diff" command.

Brian, please, can I get a review on this? It's been dragging on for weeks! On Mon, Jun 30, 2014 at 8:06 AM, Mark Chu-Carroll wrote: > wickman, ping? > > > On Fri, Jun 27, 2014 at 11:25 AM, Maxim Khutornenko > wrote: > >>This is an automatically generated e-mail. To reply, visit: >> http

Re: Review Request 22457: Improve aurora "job diff" command.

wickman, ping? On Fri, Jun 27, 2014 at 11:25 AM, Maxim Khutornenko wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22457/ > > Ship it! > > Ship It! > > > - Maxim Khutornenko > > On June 27th, 2014, 2:41 p.m. UTC, Mark Chu-Carroll wrote: >

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review46866 --- Ship it! Ship It! - Maxim Khutornenko On June 27, 2014, 2:41 p.m

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated June 27, 2014, 10:41 a.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review46747 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated June 26, 2014, 7:42 a.m.) Review request for Aurora, Maxim Khutornenko

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review46714 --- Mark, can you replace me with Maxim on people line? This lgtm, but i

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated June 25, 2014, 9:16 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 9:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated June 18, 2014, 10:59 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 5:45 p.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/client/cli/jobs.py, lines 181-182 > > > > > > I don't think it's enough to json-serialize a thrift task. This is > > bound to s

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 16, 2014, 5:25 p.m., David McLaughlin wrote: > > src/main/python/apache/aurora/client/cli/json_tree_diff.py, line 56 > > > > > > Not a big deal given how rare it would occur, but you're using a > > delimiter

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review45835 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review45834 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review45832 --- src/main/python/apache/aurora/client/cli/json_tree_diff.py

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review45822 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review45808 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review45749 --- ping? - Mark Chu-Carroll On June 13, 2014, 4:22 p.m., Mark Chu-Ca

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated June 13, 2014, 4:22 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review45649 --- src/main/python/apache/aurora/client/cli/json_tree_diff.py

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 11, 2014, 8:18 a.m., Maxim Khutornenko wrote: > > Given this new diff routine lives in cli, I figure the updater is out of > > luck again? I was hoping to have a single diff engine shared between cli > > and updater to finally have a consistent diff story. > > Mark Chu-Carroll wrote:

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review45635 --- cool, lgtm src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 22457: Improve aurora "job diff" command.

> On June 11, 2014, 11:18 a.m., Maxim Khutornenko wrote: > > Given this new diff routine lives in cli, I figure the updater is out of > > luck again? I was hoping to have a single diff engine shared between cli > > and updater to finally have a consistent diff story. I'm happy to move it out.

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review45382 --- Given this new diff routine lives in cli, I figure the updater is ou

Re: Review Request 22457: Improve aurora "job diff" command.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/ --- (Updated June 11, 2014, 11 a.m.) Review request for Aurora, David McLaughlin an