Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-07-01 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review47149
---

Ship it!


Ship It!

- Brian Wickman


On July 1, 2014, 9:08 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated July 1, 2014, 9:08 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> c55c9fee230002ef749965eb559ee5b309ee143b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
>   src/test/python/apache/aurora/client/cli/util.py 
> a2c9d09c58243250baefab2ee51f5ea3b411 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-07-01 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/
---

(Updated July 1, 2014, 5:08 p.m.)


Review request for Aurora, Kevin Sweeney and Brian Wickman.


Changes
---

Fix glitchy print statement.


Bugs: aurora-544 and aurora-545
https://issues.apache.org/jira/browse/aurora-544
https://issues.apache.org/jira/browse/aurora-545


Repository: aurora


Description
---

Add configuration plugins to default aurora client.

- Add a plugin to allow users to set logging levels.
- Add a plugin to allow users to configure whether or not unknown exceptions get
  caught or revealed.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
827bbb88230f4e536500710695cb92bf39da3447 
  src/main/python/apache/aurora/client/cli/standalone_client.py 
5d1a4a53a8b36b6dd072485260d490435da6968d 
  src/test/python/apache/aurora/client/cli/test_config_noun.py 
c55c9fee230002ef749965eb559ee5b309ee143b 
  src/test/python/apache/aurora/client/cli/test_create.py 
b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
ce85318727dcaf22a696d05f99c49b5e953bd3ca 
  src/test/python/apache/aurora/client/cli/util.py 
a2c9d09c58243250baefab2ee51f5ea3b411 

Diff: https://reviews.apache.org/r/22839/diff/


Testing
---

- Added new test.
- Ran all unit tests.
- Did manual command-line testing.


Thanks,

Mark Chu-Carroll

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-07-01 Thread Mark Chu-Carroll 


> On July 1, 2014, 4:55 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/cli/standalone_client.py, line 71
> > 
> >
> > i still don't see --logging-level=

This is changed in my workspace... not sure what reviewboard is up to. I'll try 
uploading again.


> On July 1, 2014, 4:55 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/cli/standalone_client.py, line 79
> > 
> >
> > I don't think you want logging.ERROR here?

Doh. That was a stupid mistake on my part.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review47144
---


On June 30, 2014, 4 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 30, 2014, 4 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> c55c9fee230002ef749965eb559ee5b309ee143b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
>   src/test/python/apache/aurora/client/cli/util.py 
> a2c9d09c58243250baefab2ee51f5ea3b411 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-07-01 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review47144
---



src/main/python/apache/aurora/client/cli/standalone_client.py


i still don't see --logging-level=



src/main/python/apache/aurora/client/cli/standalone_client.py


I don't think you want logging.ERROR here?


- Brian Wickman


On June 30, 2014, 8 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 30, 2014, 8 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> c55c9fee230002ef749965eb559ee5b309ee143b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
>   src/test/python/apache/aurora/client/cli/util.py 
> a2c9d09c58243250baefab2ee51f5ea3b411 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-07-01 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review47138
---


Ping!!

Come on guys, this is getting silly!


- Mark Chu-Carroll


On June 30, 2014, 4 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 30, 2014, 4 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> c55c9fee230002ef749965eb559ee5b309ee143b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
>   src/test/python/apache/aurora/client/cli/util.py 
> a2c9d09c58243250baefab2ee51f5ea3b411 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-30 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/
---

(Updated June 30, 2014, 4 p.m.)


Review request for Aurora, Kevin Sweeney and Brian Wickman.


Changes
---

Modified "people" list, since David is away.


Bugs: aurora-544 and aurora-545
https://issues.apache.org/jira/browse/aurora-544
https://issues.apache.org/jira/browse/aurora-545


Repository: aurora


Description
---

Add configuration plugins to default aurora client.

- Add a plugin to allow users to set logging levels.
- Add a plugin to allow users to configure whether or not unknown exceptions get
  caught or revealed.


Diffs
-

  src/main/python/apache/aurora/client/cli/__init__.py 
827bbb88230f4e536500710695cb92bf39da3447 
  src/main/python/apache/aurora/client/cli/standalone_client.py 
5d1a4a53a8b36b6dd072485260d490435da6968d 
  src/test/python/apache/aurora/client/cli/test_config_noun.py 
c55c9fee230002ef749965eb559ee5b309ee143b 
  src/test/python/apache/aurora/client/cli/test_create.py 
b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
ce85318727dcaf22a696d05f99c49b5e953bd3ca 
  src/test/python/apache/aurora/client/cli/util.py 
a2c9d09c58243250baefab2ee51f5ea3b411 

Diff: https://reviews.apache.org/r/22839/diff/


Testing
---

- Added new test.
- Ran all unit tests.
- Did manual command-line testing.


Thanks,

Mark Chu-Carroll

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-30 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46992
---


ping?

- Mark Chu-Carroll


On June 27, 2014, 11:27 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 27, 2014, 11:27 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> c55c9fee230002ef749965eb559ee5b309ee143b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
>   src/test/python/apache/aurora/client/cli/util.py 
> a2c9d09c58243250baefab2ee51f5ea3b411 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-27 Thread Mark Chu-Carroll 


> On June 27, 2014, 11:14 a.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/standalone_client.py, line 69
> > 
> >
> > No. We don't want to catch an invalid parameter like 
> > "--logging-level-max".
> 
> Brian Wickman wrote:
> but you won't, because you don't have "--" in there.

Oh hell, I focused on the wrong part of that. D'oh.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46778
---


On June 27, 2014, 11:27 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 27, 2014, 11:27 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> c55c9fee230002ef749965eb559ee5b309ee143b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
>   src/test/python/apache/aurora/client/cli/util.py 
> a2c9d09c58243250baefab2ee51f5ea3b411 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-27 Thread Brian Wickman 


> On June 27, 2014, 3:14 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/standalone_client.py, line 69
> > 
> >
> > No. We don't want to catch an invalid parameter like 
> > "--logging-level-max".

but you won't, because you don't have "--" in there.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46778
---


On June 27, 2014, 3:27 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 27, 2014, 3:27 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> c55c9fee230002ef749965eb559ee5b309ee143b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
>   src/test/python/apache/aurora/client/cli/util.py 
> a2c9d09c58243250baefab2ee51f5ea3b411 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-27 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/
---

(Updated June 27, 2014, 11:27 a.m.)


Review request for Aurora, David McLaughlin and Brian Wickman.


Changes
---

address reviews.


Bugs: aurora-544 and aurora-545
https://issues.apache.org/jira/browse/aurora-544
https://issues.apache.org/jira/browse/aurora-545


Repository: aurora


Description
---

Add configuration plugins to default aurora client.

- Add a plugin to allow users to set logging levels.
- Add a plugin to allow users to configure whether or not unknown exceptions get
  caught or revealed.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
827bbb88230f4e536500710695cb92bf39da3447 
  src/main/python/apache/aurora/client/cli/standalone_client.py 
5d1a4a53a8b36b6dd072485260d490435da6968d 
  src/test/python/apache/aurora/client/cli/test_config_noun.py 
c55c9fee230002ef749965eb559ee5b309ee143b 
  src/test/python/apache/aurora/client/cli/test_create.py 
b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
ce85318727dcaf22a696d05f99c49b5e953bd3ca 
  src/test/python/apache/aurora/client/cli/util.py 
a2c9d09c58243250baefab2ee51f5ea3b411 

Diff: https://reviews.apache.org/r/22839/diff/


Testing
---

- Added new test.
- Ran all unit tests.
- Did manual command-line testing.


Thanks,

Mark Chu-Carroll

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-27 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46778
---



src/main/python/apache/aurora/client/cli/standalone_client.py


No. We don't want to catch an invalid parameter like "--logging-level-max".


- Mark Chu-Carroll


On June 25, 2014, 12:38 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 25, 2014, 12:38 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> c55c9fee230002ef749965eb559ee5b309ee143b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
>   src/test/python/apache/aurora/client/cli/util.py 
> a2c9d09c58243250baefab2ee51f5ea3b411 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-26 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46756
---



src/main/python/apache/aurora/client/cli/standalone_client.py


should this be startswith("--logging-level")?



src/main/python/apache/aurora/client/cli/standalone_client.py


len(arg_bits)



src/main/python/apache/aurora/client/cli/standalone_client.py


wrap in try/except ValueError



src/test/python/apache/aurora/client/cli/test_config_noun.py


kill


- Brian Wickman


On June 25, 2014, 4:38 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 25, 2014, 4:38 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> c55c9fee230002ef749965eb559ee5b309ee143b 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
>   src/test/python/apache/aurora/client/cli/util.py 
> a2c9d09c58243250baefab2ee51f5ea3b411 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-25 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/
---

(Updated June 25, 2014, 12:38 p.m.)


Review request for Aurora, David McLaughlin and Brian Wickman.


Changes
---

Refactored to address review comments.


Bugs: aurora-544 and aurora-545
https://issues.apache.org/jira/browse/aurora-544
https://issues.apache.org/jira/browse/aurora-545


Repository: aurora


Description
---

Add configuration plugins to default aurora client.

- Add a plugin to allow users to set logging levels.
- Add a plugin to allow users to configure whether or not unknown exceptions get
  caught or revealed.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
827bbb88230f4e536500710695cb92bf39da3447 
  src/main/python/apache/aurora/client/cli/standalone_client.py 
5d1a4a53a8b36b6dd072485260d490435da6968d 
  src/test/python/apache/aurora/client/cli/test_config_noun.py 
c55c9fee230002ef749965eb559ee5b309ee143b 
  src/test/python/apache/aurora/client/cli/test_create.py 
b9313be657ebaf9c79a7695b75abe2d90a7d75dd 
  src/test/python/apache/aurora/client/cli/test_plugins.py 
ce85318727dcaf22a696d05f99c49b5e953bd3ca 
  src/test/python/apache/aurora/client/cli/util.py 
a2c9d09c58243250baefab2ee51f5ea3b411 

Diff: https://reviews.apache.org/r/22839/diff/


Testing
---

- Added new test.
- Ran all unit tests.
- Did manual command-line testing.


Thanks,

Mark Chu-Carroll

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Mark Chu-Carroll 


> On June 20, 2014, 5:30 p.m., Brian Wickman wrote:
> > not a big fan of globals here.  can you instead annotate the context with 
> > the exception and in post-dispatch have the plugin print it out if 
> > --reveal-errors is set?
> 
> Mark Chu-Carroll wrote:
> I'm not a big fan of globals either, but I'm concerned about depending on 
> the context in a, well, context where it's possible that the context is 
> messed up or doesn't exist. 
>
> 
> Brian Wickman wrote:
> the only exceptions that can be revealed here are from within _execute() 
> right?  at this point, why not just always print the stack trace?
> 
> Mark Chu-Carroll wrote:
> Dammit, the constant sledgehammering down the hill from me is driving me 
> *insane*. I didn't mean to hit "publish" yet.
> 
> If you look at the context where the reveal-errors flag is checked, there 
> is no Context object available.
> 
> I can wrap the global in a class, like one of the registries. Would that 
> be a decent compromise?
>
> 
> Brian Wickman wrote:
> i also don't see a big deal with adding a set_exception() method to the 
> Context base class and having this set by _execute or execute or both.
> 
> Brian Wickman wrote:
> hmm, then it sounds like adding the --reveal-errors flag to a plugin 
> doesn't really make sense, since it's not really a plugin.  it's a property 
> of the framework itself.  should this be done with an environment variable 
> instead?

It's a property of the framework, but a command-line option to control it 
isn't. You could build a command-line around the noun/verb framework that 
didn't do it with a command-line option.

I'm very strongly opposed to doing an environment variable. Every time I've 
used an environment variable as a flag rather than passing a parameter, I've 
lived to regret it. 


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46325
---


On June 20, 2014, 4:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 20, 2014, 4:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Brian Wickman 


> On June 20, 2014, 9:30 p.m., Brian Wickman wrote:
> > not a big fan of globals here.  can you instead annotate the context with 
> > the exception and in post-dispatch have the plugin print it out if 
> > --reveal-errors is set?
> 
> Mark Chu-Carroll wrote:
> I'm not a big fan of globals either, but I'm concerned about depending on 
> the context in a, well, context where it's possible that the context is 
> messed up or doesn't exist. 
>
> 
> Brian Wickman wrote:
> the only exceptions that can be revealed here are from within _execute() 
> right?  at this point, why not just always print the stack trace?
> 
> Mark Chu-Carroll wrote:
> Dammit, the constant sledgehammering down the hill from me is driving me 
> *insane*. I didn't mean to hit "publish" yet.
> 
> If you look at the context where the reveal-errors flag is checked, there 
> is no Context object available.
> 
> I can wrap the global in a class, like one of the registries. Would that 
> be a decent compromise?
>
> 
> Brian Wickman wrote:
> i also don't see a big deal with adding a set_exception() method to the 
> Context base class and having this set by _execute or execute or both.

hmm, then it sounds like adding the --reveal-errors flag to a plugin doesn't 
really make sense, since it's not really a plugin.  it's a property of the 
framework itself.  should this be done with an environment variable instead?


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46325
---


On June 20, 2014, 8:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 20, 2014, 8:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46337
---



src/main/python/apache/aurora/client/cli/standalone_client.py


this doesn't do what you want -- you must import REVEAL_ERRORS from 
apache.aurora.client.cli if you want to be talking about the same thing


- Brian Wickman


On June 20, 2014, 8:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 20, 2014, 8:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Mark Chu-Carroll 


> On June 20, 2014, 5:30 p.m., Brian Wickman wrote:
> > not a big fan of globals here.  can you instead annotate the context with 
> > the exception and in post-dispatch have the plugin print it out if 
> > --reveal-errors is set?
> 
> Mark Chu-Carroll wrote:
> I'm not a big fan of globals either, but I'm concerned about depending on 
> the context in a, well, context where it's possible that the context is 
> messed up or doesn't exist. 
>
> 
> Brian Wickman wrote:
> the only exceptions that can be revealed here are from within _execute() 
> right?  at this point, why not just always print the stack trace?

Dammit, the constant sledgehammering down the hill from me is driving me 
*insane*. I didn't mean to hit "publish" yet.

If you look at the context where the reveal-errors flag is checked, there is no 
Context object available.

I can wrap the global in a class, like one of the registries. Would that be a 
decent compromise?


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46325
---


On June 20, 2014, 4:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 20, 2014, 4:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Brian Wickman 


> On June 20, 2014, 9:30 p.m., Brian Wickman wrote:
> > not a big fan of globals here.  can you instead annotate the context with 
> > the exception and in post-dispatch have the plugin print it out if 
> > --reveal-errors is set?
> 
> Mark Chu-Carroll wrote:
> I'm not a big fan of globals either, but I'm concerned about depending on 
> the context in a, well, context where it's possible that the context is 
> messed up or doesn't exist. 
>
> 
> Brian Wickman wrote:
> the only exceptions that can be revealed here are from within _execute() 
> right?  at this point, why not just always print the stack trace?
> 
> Mark Chu-Carroll wrote:
> Dammit, the constant sledgehammering down the hill from me is driving me 
> *insane*. I didn't mean to hit "publish" yet.
> 
> If you look at the context where the reveal-errors flag is checked, there 
> is no Context object available.
> 
> I can wrap the global in a class, like one of the registries. Would that 
> be a decent compromise?
>

i also don't see a big deal with adding a set_exception() method to the Context 
base class and having this set by _execute or execute or both.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46325
---


On June 20, 2014, 8:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 20, 2014, 8:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Brian Wickman 


> On June 20, 2014, 9:30 p.m., Brian Wickman wrote:
> > not a big fan of globals here.  can you instead annotate the context with 
> > the exception and in post-dispatch have the plugin print it out if 
> > --reveal-errors is set?
> 
> Mark Chu-Carroll wrote:
> I'm not a big fan of globals either, but I'm concerned about depending on 
> the context in a, well, context where it's possible that the context is 
> messed up or doesn't exist. 
>

the only exceptions that can be revealed here are from within _execute() right? 
 at this point, why not just always print the stack trace?


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46325
---


On June 20, 2014, 8:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 20, 2014, 8:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Mark Chu-Carroll 


> On June 20, 2014, 5:30 p.m., Brian Wickman wrote:
> > not a big fan of globals here.  can you instead annotate the context with 
> > the exception and in post-dispatch have the plugin print it out if 
> > --reveal-errors is set?

I'm not a big fan of globals either, but I'm concerned about depending on the 
context in a, well, context where it's possible that the context is messed up 
or doesn't exist. 


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46325
---


On June 20, 2014, 4:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 20, 2014, 4:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Brian Wickman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46325
---


not a big fan of globals here.  can you instead annotate the context with the 
exception and in post-dispatch have the plugin print it out if --reveal-errors 
is set?

- Brian Wickman


On June 20, 2014, 8:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 20, 2014, 8:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-20 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22839/#review46323
---



src/main/python/apache/aurora/client/cli/standalone_client.py


can you refactor here to avoid a global variable? Anything that manipulates 
global state like this is very difficult to test.



src/main/python/apache/aurora/client/cli/standalone_client.py


revert or remove


- Kevin Sweeney


On June 20, 2014, 1:47 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22839/
> ---
> 
> (Updated June 20, 2014, 1:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-544 and aurora-545
> https://issues.apache.org/jira/browse/aurora-544
> https://issues.apache.org/jira/browse/aurora-545
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Add configuration plugins to default aurora client.
> 
> - Add a plugin to allow users to set logging levels.
> - Add a plugin to allow users to configure whether or not unknown exceptions 
> get
>   caught or revealed.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 827bbb88230f4e536500710695cb92bf39da3447 
>   src/main/python/apache/aurora/client/cli/standalone_client.py 
> 5d1a4a53a8b36b6dd072485260d490435da6968d 
>   src/test/python/apache/aurora/client/cli/test_plugins.py 
> ce85318727dcaf22a696d05f99c49b5e953bd3ca 
> 
> Diff: https://reviews.apache.org/r/22839/diff/
> 
> 
> Testing
> ---
> 
> - Added new test.
> - Ran all unit tests.
> - Did manual command-line testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>