Re: Review Request 24573: Fix bug in "aurora job inspect".

2014-08-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50615 --- Ship it! Ship It! - Bill Farner On Aug. 14, 2014, 5:30 p.m., Mar

Re: Review Request 24573: Fix bug in "aurora job inspect".

2014-08-14 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/ --- (Updated Aug. 14, 2014, 1:30 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 24573: Fix bug in "aurora job inspect".

2014-08-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50583 --- src/test/python/apache/aurora/client/cli/BUILD

Re: Review Request 24573: Fix bug in "aurora job inspect".

2014-08-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50498 --- Ship it! Ship It! - David McLaughlin On Aug. 13, 2014, 7:27 p.m.

Re: Review Request 24573: Fix bug in "aurora job inspect".

2014-08-13 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/ --- (Updated Aug. 13, 2014, 3:27 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 24573: Fix bug in "aurora job inspect".

2014-08-11 Thread Mark Chu-Carroll
> On Aug. 11, 2014, 4:18 p.m., Bill Farner wrote: > > Issue points out lack of test coverage, can you add that with the fix? Sure. I think for this, it makes sense to put it in end-to-end. (unit tests in the client focus on verifying that API calls got made correctly; this seems more like a sy

Re: Review Request 24573: Fix bug in "aurora job inspect".

2014-08-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50224 --- Issue points out lack of test coverage, can you add that with the fi

Re: Review Request 24573: Fix bug in "aurora job inspect".

2014-08-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24573/#review50223 --- Issue points out lack of test coverage, can you add that with the fi