Re: Review Request 25593: Use a ServletContextListener to configure servlets

2014-09-12 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25593/#review53243 --- Ship it! Ship It! - Bill Farner On Sept. 12, 2014, 9:43 p.m., Ke

Re: Review Request 25593: Use a ServletContextListener to configure servlets

2014-09-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25593/#review53226 --- Ship it! Ship It! - Joshua Cohen On Sept. 12, 2014, 9:43 p.m., K

Re: Review Request 25593: Use a ServletContextListener to configure servlets

2014-09-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25593/ --- (Updated Sept. 12, 2014, 2:43 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25593: Use a ServletContextListener to configure servlets

2014-09-12 Thread Kevin Sweeney
> On Sept. 12, 2014, 2:37 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, > > lines 369-373 > > > > > > Obviously not related, but should these all use Objects.requ

Re: Review Request 25593: Use a ServletContextListener to configure servlets

2014-09-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25593/ --- (Updated Sept. 12, 2014, 2:39 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 25593: Use a ServletContextListener to configure servlets

2014-09-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25593/#review53220 --- Ship it! lgtm src/main/java/org/apache/aurora/scheduler/http/Jett