Re: Review Request 25859: Fix some bugs in the Update UI

2014-09-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54159 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 22, 2014, 6:24 p.

Re: Review Request 25859: Fix some bugs in the Update UI

2014-09-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/ --- (Updated Sept. 22, 2014, 6:24 p.m.) Review request for Aurora, Maxim Khutornenk

Re: Review Request 25859: Fix some bugs in the Update UI

2014-09-22 Thread David McLaughlin
> On Sept. 20, 2014, 1:02 a.m., Maxim Khutornenko wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml, > > line 275 > > > > > > This will fail unit tests as is. Thanks. Fix

Re: Review Request 25859: Fix some bugs in the Update UI

2014-09-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54068 --- Ship it! LGTM iff unit tests pass. - Bill Farner On Sept. 20, 20

Re: Review Request 25859: Fix some bugs in the Update UI

2014-09-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25859/#review54066 --- src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdate