Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28026/#review62268 --- Master (2aa0026) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28026/ --- (Updated Nov. 19, 2014, 11:05 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28026/#review62264 --- Ship it! Ship It! - Zameer Manji On Nov. 19, 2014, 2:16 p.m., Bi

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Bill Farner
> On Nov. 14, 2014, 1:48 a.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 750 > > > > > > Can you change this if you agree with > > https://review

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28026/ --- (Updated Nov. 19, 2014, 10:16 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Bill Farner
> On Nov. 14, 2014, 1:48 a.m., Zameer Manji wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 1787 > > > > > > Can you file a JIRA for this? > > Maxim Khutornenk

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-18 Thread Maxim Khutornenko
> On Nov. 14, 2014, 1:48 a.m., Zameer Manji wrote: > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java, > > line 1787 > > > > > > Can you file a JIRA for this? This is now tracked

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28026/#review61506 --- Ship it! Ship It! - David McLaughlin On Nov. 14, 2014, 1:30 a.m.

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28026/#review61387 --- This patch does not apply cleanly on master (316f291), do you need t

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28026/#review61384 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 14, 2014, 1:30 a.m

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28026/#review61371 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt