Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review62268
---


Master (2aa0026) is red with this patch.
  ./build-support/jenkins/build.sh

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.util-0.3.1-py2.7-nspkg.pth
  Found existing installation: setuptools 3.6
Uninstalling setuptools:
  Successfully uninstalled setuptools
Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile 
pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon 
requests twitter.common.collections twitter.common.config 
twitter.common.confluence twitter.common.contextutil twitter.common.decorators 
twitter.common.dirutil twitter.common.lang twitter.common.log 
twitter.common.options twitter.common.process twitter.common.string 
twitter.common.threading twitter.common.util setuptools
Cleaning up...
Build operating on top level addresses: 
set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au
 rora/common/auth/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/
 BUILD, base)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(B
 
uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 shellify)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAdd

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/
---

(Updated Nov. 19, 2014, 11:05 p.m.)


Review request for Aurora, David McLaughlin and Zameer Manji.


Bugs: AURORA-937
https://issues.apache.org/jira/browse/AURORA-937


Repository: aurora


Description
---

This brings SchedulerThriftInterface to 99% instruction coverage and 96% branch 
coverage.  The remaining pieces are legitimately difficult to capture.

I also uncovered a few minor bugs along the way, most noteworthy being AOP 
interceptor ordering leading to the standard API response not always being 
applied.

Additionally, i removed a bunch of unnecessary exception handling that is now 
done by an AOP interceptor.


Diffs (updated)
-

  src/main/java/org/apache/aurora/auth/SessionValidator.java 
eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
  src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
4744dc9f202969906113ccb610bf17c94d188c43 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
4b65a2ccb32ff5058c5b7adb858c5225c16784c6 
  src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
dca855c522d21924821fc47e636da39689aec4b7 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 608903268a0a0d67711bfdc81d2e5b29c335ead2 

Diff: https://reviews.apache.org/r/28026/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review62264
---

Ship it!


Ship It!

- Zameer Manji


On Nov. 19, 2014, 2:16 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> ---
> 
> (Updated Nov. 19, 2014, 2:16 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: AURORA-937
> https://issues.apache.org/jira/browse/AURORA-937
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Bill Farner 


> On Nov. 14, 2014, 1:48 a.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 750
> > 
> >
> > Can you change this if you agree with 
> > https://reviews.apache.org/r/28021/ ?

Change is forced by merge conflict, updated with rebase.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61371
---


On Nov. 19, 2014, 10:16 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> ---
> 
> (Updated Nov. 19, 2014, 10:16 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: AURORA-937
> https://issues.apache.org/jira/browse/AURORA-937
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/
---

(Updated Nov. 19, 2014, 10:16 p.m.)


Review request for Aurora, David McLaughlin and Zameer Manji.


Bugs: AURORA-937
https://issues.apache.org/jira/browse/AURORA-937


Repository: aurora


Description
---

This brings SchedulerThriftInterface to 99% instruction coverage and 96% branch 
coverage.  The remaining pieces are legitimately difficult to capture.

I also uncovered a few minor bugs along the way, most noteworthy being AOP 
interceptor ordering leading to the standard API response not always being 
applied.

Additionally, i removed a bunch of unnecessary exception handling that is now 
done by an AOP interceptor.


Diffs
-

  src/main/java/org/apache/aurora/auth/SessionValidator.java 
eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
  src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
4744dc9f202969906113ccb610bf17c94d188c43 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
b2b66acee9c0789f3660469d6d504b4510af5e79 
  src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
dca855c522d21924821fc47e636da39689aec4b7 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 

Diff: https://reviews.apache.org/r/28026/diff/


Testing
---


Thanks,

Bill Farner

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-19 Thread Bill Farner 


> On Nov. 14, 2014, 1:48 a.m., Zameer Manji wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
> >  line 1787
> > 
> >
> > Can you file a JIRA for this?
> 
> Maxim Khutornenko wrote:
> This is now tracked by https://issues.apache.org/jira/browse/AURORA-937

My mistake, i jotted down the TODO and addressed it in this diff.  I'll link 
the ticket against this review.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61371
---


On Nov. 14, 2014, 1:30 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> ---
> 
> (Updated Nov. 14, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-18 Thread Maxim Khutornenko 


> On Nov. 14, 2014, 1:48 a.m., Zameer Manji wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
> >  line 1787
> > 
> >
> > Can you file a JIRA for this?

This is now tracked by https://issues.apache.org/jira/browse/AURORA-937


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61371
---


On Nov. 14, 2014, 1:30 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> ---
> 
> (Updated Nov. 14, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-14 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61506
---

Ship it!


Ship It!

- David McLaughlin


On Nov. 14, 2014, 1:30 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> ---
> 
> (Updated Nov. 14, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-13 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61387
---


This patch does not apply cleanly on master (316f291), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 14, 2014, 1:30 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> ---
> 
> (Updated Nov. 14, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-13 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61384
---

Ship it!


Ship It!

- Maxim Khutornenko


On Nov. 14, 2014, 1:30 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> ---
> 
> (Updated Nov. 14, 2014, 1:30 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28026: Add more test coverage to SchedulerThriftInterface.

2014-11-13 Thread Zameer Manji 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61371
---



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java


Can you change this if you agree with https://reviews.apache.org/r/28021/ ?



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java


Can you file a JIRA for this?


- Zameer Manji


On Nov. 13, 2014, 5:30 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28026/
> ---
> 
> (Updated Nov. 13, 2014, 5:30 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings SchedulerThriftInterface to 99% instruction coverage and 96% 
> branch coverage.  The remaining pieces are legitimately difficult to capture.
> 
> I also uncovered a few minor bugs along the way, most noteworthy being AOP 
> interceptor ordering leading to the standard API response not always being 
> applied.
> 
> Additionally, i removed a bunch of unnecessary exception handling that is now 
> done by an AOP interceptor.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b2b66acee9c0789f3660469d6d504b4510af5e79 
>   src/main/java/org/apache/aurora/scheduler/thrift/Util.java 
> 18e2bdfab6406761d7e7cbcec26d12fb28441fe0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java 
> dca855c522d21924821fc47e636da39689aec4b7 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  5c9ea6cf4eb4d99d94f5d61e784dd7c9c480798c 
> 
> Diff: https://reviews.apache.org/r/28026/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Bill Farner
> 
>