On Feb. 3, 2015, 8:20 p.m., Bill Farner wrote:
Maxim - ping?
Maxim Khutornenko wrote:
my previous comment is not addressed yet?
Ah sorry, i missed that. Will reply and/or update the diff.
- Bill
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70818
---
Maxim - ping?
- Bill Farner
On Jan. 29, 2015, 9:26 p.m., Bill
On Feb. 3, 2015, 8:20 p.m., Bill Farner wrote:
Maxim - ping?
my previous comment is not addressed yet?
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70818
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/
---
(Updated Feb. 3, 2015, 11:53 p.m.)
Review request for Aurora, Maxim
On Jan. 29, 2015, 7:21 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/jobs.py, lines 738-741
https://reviews.apache.org/r/30389/diff/1/?file=839595#file839595line738
This is techincally not true for the client updater. Cron jobs are
supported despite the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70865
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 3, 2015, 11:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70874
---
Ship it!
Master (2742120) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70233
---
Ship it!
Master (4f04a34) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70244
---
src/main/python/apache/aurora/client/cli/jobs.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70248
---
On Jan. 29, 2015, 6:49 p.m., Joshua Cohen wrote:
src/main/python/apache/aurora/client/cli/jobs.py, line 741
https://reviews.apache.org/r/30389/diff/1/?file=839595#file839595line741
Should we include the proper way to update a non-service job
(kill/create) in this message?
Done.
On Jan. 29, 2015, 7:15 p.m., Zameer Manji wrote:
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
line 3116
https://reviews.apache.org/r/30389/diff/1/?file=839596#file839596line3116
Why is this change necessary?
Thrift-generated code assumes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70252
---
src/main/python/apache/aurora/client/cli/jobs.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/
---
(Updated Jan. 29, 2015, 7:31 p.m.)
Review request for Aurora, Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70255
---
Ship it!
src/test/python/apache/aurora/client/cli/test_update.py
On Jan. 29, 2015, 7:36 p.m., Zameer Manji wrote:
src/test/python/apache/aurora/client/cli/test_update.py, line 99
https://reviews.apache.org/r/30389/diff/1-2/?file=839597#file839597line99
This seems like a code smell. Shouldn't we be able to configure the
fake_context to return
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70274
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 29, 2015, 7:31 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70269
---
Master (4f04a34) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/
---
(Updated Jan. 29, 2015, 9:26 p.m.)
Review request for Aurora, Maxim
19 matches
Mail list logo