Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73887 --- Ship it! Ship It! - Kevin Sweeney On Feb. 23, 2015, 2:47 p.m., M

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73729 --- Ship it! Master (1449a20) is green with this patch. ./build-suppo

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/ --- (Updated Feb. 23, 2015, 10:47 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

> On Feb. 23, 2015, 9:59 p.m., Bill Farner wrote: > > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 66 > > > > > > Javadoc here would be nice. I failed to elaborate on the last review, > > but

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73680 --- Ship it! src/jmh/java/org/apache/aurora/benchmark/BenchmarkSetting

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73677 --- Master (277ac43) is red with this patch. ./build-support/jenkins/b

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

> On Feb. 23, 2015, 11:47 a.m., Bill Farner wrote: > > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 33 > > > > > > This is bound to become a Texas constructor [1]. > > > > Please consid

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/ --- (Updated Feb. 23, 2015, 9:03 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

> On Feb. 23, 2015, 7:47 p.m., Bill Farner wrote: > > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java, line 33 > > > > > > This is bound to become a Texas constructor [1]. > > > > Please conside

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73642 --- src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/ --- (Updated Feb. 23, 2015, 7:34 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

> On Feb. 19, 2015, 10:40 p.m., Bill Farner wrote: > > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 272 > > > > > > You might want to use a limit rather than value constraint for this > > t

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73217 --- src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review72048 --- Ship it! Master (7b531e9) is green with this patch. ./build-suppo