Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76782 --- Ship it! - Joe Smith On March 13, 2015, 12:38 p.m., Brian Wickman

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76623 --- Ship it! Master (e11ed5b) is green with this patch. ./build-suppo

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-16 Thread Brian Wickman
> On March 13, 2015, 8:06 p.m., Aurora ReviewBot wrote: > > Master (128e554) is red with this patch. > > ./build-support/jenkins/build.sh > > > > src.test.python.apache.aurora.client.cli.plugins > > . SUCCESS > > s

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76586 --- @ReviewBot retry - Brian Wickman On March 13, 2015, 7:38 p.m., Br

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76414 --- Master (128e554) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76409 --- Ship it! Ship It! - Zameer Manji On March 13, 2015, 12:38 p.m.,

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-13 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/ --- (Updated March 13, 2015, 7:38 p.m.) Review request for Aurora, Joe Smith and Za

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-13 Thread Brian Wickman
> On March 13, 2015, 1:10 a.m., Brian Wickman wrote: > > @ReviewBot retry > > Bill Farner wrote: > If you believe you have discovered a flaky test (which i assume you're > asking the bot to try again), can you please file a ticket? Not a flaky test -- a legitimate breakage that I did not a

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76324 --- Master (ee1a13a) is red with this patch. ./build-support/jenkins/b

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-12 Thread Bill Farner
> On March 13, 2015, 1:10 a.m., Brian Wickman wrote: > > @ReviewBot retry If you believe you have discovered a flaky test (which i assume you're asking the bot to try again), can you please file a ticket? - Bill --- This is an automati

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-12 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76322 --- @ReviewBot retry - Brian Wickman On March 13, 2015, 12:47 a.m., B

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-12 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76320 --- Master (ee1a13a) is red with this patch. ./build-support/jenkins/b