Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-17 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32179 --- Ship it! Ship It! - Jonathan Boulle On Jan. 16, 2014, 9:17 p.m.,

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Tobias Weingartner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32081 --- Ship it! Ship It! - Tobias Weingartner On Jan. 16, 2014, 9:17 p.

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32079 --- Ship it! Ship It! - Bill Farner On Jan. 16, 2014, 9:17 p.m., Joe

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/ --- (Updated Jan. 16, 2014, 1:17 p.m.) Review request for Aurora, Jonathan Boulle a

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Joe Smith
> On Jan. 16, 2014, 12:36 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/commands/admin.py, line 38 > > > > > > Logic does not seem correct here. Can they both be 'falsey'? > > > > I'm proba

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Bill Farner
> On Jan. 16, 2014, 8:36 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/commands/admin.py, line 38 > > > > > > Logic does not seem correct here. Can they both be 'falsey'? > > > > I'm probab

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Joe Smith
> On Jan. 16, 2014, 12:36 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/commands/admin.py, line 38 > > > > > > Logic does not seem correct here. Can they both be 'falsey'? > > > > I'm proba

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32069 --- src/main/python/apache/aurora/client/commands/admin.py

Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/ --- Review request for Aurora and Jonathan Boulle. Repository: aurora Description