Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-14 Thread Maxim Khutornenko
> On Feb. 14, 2014, 5:51 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/cli/options.py, lines 55-58 > > > > > > one-liner: > > return sorted(map(parse_time, time_values.split(','))) > > > >

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/ --- (Updated Feb. 14, 2014, 6 p.m.) Review request for Aurora, Mark Chu-Carroll and

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-14 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34513 --- Ship it! src/main/python/apache/aurora/client/cli/options.py

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/ --- (Updated Feb. 14, 2014, 5:42 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-13 Thread Maxim Khutornenko
> On Feb. 13, 2014, 9:06 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/sla.py, line 52 > > > > > > metaphysical question: should this be 100 if len(total)==0? Missed this one. Followup to our

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/ --- (Updated Feb. 13, 2014, 11:11 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34421 --- src/main/python/apache/aurora/client/cli/sla.py

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-13 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34407 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-13 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34405 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 13, 2014, 2:25 p.m.

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-13 Thread Maxim Khutornenko
> On Feb. 13, 2014, 6:48 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/api/sla.py, line 25 > > > > > > imports should be in alphabetical order. Done. > On Feb. 13, 2014, 6:48 p.m., Mark Chu-C

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/ --- (Updated Feb. 13, 2014, 7:25 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 18042: Adding "sla get_task_up_count command".

2014-02-13 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/#review34393 --- src/main/python/apache/aurora/client/api/sla.py

Review Request 18042: Adding "sla get_task_up_count command".

2014-02-12 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18042/ --- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-206