Re: Review Request 19709: CrontabEntry parser

2014-03-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 28, 2014, 10:30 a.m.) Review request for Aurora, Maxim

Re: Review Request 19709: CrontabEntry parser

2014-03-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 28, 2014, 10:31 a.m.) Review request for Aurora, Maxim

Re: Review Request 19709: CrontabEntry parser

2014-03-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38903 --- Ship it!

Re: Review Request 19709: CrontabEntry parser

2014-03-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 27, 2014, 2:52 p.m.) Review request for Aurora, Maxim

Re: Review Request 19709: CrontabEntry parser

2014-03-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38821 --- build.gradle https://reviews.apache.org/r/19709/#comment71148

Re: Review Request 19709: CrontabEntry parser

2014-03-27 Thread Kevin Sweeney
On March 27, 2014, 2:54 p.m., Bill Farner wrote: build.gradle, line 223 https://reviews.apache.org/r/19709/diff/2/?file=538968#file538968line223 Please exclude junit-dep instead. Done. - Kevin --- This is an automatically

Re: Review Request 19709: CrontabEntry parser

2014-03-27 Thread Kevin Sweeney
On March 27, 2014, 2:44 p.m., Bill Farner wrote: build.gradle, line 377 https://reviews.apache.org/r/19709/diff/1/?file=538162#file538162line377 What would it take to do that now? Is it as simple as System.setProperty? Dropped. On March 27, 2014, 2:44 p.m., Bill Farner

Re: Review Request 19709: CrontabEntry parser

2014-03-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 27, 2014, 5:14 p.m.) Review request for Aurora, Maxim

Re: Review Request 19709: CrontabEntry parser

2014-03-27 Thread Bill Farner
On March 27, 2014, 9:44 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/cron/CrontabEntry.java, line 148 https://reviews.apache.org/r/19709/diff/1/?file=538165#file538165line148 Do these all need to be public? Looks like most of these accessors are only used

Re: Review Request 19709: CrontabEntry parser

2014-03-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/#review38857 --- Ship it!

Re: Review Request 19709: CrontabEntry parser

2014-03-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- (Updated March 27, 2014, 6:02 p.m.) Review request for Aurora, Maxim

Review Request 19709: CrontabEntry parser

2014-03-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19709/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-132