Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/#review49523 --- Ship it! Ship It! - David McLaughlin On Aug. 4, 2014, 10:06 p.m.

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/ --- (Updated Aug. 4, 2014, 10:06 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 24243: DB schema for the job update store.

> On Aug. 4, 2014, 9:41 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line > > 98 > > > > > > Strongly consider dropping update_id to let the IDENTITY stand alone.

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/#review49510 --- Ship it! src/main/resources/org/apache/aurora/scheduler/storage/db

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/#review49511 --- FlagSchemaChanges is going to fail if this is committed as-is. - Ke

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/ --- (Updated Aug. 4, 2014, 9:04 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 24243: DB schema for the job update store.

> On Aug. 4, 2014, 7:27 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line > > 123 > > > > > > I'm an anti-fan of flags that say "do not do X", as they can lead to

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/ --- (Updated Aug. 4, 2014, 8:59 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 24243: DB schema for the job update store.

> On Aug. 4, 2014, 1:31 p.m., Kevin Sweeney wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line > > 111 > > > > > > Will the interface return RangeSet? Maybe a more compact form > >

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/#review49505 --- Ship it! +1 from me after the double-negative is removed - Kevin S

Re: Review Request 24243: DB schema for the job update store.

> On Aug. 4, 2014, 8:31 p.m., Kevin Sweeney wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines > > 101-102 > > > > > > Is there a reason not to use TIMESTAMP [1] types that will be

Re: Review Request 24243: DB schema for the job update store.

> On Aug. 4, 2014, 8:31 p.m., Kevin Sweeney wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines > > 101-102 > > > > > > Is there a reason not to use TIMESTAMP [1] types that will be

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/#review49492 --- partial review on v1, will deliver full with v2 src/main/resources

Re: Review Request 24243: DB schema for the job update store.

> On Aug. 4, 2014, 7:27 p.m., Bill Farner wrote: > > Current design assumes H2 ARRAY type is supported in MyBatis. > On Aug. 4, 2014, 7:27 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line > > 100 > >

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/ --- (Updated Aug. 4, 2014, 8:28 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/#review49487 --- src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sq

Review Request 24243: DB schema for the job update store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24243/ --- Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Bu