Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-05 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/ --- (Updated Sept. 5, 2014, 9:32 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52465 --- Ship it! awesome joe. thanks for doing this. - Brian Wickman On

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
> On Sept. 4, 2014, 6:23 p.m., David Robinson wrote: > > src/test/python/apache/aurora/executor/common/test_health_checker.py, line > > 60 > > > > > > Why do you need to cast num_calls? leftover from the previous test

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/ --- (Updated Sept. 4, 2014, 8 p.m.) Review request for Aurora, David McLaughlin, Ma

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52397 --- Ship it! lgtm. - David McLaughlin On Sept. 5, 2014, 1:20 a.m., J

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52395 --- Ship it! src/main/python/apache/aurora/executor/common/health_chec

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
> On Sept. 4, 2014, 5:50 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/executor/common/health_checker.py, lines > > 131-132 > > > > > > make _healthy and _reason non-private done > On Sept. 4, 2014,

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/ --- (Updated Sept. 4, 2014, 6:20 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52393 --- Ship it! LGTM mod HttpSignaler mocking. - Maxim Khutornenko On S

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52389 --- \m/ src/main/python/apache/aurora/executor/common/health_checker.p

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/ --- (Updated Sept. 4, 2014, 5:43 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
> On Sept. 4, 2014, 5:39 p.m., Zameer Manji wrote: > > src/test/python/apache/aurora/executor/test_thermos_executor.py, line 395 > > > > > > I don't think this is supposed to be here. whew, still pass. - Joe -

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52387 --- src/test/python/apache/aurora/executor/test_thermos_executor.py

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/ --- (Updated Sept. 4, 2014, 5:24 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52332 --- Discussed offline but it probably makes sense to not do any status c

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52318 --- Ship it! Ship It! - Zameer Manji On Sept. 4, 2014, 3:50 a.m., Jo

Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/ --- Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickma