Re: Review Request 28198: Add an example on how to build with Docker.

2014-12-12 Thread Jay Buffington
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review64919 --- This is *awesome*. Using docker to do aurora builds in and to ship

Re: Review Request 28198: Add an example on how to build with Docker.

2014-12-12 Thread Tony Dong
On Dec. 12, 2014, 4:52 p.m., Jay Buffington wrote: This is *awesome*. Using docker to do aurora builds in and to ship an aurora runtime is fantastic. My major issue with this commit is that you're unnecessarily putting build dependencies (aurora source, python-dev, git, etc) into

Re: Review Request 28198: Add an example on how to build with Docker.

2014-12-11 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Dec. 11, 2014, 6:32 p.m.) Review request for Aurora, Benjamin

Re: Review Request 28198: Add an example on how to build with Docker.

2014-12-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review64768 --- Sorry for the delay in responding here, thanks for opening this

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
On Nov. 21, 2014, 9:12 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, line 30 https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line30 We should expose the mesos-master (5050), mesos-slave (5051), and thermos-observer (1338) UIs too. And possibly ZooKeeper

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 25, 2014, 7:37 p.m.) Review request for Aurora, Benjamin

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review63027 --- examples/docker/Dockerfile

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
On Nov. 25, 2014, 7:43 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, line 35 https://reviews.apache.org/r/28198/diff/3/?file=775982#file775982line35 Presumably we're not all going to use your zookeeper ensemble? oh oops... sorry I had it in my local version and forgot to

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 25, 2014, 7:47 p.m.) Review request for Aurora, Benjamin

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review63040 --- examples/docker/Dockerfile

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
On Nov. 25, 2014, 8:49 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, lines 14-16 https://reviews.apache.org/r/28198/diff/4/?file=776032#file776032line14 Can we avoid the extra clone here and build from the currently checked out repo? That way this script is likely to

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review63047 --- Ship it! Master (e95aa8e) is green with this patch.

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-24 Thread Tony Dong
On Nov. 19, 2014, 6:32 p.m., Zameer Manji wrote: examples/docker/Dockerfile, line 13 https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line13 Since we are not checking out a specific version this will break once aurora updates to a new version of mesos and the

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-21 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62623 --- examples/docker/Dockerfile

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-21 Thread Kevin Sweeney
On Nov. 19, 2014, 10:32 a.m., Zameer Manji wrote: examples/docker/Dockerfile, line 13 https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line13 Since we are not checking out a specific version this will break once aurora updates to a new version of mesos and the

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-19 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 4 p.m.) Review request for Aurora, Benjamin Staffin,

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62185 --- examples/docker/Dockerfile

Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- Review request for Aurora. Repository: aurora Description --- Add an

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 12:35 a.m.) Review request for Aurora and Benjamin

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62078 --- Master (c44aa5c) is red with this patch.

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62079 --- @ReviewBot retry - Tony Dong On Nov. 19, 2014, 12:35 a.m., Tony

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 19, 2014, 12:54 a.m.) Review request for Aurora, Benjamin

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62083 --- Master (c44aa5c) is red with this patch.

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review62098 --- Please add a committer to this so it can be committed. I suggest