Re: Review Request 30585: Adding command hook for beta-update start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/#review71014 --- Ship it! Ship It! - Zameer Manji On Feb. 3, 2015, 4:24 p.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30585/ > --- > > (Updated Feb. 3, 2015, 4:24 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Adding command hook for beta-update start. > > Also contains an update for the hooks documentation. > > > Diffs > - > > docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 > src/main/python/apache/aurora/client/hooks/hooked_api.py > bc61e91af6de06ecfc37eddd846c096a5155d7eb > src/test/python/apache/aurora/client/hooks/test_hooked_api.py > a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 > > Diff: https://reviews.apache.org/r/30585/diff/ > > > Testing > --- > > ./pants goal test src/test/python/apache/aurora/client/hooks:hooked_api > > > Thanks, > > George Sirois > >
Re: Review Request 30585: Adding command hook for beta-update start.
> On Feb. 4, 2015, 1:59 a.m., David McLaughlin wrote: > > LGTM, thanks for the patch. > > > > Although I'm a little bit concerned about adding support for hooks in an > > environment where we can't support post-hooks. Thanks! I agree that it is certainly not ideal, but it does allow us to at least publish notifications when an update begins. - George --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/#review70898 --- On Feb. 4, 2015, 12:24 a.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30585/ > --- > > (Updated Feb. 4, 2015, 12:24 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Adding command hook for beta-update start. > > Also contains an update for the hooks documentation. > > > Diffs > - > > docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 > src/main/python/apache/aurora/client/hooks/hooked_api.py > bc61e91af6de06ecfc37eddd846c096a5155d7eb > src/test/python/apache/aurora/client/hooks/test_hooked_api.py > a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 > > Diff: https://reviews.apache.org/r/30585/diff/ > > > Testing > --- > > ./pants goal test src/test/python/apache/aurora/client/hooks:hooked_api > > > Thanks, > > George Sirois > >
Re: Review Request 30585: Adding command hook for beta-update start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/#review70898 --- Ship it! LGTM, thanks for the patch. Although I'm a little bit concerned about adding support for hooks in an environment where we can't support post-hooks. - David McLaughlin On Feb. 4, 2015, 12:24 a.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30585/ > --- > > (Updated Feb. 4, 2015, 12:24 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Adding command hook for beta-update start. > > Also contains an update for the hooks documentation. > > > Diffs > - > > docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 > src/main/python/apache/aurora/client/hooks/hooked_api.py > bc61e91af6de06ecfc37eddd846c096a5155d7eb > src/test/python/apache/aurora/client/hooks/test_hooked_api.py > a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 > > Diff: https://reviews.apache.org/r/30585/diff/ > > > Testing > --- > > ./pants goal test src/test/python/apache/aurora/client/hooks:hooked_api > > > Thanks, > > George Sirois > >
Re: Review Request 30585: Adding command hook for beta-update start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/#review70880 --- Ship it! Master (2742120) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Feb. 4, 2015, 12:24 a.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30585/ > --- > > (Updated Feb. 4, 2015, 12:24 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Adding command hook for beta-update start. > > Also contains an update for the hooks documentation. > > > Diffs > - > > docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 > src/main/python/apache/aurora/client/hooks/hooked_api.py > bc61e91af6de06ecfc37eddd846c096a5155d7eb > src/test/python/apache/aurora/client/hooks/test_hooked_api.py > a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 > > Diff: https://reviews.apache.org/r/30585/diff/ > > > Testing > --- > > ./pants goal test src/test/python/apache/aurora/client/hooks:hooked_api > > > Thanks, > > George Sirois > >
Re: Review Request 30585: Adding command hook for beta-update start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/#review70873 --- @ReviewBot retry - George Sirois On Feb. 4, 2015, 12:24 a.m., George Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30585/ > --- > > (Updated Feb. 4, 2015, 12:24 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > --- > > Adding command hook for beta-update start. > > Also contains an update for the hooks documentation. > > > Diffs > - > > docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 > src/main/python/apache/aurora/client/hooks/hooked_api.py > bc61e91af6de06ecfc37eddd846c096a5155d7eb > src/test/python/apache/aurora/client/hooks/test_hooked_api.py > a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 > > Diff: https://reviews.apache.org/r/30585/diff/ > > > Testing > --- > > ./pants goal test src/test/python/apache/aurora/client/hooks:hooked_api > > > Thanks, > > George Sirois > >
Re: Review Request 30585: Adding command hook for beta-update start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/ --- (Updated Feb. 4, 2015, 12:24 a.m.) Review request for Aurora and Zameer Manji. Repository: aurora Description --- Adding command hook for beta-update start. Also contains an update for the hooks documentation. Diffs (updated) - docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 src/main/python/apache/aurora/client/hooks/hooked_api.py bc61e91af6de06ecfc37eddd846c096a5155d7eb src/test/python/apache/aurora/client/hooks/test_hooked_api.py a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 Diff: https://reviews.apache.org/r/30585/diff/ Testing --- ./pants goal test src/test/python/apache/aurora/client/hooks:hooked_api Thanks, George Sirois
Re: Review Request 30585: Adding command hook for beta-update start.
> On Feb. 3, 2015, 4:05 p.m., Aurora ReviewBot wrote:
> > Master (2742120) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> > (namespace package)
> >
> > Installing
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.util-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for twitter.common.collections
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> > (namespace package)
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> > (namespace package)
> >
> > Installing
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.collections-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for smmap
> >
> > Running setup.py install for twitter.common.string
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> > (namespace package)
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> > (namespace package)
> >
> > Installing
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.string-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for twitter.common.options
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> > (namespace package)
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> > (namespace package)
> >
> > Installing
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.options-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for twitter.common.dirutil
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> > (namespace package)
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> > (namespace package)
> >
> > Installing
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.dirutil-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for twitter.common.contextutil
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> > (namespace package)
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> > (namespace package)
> >
> > Installing
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.contextutil-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for twitter.common.lang
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
> > (namespace package)
> > Skipping installation of
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
> > (namespace package)
> >
> > Installing
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.lang-0.3.0-py2.7-nspkg.pth
> > Successfully installed twitter.checkstyle pyflakes pep8 GitPython
> > twitter.common.app gitdb twitter.common.process twitter.common.log
> > twitter.common.util twitter.common.collections smmap twitter.common.string
> > twitter.common.options twitter.common.dirutil twitter.common.contextutil
> > twitter.common.lang
> > Cleaning up...
> > E501:ERROR
> > src/test/python/apache/aurora/client/hooks/test_hooked_api.py:023 line too
> > long (119 > 100 characters)
> > |API_METHODS = ('cancel_update', '
Re: Review Request 30585: Adding command hook for beta-update start.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30585/#review70868
---
Master (2742120) is red with this patch.
./build-support/jenkins/build.sh
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.util-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.collections
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.collections-0.3.0-py2.7-nspkg.pth
Running setup.py install for smmap
Running setup.py install for twitter.common.string
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.string-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.options
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.options-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.dirutil
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.dirutil-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.contextutil
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.contextutil-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.lang
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.lang-0.3.0-py2.7-nspkg.pth
Successfully installed twitter.checkstyle pyflakes pep8 GitPython
twitter.common.app gitdb twitter.common.process twitter.common.log
twitter.common.util twitter.common.collections smmap twitter.common.string
twitter.common.options twitter.common.dirutil twitter.common.contextutil
twitter.common.lang
Cleaning up...
E501:ERROR src/test/python/apache/aurora/client/hooks/test_hooked_api.py:023
line too long (119 > 100 characters)
|API_METHODS = ('cancel_update', 'create_job', 'kill_job', 'restart',
'start_cronjob', 'update_job', 'start_job_update')
I will refresh this build result if you post a review conta
Re: Review Request 30585: Adding command hook for beta-update start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/ --- (Updated Feb. 3, 2015, 11:58 p.m.) Review request for Aurora and Zameer Manji. Changes --- People += zmanji -wfarner Repository: aurora Description --- Adding command hook for beta-update start. Also contains an update for the hooks documentation. Diffs - docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 src/main/python/apache/aurora/client/hooks/hooked_api.py bc61e91af6de06ecfc37eddd846c096a5155d7eb src/test/python/apache/aurora/client/hooks/test_hooked_api.py a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 Diff: https://reviews.apache.org/r/30585/diff/ Testing (updated) --- ./pants goal test src/test/python/apache/aurora/client/hooks:hooked_api Thanks, George Sirois
Review Request 30585: Adding command hook for beta-update start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/ --- Review request for Aurora. Repository: aurora Description --- Adding command hook for beta-update start. Also contains an update for the hooks documentation. Diffs - docs/hooks.md 533c81df9a5934ea903e3dbfb9fca6a211ceba21 src/main/python/apache/aurora/client/hooks/hooked_api.py bc61e91af6de06ecfc37eddd846c096a5155d7eb src/test/python/apache/aurora/client/hooks/test_hooked_api.py a1f474e1a4f0bcdbd0062757314ede1b7bb37f38 Diff: https://reviews.apache.org/r/30585/diff/ Testing --- Thanks, George Sirois
