Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review75210
---

Ship it!


Ship It!

- Joe Smith


On March 4, 2015, 10:52 a.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated March 4, 2015, 10:52 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> b8a638822f44cfc596b16483a19efdeb4507758f 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> ae15571948606f40bb360136311d22f52685517c 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated March 4, 2015, 6:52 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Update diff post master merge.


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
b8a638822f44cfc596b16483a19efdeb4507758f 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
ae15571948606f40bb360136311d22f52685517c 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

> On March 3, 2015, 10:31 p.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/cli/common.py, line 101
> > 
> >
> > shouldn't closing the checkpoint and killing the task runner be in a 
> > finally clause?

No, it's ^C that should indicate whether or not we should kill the task.  If 
the task exits normally, .close_ckpt/.kill will fail since the checkpoint is 
already closed and the task is in a terminal state.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review75063
---


On March 3, 2015, 10:14 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated March 3, 2015, 10:14 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review75063
---

Ship it!



src/main/python/apache/thermos/cli/common.py


shouldn't closing the checkpoint and killing the task runner be in a 
finally clause?


- Zameer Manji


On March 3, 2015, 2:14 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated March 3, 2015, 2:14 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review75065
---


Master (2bf03dc) is red with this patch.
  ./build-support/jenkins/build.sh

 
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_detector 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.kill_manager 
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.resource_manager_integration  
.   FAILURE
 
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.gc_executor 
 .   SUCCESS
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_executor
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   SUCCESS
 src.test.python.apache.thermos.cli.commands.commands   
 .   SUCCESS
 src.test.python.apache.thermos.cli.common  
 .   SUCCESS
 src.test.python.apache.thermos.cli.main
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 src.test.python.apache.thermos.common.test_planner 
 .   SUCCESS
 src.test.python.apache.thermos.common.test_task_planner
 .   SUCCESS
 src.test.python.apache.thermos.config.test_schema  
 .   SUCCESS
 src.test.python.apache.thermos.core.test_angry 
 .   SUCCESS
 src.test.python.apache.thermos.core.test_ephemerals
 .   SUCCESS
 src.test.python.apache.thermos.core.test_failing_runner
 .   SUCCESS
 src.test.python.apache.thermos.core.test_failure_limit 
 .   SUCCESS
 src.test.python.apache.thermos.core.test_finalization  
 .   SUCCESS
 src.test.python.apache.thermos.core.test_helper
 .   SUCCESS
 src.test.python.apache.thermos.core.test_process   
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.core.test_staged_kill   
 .   SUCCESS
 src.test.python.apache.thermos.monitoring.test_detector
 .   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 src.test.python.apache.thermos.monitoring.test_garbage 
 .   SUCCESS
 src.test.python.apache.thermos.monitoring.test_resource
 .   SUCCESS
 
FAILURE


   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 3, 2015, 10:14 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated March 3, 2015, 10:14 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated March 3, 2015, 10:14 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Address joe's feedback


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

> On March 1, 2015, 9:03 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/tools/thermos.py, line 1
> > 
> >
> > Add apache copyright stanzas to these files?

done


> On March 1, 2015, 9:03 p.m., Joe Smith wrote:
> > src/test/python/apache/thermos/cli/test_common.py, line 3
> > 
> >
> > Adding tests for `get_task_from_options` and `task_from_re` would be 
> > valuable

added test for get_task_from_options since it's the most complex.  task_from_re 
is simpler and the cost to cover is pretty high, so i'd like to elect to punt 
until we're sure it's sticking around.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74711
---


On March 3, 2015, 10:14 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated March 3, 2015, 10:14 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Joe Smith]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74711
---


Overall LGTM, I see why some commands are untested but it'd be nice to get this 
stuff under coverage as it was going in.


src/main/python/apache/aurora/tools/thermos.py


Add apache copyright stanzas to these files?



src/test/python/apache/thermos/cli/test_common.py


Adding tests for `get_task_from_options` and `task_from_re` would be 
valuable


- Joe Smith


On Feb. 27, 2015, 3:37 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 3:37 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74631
---

Ship it!


Master (4cca6a6) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 11:37 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 11:37 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated Feb. 27, 2015, 11:37 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Merge master build fix.


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Zameer Manji]

> On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/cli/common.py, line 40
> > 
> >
> > Unrelated to your change, why have the strict option at al? Shouldn't 
> > the default behaviour validate the data?
> 
> Brian Wickman wrote:
> No idea what this is for.  Removing.

You did not actually remove this in the diff from what I can see.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74604
---


On Feb. 27, 2015, 2:48 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 2:48 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74616
---


Master (388a5b3) is red with this patch.
  ./build-support/jenkins/build.sh

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java:865:
 error: cannot find symbol
return expect(storageUtil.jobStore.fetchJob(anyObject(IJobKey.class)))
  ^
  symbol:   class IJobKey
  location: class QuotaManagerImplTest
1 error
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 33.823 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 10:48 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 10:48 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated Feb. 27, 2015, 10:48 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Add a spec_set on the options_mock for cli/commands/test_simplerun.


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74613
---


Master (388a5b3) is red with this patch.
  ./build-support/jenkins/build.sh

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJava
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java:865:
 error: cannot find symbol
return expect(storageUtil.jobStore.fetchJob(anyObject(IJobKey.class)))
  ^
  symbol:   class IJobKey
  location: class QuotaManagerImplTest
1 error
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 47.958 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 10:29 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 10:29 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Zameer Manji]

> On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote:
> > src/test/python/apache/thermos/cli/commands/test_simplerun.py, line 19
> > 
> >
> > Instead of creating a Mock like this here, could you grab the options 
> > from the simplerun command? If you do that then you can create a Mock with 
> > a spec_set.
> 
> Brian Wickman wrote:
> How do you mean grab the options from the simplerun command?  One of the 
> major flaws of twitter.common.app is that I can't easily invoke a configured 
> application from test, so the easiest thing to do is call an app.command 
> directly, but it means we have to construct our own options object :-\

I was hoping there was a way to get the options for a command given a command. 
If we cannot do that then I suggest giving this mock a spec_set with your 
desired options. This way if we add or remove options our tests won't silently 
pass and will throw an exception if we access an options attribute that is not 
defined.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74604
---


On Feb. 27, 2015, 2:29 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 2:29 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated Feb. 27, 2015, 10:29 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Address feedback and merge master.


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

> On Feb. 27, 2015, 10:03 p.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/cli/common.py, line 40
> > 
> >
> > Unrelated to your change, why have the strict option at al? Shouldn't 
> > the default behaviour validate the data?

No idea what this is for.  Removing.


> On Feb. 27, 2015, 10:03 p.m., Zameer Manji wrote:
> > src/main/python/apache/thermos/cli/common.py, line 47
> > 
> >
> > Could you leverage the daemonize code in t.c.process instead?

Tried this -- doesn't actually appear to work.


> On Feb. 27, 2015, 10:03 p.m., Zameer Manji wrote:
> > src/test/python/apache/thermos/cli/commands/test_simplerun.py, line 19
> > 
> >
> > Instead of creating a Mock like this here, could you grab the options 
> > from the simplerun command? If you do that then you can create a Mock with 
> > a spec_set.

How do you mean grab the options from the simplerun command?  One of the major 
flaws of twitter.common.app is that I can't easily invoke a configured 
application from test, so the easiest thing to do is call an app.command 
directly, but it means we have to construct our own options object :-\


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74604
---


On Feb. 27, 2015, 10:11 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 10:11 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef20 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATI

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74610
---


Master (388a5b3) is red with this patch.
  ./build-support/jenkins/build.sh

:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJava
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-core/1.6.1/jmh-core-1.6.1.pom
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-parent/1.6.1/jmh-parent-1.6.1.pom
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-generator-annprocess/1.6.1/jmh-generator-annprocess-1.6.1.pom
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-core/1.6.1/jmh-core-1.6.1.jar
Download 
https://repo1.maven.org/maven2/org/openjdk/jmh/jmh-generator-annprocess/1.6.1/jmh-generator-annprocess-1.6.1.jar
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java:865:
 error: cannot find symbol
return expect(storageUtil.jobStore.fetchJob(anyObject(IJobKey.class)))
  ^
  symbol:   class IJobKey
  location: class QuotaManagerImplTest
1 error
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileTestJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 2 mins 20.306 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 10:11 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 10:11 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/BUILD 
> df50964851c6be89c646015edf91d07992743497 
>   src/test/python/apache/thermos/bin/BUILD 
> 596aeb200dc55b077ed73fc342b9187045732890 
>   src/test/python/apache/thermos/bin/test_thermos.py 
> 2d9d33397ae01b31ab011d958f5457311ef7ef2

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

(Updated Feb. 27, 2015, 10:11 p.m.)


Review request for Aurora, Joe Smith and Zameer Manji.


Changes
---

Fix BUILD targets, remove old test_thermos.py


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs (updated)
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/BUILD df50964851c6be89c646015edf91d07992743497 
  src/test/python/apache/thermos/bin/BUILD 
596aeb200dc55b077ed73fc342b9187045732890 
  src/test/python/apache/thermos/bin/test_thermos.py 
2d9d33397ae01b31ab011d958f5457311ef7ef20 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Zameer Manji]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74604
---


I think moving the binary entry point to aurora/executor/bin is a good idea


src/main/python/apache/thermos/cli/common.py


Unrelated to your change, why have the strict option at al? Shouldn't the 
default behaviour validate the data?



src/main/python/apache/thermos/cli/common.py


Could you leverage the daemonize code in t.c.process instead?



src/test/python/apache/thermos/cli/commands/test_simplerun.py


Instead of creating a Mock like this here, could you grab the options from 
the simplerun command? If you do that then you can create a Mock with a 
spec_set.


- Zameer Manji


On Feb. 27, 2015, 12:58 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 12:58 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.
> 
> 
> Bugs: AURORA-1027
> https://issues.apache.org/jira/browse/AURORA-1027
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This splits src/main/python/apache/thermos/bin/thermos.py into 
> src/main/python/apache/thermos/cli/**.
> 
> This also adds a path detector registry (AURORA-1027) for the client so that 
> we can easily add a customized aurora entry point for thermos that is capable 
> of finding checkpoint roots in executor sandboxes.  Added said entry point in 
> src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
> this should live (possibly under aurora/executor/bin?)  This is a drop-in 
> replacement for the existing thermos binary.
> 
> The cli/commands/*.py are mostly no-op splits with only a few lines changed 
> in gc, status and tail to get_path_detector.
> 
> Added a basic testing framework and an example test for simplerun but did not 
> go with full coverage, instead opting to ship AURORA-1027 for now.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/bin/BUILD 
> 1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
>   src/main/python/apache/thermos/bin/thermos.py 
> 0853a9892399824385bee9e72db4c108f46fceda 
>   src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/common.py PRE-CREATION 
>   src/main/python/apache/thermos/cli/main.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
>   src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31559/diff/
> 
> 
> Testing
> ---
> 
> ./pants test src/test/python/apache/thermos/cli::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Aurora ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review74596
---


Master (e8a0a9f) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.factory   
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 src.test.python.apache.aurora.config.test_base 
 .   SUCCESS
 
src.test.python.apache.aurora.config.test_constraint_parsing
.   SUCCESS
 src.test.python.apache.aurora.config.test_loader   
 .   SUCCESS
 src.test.python.apache.aurora.config.test_thrift   
 .   SUCCESS
 src.test.python.apache.aurora.executor.common.announcer
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.directory_sandbox 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_detector 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.executor_timeout  
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.health_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.kill_manager 
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 
src.test.python.apache.aurora.executor.common.status_checker
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_base   
 .   SUCCESS
 src.test.python.apache.aurora.executor.executor_vars   
 .   SUCCESS
 src.test.python.apache.aurora.executor.gc_executor 
 .   SUCCESS
 src.test.python.apache.aurora.executor.status_manager  
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_executor
 .   SUCCESS
 src.test.python.apache.aurora.executor.thermos_task_runner 
 .   SUCCESS
 src.test.python.apache.thermos.bin.test_thermos
 .   FAILURE
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 src.test.python.apache.thermos.core.test_process   
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE


   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 27, 2015, 8:58 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31559/
> ---
> 
> (Updated Feb. 27, 2015, 8:58 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Zameer Manji.

Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

[Brian Wickman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/
---

Review request for Aurora, Joe Smith and Zameer Manji.


Bugs: AURORA-1027
https://issues.apache.org/jira/browse/AURORA-1027


Repository: aurora


Description
---

This splits src/main/python/apache/thermos/bin/thermos.py into 
src/main/python/apache/thermos/cli/**.

This also adds a path detector registry (AURORA-1027) for the client so that we 
can easily add a customized aurora entry point for thermos that is capable of 
finding checkpoint roots in executor sandboxes.  Added said entry point in 
src/main/apache/aurora/tools/thermos.py -- open for other suggestions where 
this should live (possibly under aurora/executor/bin?)  This is a drop-in 
replacement for the existing thermos binary.

The cli/commands/*.py are mostly no-op splits with only a few lines changed in 
gc, status and tail to get_path_detector.

Added a basic testing framework and an example test for simplerun but did not 
go with full coverage, instead opting to ship AURORA-1027 for now.


Diffs
-

  src/main/python/apache/aurora/tools/BUILD PRE-CREATION 
  src/main/python/apache/aurora/tools/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/bin/BUILD 
1a002da4f8294b3ecd43ab845eb15bc8ebd12b26 
  src/main/python/apache/thermos/bin/thermos.py 
0853a9892399824385bee9e72db4c108f46fceda 
  src/main/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/bin/thermos.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/gc.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/help.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/inspect.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/kill.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/read.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/run.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/simplerun.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/status.py PRE-CREATION 
  src/main/python/apache/thermos/cli/commands/tail.py PRE-CREATION 
  src/main/python/apache/thermos/cli/common.py PRE-CREATION 
  src/main/python/apache/thermos/cli/main.py PRE-CREATION 
  src/test/python/apache/thermos/cli/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/BUILD PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_import.py PRE-CREATION 
  src/test/python/apache/thermos/cli/commands/test_simplerun.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_common.py PRE-CREATION 
  src/test/python/apache/thermos/cli/test_main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/31559/diff/


Testing
---

./pants test src/test/python/apache/thermos/cli::


Thanks,

Brian Wickman